From 83dd3a532bd70a2403a9a70746f2ff24819e5737 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 11:24:58 +0200
Subject: [PATCH 001/118] Qual: Better type check

---
 htdocs/admin/const.php            | 2 +-
 htdocs/core/lib/functions.lib.php | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/htdocs/admin/const.php b/htdocs/admin/const.php
index ae4b9eb35dd..4a80df017cb 100644
--- a/htdocs/admin/const.php
+++ b/htdocs/admin/const.php
@@ -38,7 +38,7 @@ $action=GETPOST('action','alpha');
 $update=GETPOST('update','alpha');
 $delete=GETPOST('delete');	// Do not use alpha here
 $debug=GETPOST('debug','int');
-$consts=GETPOST('const');
+$consts=GETPOST('const','array');
 $constname=GETPOST('constname','alpha');
 $constvalue=GETPOST('constvalue');
 $constnote=GETPOST('constnote','alpha');
diff --git a/htdocs/core/lib/functions.lib.php b/htdocs/core/lib/functions.lib.php
index 46cc8e79991..2db0ac1fe29 100644
--- a/htdocs/core/lib/functions.lib.php
+++ b/htdocs/core/lib/functions.lib.php
@@ -174,7 +174,7 @@ function dol_shutdown()
  *  @param	string	$paramname   Name of parameter to found
  *  @param	string	$check	     Type of check (''=no check,  'int'=check it's numeric, 'alpha'=check it's text and sign, 'az'=check it's a-z only, 'array'=check it's array)
  *  @param	int		$method	     Type of method (0 = get then post, 1 = only get, 2 = only post, 3 = post then get, 4 = post then get then cookie)
- *  @return string      		 Value found, or '' if check fails
+ *  @return string||string[]      		 Value found, or '' if check fails
  */
 function GETPOST($paramname,$check='',$method=0)
 {

From 39c064cb740176ff3b312673757dc9e4cae36fe8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 11:29:25 +0200
Subject: [PATCH 002/118] Qual: Removed useless assignment from void method

---
 htdocs/core/ajax/row.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/ajax/row.php b/htdocs/core/ajax/row.php
index 55e0d1c27b5..9a5ecd3562c 100644
--- a/htdocs/core/ajax/row.php
+++ b/htdocs/core/ajax/row.php
@@ -60,7 +60,7 @@ if ((isset($_POST['roworder']) && ! empty($_POST['roworder'])) && (isset($_POST[
 	$row->table_element_line = $table_element_line;
 	$row->fk_element = $fk_element;
 	$row->id = $element_id;
-	$result=$row->line_ajaxorder($newrowordertab);
+	$row->line_ajaxorder($newrowordertab);
 
 	// Reorder line to have position of chilren lines sharing same counter than parent lines
 	// This should be useless because there is no need to have children sharing same counter that parent.

From 4bf426c816e3706336c38e883484a8e925f9b19b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 11:40:34 +0200
Subject: [PATCH 003/118] Qual: Undeclared variable replacement

---
 htdocs/core/class/commondocgenerator.class.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/class/commondocgenerator.class.php b/htdocs/core/class/commondocgenerator.class.php
index af39da58cf7..545744ae8cd 100644
--- a/htdocs/core/class/commondocgenerator.class.php
+++ b/htdocs/core/class/commondocgenerator.class.php
@@ -62,7 +62,7 @@ abstract class CommonDocGenerator
         	'myuser_fax'=>$user->office_fax,
             'myuser_mobile'=>$user->user_mobile,
             'myuser_email'=>$user->email,
-        	'myuser_logo'=>$logotouse,
+        	'myuser_logo'=>$user->photo,
             'myuser_web'=>''	// url not exist in $user object
         );
     }

From 284057d44748855685359a25e0d2249fd67207d2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 11:41:49 +0200
Subject: [PATCH 004/118] Qual: Wrong variable name

---
 htdocs/core/class/commondocgenerator.class.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/class/commondocgenerator.class.php b/htdocs/core/class/commondocgenerator.class.php
index 545744ae8cd..299fd4753e5 100644
--- a/htdocs/core/class/commondocgenerator.class.php
+++ b/htdocs/core/class/commondocgenerator.class.php
@@ -139,7 +139,7 @@ abstract class CommonDocGenerator
         {
         	$object->country=$outputlangs->transnoentitiesnoconv("Country".$object->country_code);
         }
-        if (empty($mysoc->state) && ! empty($mysoc->state_code))
+        if (empty($object->state) && ! empty($object->state_code))
         {
         	$object->state=getState($object->state_code,0);
         }

From c8b1c3b57d5091ce55887025038e64e902b85072 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 11:44:32 +0200
Subject: [PATCH 005/118] Qual: Wrong type in method documentation

---
 htdocs/core/class/commondocgenerator.class.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/class/commondocgenerator.class.php b/htdocs/core/class/commondocgenerator.class.php
index 299fd4753e5..1b290222a11 100644
--- a/htdocs/core/class/commondocgenerator.class.php
+++ b/htdocs/core/class/commondocgenerator.class.php
@@ -418,7 +418,7 @@ abstract class CommonDocGenerator
      *	@param  Object			$object				Object with extrafields (must have $object->array_options filled)
      *	@param  array			$array_to_fill      Substitution array
      *  @param  Extrafields		$extrafields        Extrafields object
-     *  @param   array_key		$array_key	        Name of the key for return array
+     *  @param  string			$array_key	        Name of the key for return array
      *  @param  Translate		$outputlangs        Lang object to use for output
      *	@return	array								Substitution array
      */

From 7cf553a6365dfc37fe94feb523d96edad6c5c148 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 11:46:37 +0200
Subject: [PATCH 006/118] Qual: Missing variable declaration

---
 htdocs/core/class/commoninvoice.class.php | 1 +
 1 file changed, 1 insertion(+)

diff --git a/htdocs/core/class/commoninvoice.class.php b/htdocs/core/class/commoninvoice.class.php
index 0314bf34413..5c9d6257fb9 100644
--- a/htdocs/core/class/commoninvoice.class.php
+++ b/htdocs/core/class/commoninvoice.class.php
@@ -253,6 +253,7 @@ abstract class CommonInvoice extends CommonObject
 		}
 		if ($mode == 4)
 		{
+			$prefix='';
 			if (! $paye)
 			{
 				if ($status == 0) return img_picto($langs->trans('BillStatusDraft'),'statut0').' '.$langs->trans('BillStatusDraft');

From 84c9a390eb898f6ffb22907bcd594eae01009491 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 11:48:59 +0200
Subject: [PATCH 007/118] Qual: Mistyped class property

---
 htdocs/core/class/commonobject.class.php | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/htdocs/core/class/commonobject.class.php b/htdocs/core/class/commonobject.class.php
index ba4094c2a14..22b340a6fab 100644
--- a/htdocs/core/class/commonobject.class.php
+++ b/htdocs/core/class/commonobject.class.php
@@ -83,10 +83,10 @@ abstract class CommonObject
         if (empty($firstname)) $firstname=$this->firstname;
 
         $ret='';
-        if ($option && $this->civilite_id)
+        if ($option && $this->civility_id)
         {
-            if ($langs->transnoentitiesnoconv("Civility".$this->civilite_id)!="Civility".$this->civilite_id) $ret.=$langs->transnoentitiesnoconv("Civility".$this->civilite_id).' ';
-            else $ret.=$this->civilite_id.' ';
+            if ($langs->transnoentitiesnoconv("Civility".$this->civility_id)!="Civility".$this->civility_id) $ret.=$langs->transnoentitiesnoconv("Civility".$this->civility_id).' ';
+            else $ret.=$this->civility_id.' ';
         }
 
         $ret.=dolGetFirstLastname($firstname, $lastname, $nameorder);

From 6cfcdbfe5683cbf839423320f3fadaada406d5d1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 11:52:48 +0200
Subject: [PATCH 008/118] Qual: Wrong type in method documentation

---
 htdocs/core/class/commonobject.class.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/htdocs/core/class/commonobject.class.php b/htdocs/core/class/commonobject.class.php
index 22b340a6fab..5508887f139 100644
--- a/htdocs/core/class/commonobject.class.php
+++ b/htdocs/core/class/commonobject.class.php
@@ -241,8 +241,8 @@ abstract class CommonObject
     /**
      *    Copy contact from one element to current
      *
-     *    @param    int     $objFrom			Source element
-     *    @param    int		$source             Nature of contact ('internal' or 'external')
+     *    @param    CommonObject    $objFrom    Source element
+     *    @param    string          $source     Nature of contact ('internal' or 'external')
      *    @return   int                         >0 if OK, <0 if KO
      */
     function copy_linked_contact($objFrom, $source='internal')

From db91684193e960af467adf5b7d35dbadd2193d56 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 11:57:11 +0200
Subject: [PATCH 009/118] Qual: Wrong type in method documentation

---
 htdocs/core/lib/price.lib.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/lib/price.lib.php b/htdocs/core/lib/price.lib.php
index a546d229481..7be5f3e2ee5 100644
--- a/htdocs/core/lib/price.lib.php
+++ b/htdocs/core/lib/price.lib.php
@@ -45,7 +45,7 @@
  *		@param	string	$price_base_type 			HT=on calcule sur le HT, TTC=on calcule sur le TTC
  *		@param	int		$info_bits					Miscellaneous informations on line
  *		@param	int		$type						0/1=Product/service
- *		@param  string	$seller						Thirdparty seller (we need $seller->country_id property). Provided only if seller is the supplier, otherwise $seller will be $mysoc.
+ *		@param  Societe	$seller						Thirdparty seller (we need $seller->country_id property). Provided only if seller is the supplier, otherwise $seller will be $mysoc.
  *		@param  array	$localtaxes_array			Array with localtaxes info (loaded by getLocalTaxesFromRate function).
  *		@return result[ 0=total_ht,
  *						 1=total_vat,

From 670e861d7b3b4c8df90a809e4b06337907ade2b5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 11:57:53 +0200
Subject: [PATCH 010/118] Qual: Missing global declaration

---
 htdocs/core/class/commonobject.class.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/class/commonobject.class.php b/htdocs/core/class/commonobject.class.php
index 5508887f139..7fc5d9b50c2 100644
--- a/htdocs/core/class/commonobject.class.php
+++ b/htdocs/core/class/commonobject.class.php
@@ -2278,7 +2278,7 @@ abstract class CommonObject
      */
     function showOptionals($extrafields, $mode='view', $params=0, $keyprefix='')
     {
-		global $_POST;
+		global $_POST, $conf;
 
 		$out = '';
 

From d57b4192b65dec99da4865ed862c38c3bd573037 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 11:59:33 +0200
Subject: [PATCH 011/118] Qual: Wrong variable name

---
 htdocs/core/class/commonobject.class.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/class/commonobject.class.php b/htdocs/core/class/commonobject.class.php
index 7fc5d9b50c2..838894fc851 100644
--- a/htdocs/core/class/commonobject.class.php
+++ b/htdocs/core/class/commonobject.class.php
@@ -2482,7 +2482,7 @@ abstract class CommonObject
         	$i=0;
         	while ($i < $num)
         	{
-            	$obj = $this->db->fetch_object($query);
+            	$obj = $this->db->fetch_object($resql);
 
             	$pu_ht = $obj->pu_ht;
             	$qty= $obj->qty;

From 3eabffbc7c92887bc529eb755218bdb49ca4cde1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 12:01:51 +0200
Subject: [PATCH 012/118] Qual: Missing global declaration

---
 htdocs/core/class/conf.class.php | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/htdocs/core/class/conf.class.php b/htdocs/core/class/conf.class.php
index e9b2728ad3f..a79cb494bd4 100644
--- a/htdocs/core/class/conf.class.php
+++ b/htdocs/core/class/conf.class.php
@@ -119,6 +119,8 @@ class Conf
 	 */
 	function setValues($db)
 	{
+		global $conf;
+
 		dol_syslog(get_class($this)."::setValues");
 
 		/*

From 258c92ab1c71a767d7b48b914718be369daae4ae Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 12:03:01 +0200
Subject: [PATCH 013/118] Qual: Avoid wrong declaration

---
 htdocs/core/class/discount.class.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/class/discount.class.php b/htdocs/core/class/discount.class.php
index ede7615a65a..78c0add9aab 100644
--- a/htdocs/core/class/discount.class.php
+++ b/htdocs/core/class/discount.class.php
@@ -188,7 +188,7 @@ class DiscountAbsolute
         // Check if we can remove the discount
         if ($this->fk_facture_source)
         {
-            $sql.="SELECT COUNT(rowid) as nb";
+            $sql="SELECT COUNT(rowid) as nb";
             $sql.=" FROM ".MAIN_DB_PREFIX."societe_remise_except";
             $sql.=" WHERE (fk_facture_line IS NOT NULL";	// Not used as absolute simple discount
             $sql.=" OR fk_facture IS NOT NULL)"; 			// Not used as credit note and not used as deposit

From b522d51d494b29573ff150cc7ea821b99f588024 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 12:04:19 +0200
Subject: [PATCH 014/118] Qual: Missing global declaration

---
 htdocs/core/class/dolprintipp.class.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/class/dolprintipp.class.php b/htdocs/core/class/dolprintipp.class.php
index 926f5c42b42..768741d9368 100644
--- a/htdocs/core/class/dolprintipp.class.php
+++ b/htdocs/core/class/dolprintipp.class.php
@@ -126,7 +126,7 @@ class dolprintIPP
      */
     function list_jobs($module)
     {
-        global $conf,$db;
+        global $conf, $db, $bc;
         include_once DOL_DOCUMENT_ROOT.'/includes/printipp/CupsPrintIPP.php';
         $ipp = new CupsPrintIPP();
         $ipp->setLog(DOL_DATA_ROOT.'/printipp.log','file',3); // logging very verbose

From a22ead5e9735e4d60e2bc37eb72620124b7a58b8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 12:07:22 +0200
Subject: [PATCH 015/118] Qual: Wrong type in method documentation

---
 htdocs/core/class/extrafields.class.php | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/htdocs/core/class/extrafields.class.php b/htdocs/core/class/extrafields.class.php
index a980b4bef85..d5aa8594076 100644
--- a/htdocs/core/class/extrafields.class.php
+++ b/htdocs/core/class/extrafields.class.php
@@ -207,16 +207,16 @@ class ExtraFields
 	/**
 	 *	Add description of a new optional attribute
 	 *
-	 *	@param	string	$attrname			code of attribute
-	 *	@param	string	$label				label of attribute
-	 *  @param	int		$type				Type of attribute ('int', 'text', 'varchar', 'date', 'datehour', 'float')
-	 *  @param	int		$pos				Position of attribute
-	 *  @param	int		$size				Size/length of attribute
-	 *  @param  string	$elementtype        Element type ('member', 'product', 'company', ...)
-	 *  @param	int		$unique				Is field unique or not
-	 *  @param	int		$required			Is field required or not
-	 *  @param  array	$param				Params for field  (ex for select list : array('options' => array(value'=>'label of option')) )
-	 *  @return	int							<=0 if KO, >0 if OK
+	 *	@param	string			$attrname		code of attribute
+	 *	@param	string			$label			label of attribute
+	 *  @param	int				$type			Type of attribute ('int', 'text', 'varchar', 'date', 'datehour', 'float')
+	 *  @param	int				$pos			Position of attribute
+	 *  @param	int				$size			Size/length of attribute
+	 *  @param  string			$elementtype	Element type ('member', 'product', 'company', ...)
+	 *  @param	int				$unique			Is field unique or not
+	 *  @param	int				$required		Is field required or not
+	 *  @param  array||string	$param			Params for field  (ex for select list : array('options' => array(value'=>'label of option')) )
+	 *  @return	int								<=0 if KO, >0 if OK
 	 */
 	private function create_label($attrname, $label='', $type='', $pos=0, $size=0, $elementtype='member', $unique=0, $required=0, $param='')
 	{

From 70c9dda9642c3e96c0983d9520477d9054f0b846 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 12:11:15 +0200
Subject: [PATCH 016/118] Qual: Missing global declaration

---
 htdocs/core/class/extrafields.class.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/class/extrafields.class.php b/htdocs/core/class/extrafields.class.php
index d5aa8594076..93cd55e31ca 100644
--- a/htdocs/core/class/extrafields.class.php
+++ b/htdocs/core/class/extrafields.class.php
@@ -581,7 +581,7 @@ class ExtraFields
 	 */
 	function showInputField($key,$value,$moreparam='',$keyprefix='')
 	{
-		global $conf,$langs;
+		global $conf,$langs,$db;
 
 		$label=$this->attribute_label[$key];
 		$type =$this->attribute_type[$key];

From 2938ec06b213b67686f01e54bab59410e31784b9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 14:26:57 +0200
Subject: [PATCH 017/118] Qual: Fixed typo

---
 htdocs/core/class/cookie.class.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/htdocs/core/class/cookie.class.php b/htdocs/core/class/cookie.class.php
index a45aaeb2423..629cf927815 100644
--- a/htdocs/core/class/cookie.class.php
+++ b/htdocs/core/class/cookie.class.php
@@ -34,7 +34,7 @@ class DolCookie
 	var $myExpire;
 	var $myPath;
 	var $myDomain;
-	var	$mySsecure;
+	var	$mySecure;
 	var $cookiearray;
 	var $cookie;
 
@@ -144,4 +144,4 @@ class DolCookie
 
 }
 
-?>
\ No newline at end of file
+?>

From 70cf592270aa783fa6d6ef5a7b246562b015ec43 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 14:27:17 +0200
Subject: [PATCH 018/118] Qual: Wrong type in method documentation

---
 htdocs/core/class/cookie.class.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/class/cookie.class.php b/htdocs/core/class/cookie.class.php
index 629cf927815..5d3d5352626 100644
--- a/htdocs/core/class/cookie.class.php
+++ b/htdocs/core/class/cookie.class.php
@@ -80,7 +80,7 @@ class DolCookie
 	/**
 	 * Decrypt the cookie
 	 *
-	 * @return	void
+	 * @return	string
 	 */
 	function decryptCookie()
 	{

From e3385119a4276159586e82bb468a2512f72cbb81 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 14:30:57 +0200
Subject: [PATCH 019/118] Qual: Missing argument

---
 htdocs/core/class/fileupload.class.php | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/htdocs/core/class/fileupload.class.php b/htdocs/core/class/fileupload.class.php
index 910ad55e0a0..b5483139fb6 100644
--- a/htdocs/core/class/fileupload.class.php
+++ b/htdocs/core/class/fileupload.class.php
@@ -558,7 +558,8 @@ class FileUpload
                 isset($_SERVER['HTTP_X_FILE_NAME']) ? $_SERVER['HTTP_X_FILE_NAME'] : (isset($upload['name']) ? $upload['name'] : null),
                 isset($_SERVER['HTTP_X_FILE_SIZE']) ? $_SERVER['HTTP_X_FILE_SIZE'] : (isset($upload['size']) ? $upload['size'] : null),
                 isset($_SERVER['HTTP_X_FILE_TYPE']) ? $_SERVER['HTTP_X_FILE_TYPE'] : (isset($upload['type']) ? $upload['type'] : null),
-                isset($upload['error']) ? $upload['error'] : null
+                isset($upload['error']) ? $upload['error'] : null,
+                0
             );
 		}
 		header('Vary: Accept');

From cd774c0dcd048e2389854b7fdab8c465f97a8741 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 14:31:39 +0200
Subject: [PATCH 020/118] Qual: Missing global declaration

---
 htdocs/core/class/html.form.class.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/class/html.form.class.php b/htdocs/core/class/html.form.class.php
index 0943bce1e87..0c5fe571eda 100644
--- a/htdocs/core/class/html.form.class.php
+++ b/htdocs/core/class/html.form.class.php
@@ -3160,7 +3160,7 @@ class Form
      */
     function form_contacts($page, $societe, $selected='', $htmlname='contactidp')
     {
-        global $langs;
+        global $langs, $conf;
 
         if ($htmlname != "none")
         {

From 9d7fc43951985697c55f3aadc27dffd5321ac4d7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 14:37:20 +0200
Subject: [PATCH 021/118] Qual: Wrong type in method documentation

---
 htdocs/core/class/html.formadmin.class.php | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/htdocs/core/class/html.formadmin.class.php b/htdocs/core/class/html.formadmin.class.php
index 6d570b70880..cf23a0871a5 100644
--- a/htdocs/core/class/html.formadmin.class.php
+++ b/htdocs/core/class/html.formadmin.class.php
@@ -199,9 +199,9 @@ class FormAdmin
     /**
      *  Return combo list of available menu families
      *
-     *  @param	string	$selected        Menu pre-selected
-     *  @param  string	$htmlname        Name of html select
-     *  @param	string	$dirmenuarray    Directories to scan
+     *  @param	string		$selected        Menu pre-selected
+     *  @param	string		$htmlname        Name of html select
+     *  @param	string[]	$dirmenuarray    Directories to scan
      *  @return	void
      */
     function select_menu_families($selected, $htmlname, $dirmenuarray)

From 0be3d3bd2f74601452a58fbb1adce0e0ce78842a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 14:39:32 +0200
Subject: [PATCH 022/118] Qual: Missing global declaration

---
 htdocs/core/class/html.formfile.class.php | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/htdocs/core/class/html.formfile.class.php b/htdocs/core/class/html.formfile.class.php
index 5317d49c23c..334fb9a5d9e 100644
--- a/htdocs/core/class/html.formfile.class.php
+++ b/htdocs/core/class/html.formfile.class.php
@@ -257,8 +257,7 @@ class FormFile
      */
     function showdocuments($modulepart,$modulesubdir,$filedir,$urlsource,$genallowed,$delallowed=0,$modelselected='',$allowgenifempty=1,$forcenomultilang=0,$iconPDF=0,$maxfilenamelength=28,$noform=0,$param='',$title='',$buttonlabel='',$codelang='',$morepicto='')
     {
-        global $langs,$conf,$hookmanager;
-        global $bc;
+        global $langs,$conf,$hookmanager,$user,$bc;
 
         // filedir = $conf->...->dir_ouput."/".get_exdir(id)
         include_once DOL_DOCUMENT_ROOT.'/core/lib/files.lib.php';

From 7039fd38927e54fcc383b997e2929d0ceeb4f321 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 14:41:58 +0200
Subject: [PATCH 023/118] Qual: Missing class property declaration

---
 htdocs/core/class/html.formmail.class.php | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/htdocs/core/class/html.formmail.class.php b/htdocs/core/class/html.formmail.class.php
index a76877c9994..b2c91087916 100644
--- a/htdocs/core/class/html.formmail.class.php
+++ b/htdocs/core/class/html.formmail.class.php
@@ -58,7 +58,8 @@ class FormMail
     var $withreplytoreadonly;
     var $withtoreadonly;
     var $withtoccreadonly;
-    var $withtopicreadonly;
+	var $withtocccreadonly;
+	var $withtopicreadonly;
     var $withfilereadonly;
     var $withdeliveryreceipt;
     var $withcancel;
@@ -95,6 +96,7 @@ class FormMail
         $this->withreplytoreadonly=1;
         $this->withtoreadonly=0;
         $this->withtoccreadonly=0;
+	    $this->withtocccreadonly=0;
         $this->witherrorstoreadonly=0;
         $this->withtopicreadonly=0;
         $this->withfilereadonly=0;

From 0ca5a46345fdd5456f94c68ca3226e34f02fc164 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 14:44:43 +0200
Subject: [PATCH 024/118] Qual: Bad copy/paste

---
 htdocs/core/class/html.formother.class.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/class/html.formother.class.php b/htdocs/core/class/html.formother.class.php
index 916f2cbcd9a..85bd466f948 100644
--- a/htdocs/core/class/html.formother.class.php
+++ b/htdocs/core/class/html.formother.class.php
@@ -391,7 +391,7 @@ class FormOther
                 $moreinfo=0;
                 if (! empty($conf->global->MAIN_SHOW_LOGIN))
                 {
-                	$out.=($moreinfo?' - ':' (').$obj->login;
+                	$moreforfilter.=($moreinfo?' - ':' (').$obj_usr->login;
                 	$moreinfo++;
                 }
                 if ($showstatus >= 0)

From 32ad4461b8469062db15de578c6c2271e2a802be Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 14:47:02 +0200
Subject: [PATCH 025/118] Qual: Missing method argument

---
 htdocs/core/class/html.formother.class.php | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/htdocs/core/class/html.formother.class.php b/htdocs/core/class/html.formother.class.php
index 85bd466f948..3ac6ce0eba1 100644
--- a/htdocs/core/class/html.formother.class.php
+++ b/htdocs/core/class/html.formother.class.php
@@ -1095,9 +1095,10 @@ class FormOther
      *  @param	string	$labelfield			Label field
      *  @param	string	$selected			Selected value
      *  @param  int		$useempty          	1=Add an empty value in list, 2=Add an empty value in list only if there is more than 2 entries.
+     *  @param  string  $moreattrib         More attributes on HTML select tag
      * 	@return	void
      */
-    function select_dictionary($htmlname,$dictionarytable,$keyfield='code',$labelfield='label',$selected='',$useempty=0)
+    function select_dictionary($htmlname,$dictionarytable,$keyfield='code',$labelfield='label',$selected='',$useempty=0,$moreattrib='')
     {
         global $langs, $conf;
 

From 749973f1b650a96390da5707b539a3176e3b98d1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 14:51:08 +0200
Subject: [PATCH 026/118] Qual: Missing variable declaration

---
 htdocs/core/class/html.formsms.class.php | 1 +
 1 file changed, 1 insertion(+)

diff --git a/htdocs/core/class/html.formsms.class.php b/htdocs/core/class/html.formsms.class.php
index 808c3fc4b8e..910460b4884 100644
--- a/htdocs/core/class/html.formsms.class.php
+++ b/htdocs/core/class/html.formsms.class.php
@@ -213,6 +213,7 @@ function limitChars(textarea, limit, infodiv)
                 else
                 {
                     dol_syslog("Warning: The SMS sending method has not been defined into MAIN_SMS_SENDMODE", LOG_WARNING);
+	                $resultsender=array();
                     $resultsender[0]->number=$this->fromsms;
                 }
 

From 0fa803977ee43ea3e0c9877765c649fe5a2cf134 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 14:54:34 +0200
Subject: [PATCH 027/118] Qual: Removed call to inexistant object

---
 htdocs/core/class/infobox.class.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/class/infobox.class.php b/htdocs/core/class/infobox.class.php
index 622cc757983..2e04fdfa752 100644
--- a/htdocs/core/class/infobox.class.php
+++ b/htdocs/core/class/infobox.class.php
@@ -201,7 +201,7 @@ class InfoBox
         $tab[$confuserzone]=1;
         if (dol_set_user_param($db, $conf, $user, $tab) < 0)
         {
-            $this->error=$db->lasterror();
+            $error=$db->lasterror();
             $db->rollback();
             return -3;
         }

From 1bb99da8db1cf43ba807525422b0736a8b4a567b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 14:57:47 +0200
Subject: [PATCH 028/118] Qual: Wrong type in method documentation

---
 htdocs/core/class/ldap.class.php | 50 ++++++++++++++++----------------
 1 file changed, 25 insertions(+), 25 deletions(-)

diff --git a/htdocs/core/class/ldap.class.php b/htdocs/core/class/ldap.class.php
index 2a3eb3647ae..5a6c2e8b6de 100644
--- a/htdocs/core/class/ldap.class.php
+++ b/htdocs/core/class/ldap.class.php
@@ -359,10 +359,10 @@ class Ldap
 	 * 	Add a LDAP entry
 	 *	Ldap object connect and bind must have been done
 	 *
-	 *	@param	string	$dn			DN entry key
-	 *	@param	string	$info		Attributes array
-	 *	@param	User	$user		Objet user that create
-	 *	@return	int					<0 if KO, >0 if OK
+	 *	@param	string		$dn			DN entry key
+	 *	@param	string[]	$info		Attributes array
+	 *	@param	User		$user		Objet user that create
+	 *	@return	int						<0 if KO, >0 if OK
 	 */
 	function add($dn, $info, $user)
 	{
@@ -413,7 +413,7 @@ class Ldap
 	 *	Ldap object connect and bind must have been done
 	 *
 	 *	@param	string		$dn			DN entry key
-	 *	@param	string		$info		Attributes array
+	 *	@param	string[]	$info		Attributes array
 	 *	@param	string		$user		Objet user that modify
 	 *	@return	int						<0 if KO, >0 if OK
 	 */
@@ -465,7 +465,7 @@ class Ldap
 	 *	Ldap object connect and bind must have been done
 	 *
 	 *  @param	string		$dn			DN entry key
-	 *  @param  string		$info		Attributes array
+	 *  @param  string[]	$info		Attributes array
 	 *  @param  User		$user		Objet user that update
 	 * 	@param	string		$olddn		Old DN entry key (before update)
 	 *	@return	int						<0 if KO, >0 if OK
@@ -552,9 +552,9 @@ class Ldap
 	/**
 	 * 	Build a LDAP message
 	 *
-	 *	@param	string	$dn			DN entry key
-	 *	@param	string	$info		Attributes array
-	 *	@return	string				Content of file
+	 *	@param	string		$dn			DN entry key
+	 *	@param	string[]	$info		Attributes array
+	 *	@return	string					Content of file
 	 */
 	function dump_content($dn, $info)
 	{
@@ -594,9 +594,9 @@ class Ldap
 	/**
 	 * 	Dump a LDAP message to ldapinput.in file
 	 *
-	 *	@param	string	$dn			DN entry key
-	 *	@param	string	$info		Attributes array
-	 *	@return	int					<0 if KO, >0 if OK
+	 *	@param	string		$dn			DN entry key
+	 *	@param	string[]	$info		Attributes array
+	 *	@return	int						<0 if KO, >0 if OK
 	 */
 	function dump($dn, $info)
 	{
@@ -631,10 +631,10 @@ class Ldap
 	 * 	Add a LDAP attribute in entry
 	 *	Ldap object connect and bind must have been done
 	 *
-	 *	@param	string	$dn			DN entry key
-	 *	@param	string	$info		Attributes array
-	 *	@param	User	$user		Objet user that create
-	 *	@return	int					<0 if KO, >0 if OK
+	 *	@param	string		$dn			DN entry key
+	 *	@param	string[]	$info		Attributes array
+	 *	@param	User		$user		Objet user that create
+	 *	@return	int						<0 if KO, >0 if OK
 	 */
 	function addAttribute($dn, $info, $user)
 	{
@@ -683,10 +683,10 @@ class Ldap
 	 * 	Update a LDAP attribute in entry
 	 *	Ldap object connect and bind must have been done
 	 *
-	 *	@param	string	$dn			DN entry key
-	 *	@param	string	$info		Attributes array
-	 *	@param	User	$user		Objet user that create
-	 *	@return	int					<0 if KO, >0 if OK
+	 *	@param	string		$dn			DN entry key
+	 *	@param	string[]	$info		Attributes array
+	 *	@param	User		$user		Objet user that create
+	 *	@return	int						<0 if KO, >0 if OK
 	 */
 	function updateAttribute($dn, $info, $user)
 	{
@@ -735,10 +735,10 @@ class Ldap
 	 * 	Delete a LDAP attribute in entry
 	 *	Ldap object connect and bind must have been done
 	 *
-	 *	@param	string	$dn			DN entry key
-	 *	@param	string	$info		Attributes array
-	 *	@param	User	$user		Objet user that create
-	 *	@return	int					<0 if KO, >0 if OK
+	 *	@param	string		$dn			DN entry key
+	 *	@param	string[]	$info		Attributes array
+	 *	@param	User		$user		Objet user that create
+	 *	@return	int						<0 if KO, >0 if OK
 	 */
 	function deleteAttribute($dn, $info, $user)
 	{
@@ -1370,4 +1370,4 @@ class Ldap
 }
 
 
-?>
\ No newline at end of file
+?>

From aa5d0b37b728ba2d5735f0eba6bb60ebf74f9acb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 15:03:56 +0200
Subject: [PATCH 029/118] Qual: Wrong type in method documentation

---
 htdocs/core/class/menubase.class.php       | 2 +-
 htdocs/core/menus/standard/auguria.lib.php | 2 +-
 htdocs/core/menus/standard/eldy.lib.php    | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/htdocs/core/class/menubase.class.php b/htdocs/core/class/menubase.class.php
index c884344dd1f..88908abfbe6 100644
--- a/htdocs/core/class/menubase.class.php
+++ b/htdocs/core/class/menubase.class.php
@@ -403,7 +403,7 @@ class Menubase
     /**
      * 	Load entries found from database in this->newmenu array.
      *
-     * 	@param	array	$newmenu        Menu array to complete (in most cases, it's empty, may be already initialized with some menu manager like eldy)
+     * 	@param	Menu	$newmenu        Menu array to complete (in most cases, it's empty, may be already initialized with some menu manager like eldy)
      * 	@param	string	$mymainmenu		Value for mainmenu to filter menu to load (often $_SESSION["mainmenu"])
      * 	@param	string	$myleftmenu		Value for leftmenu to filter menu to load (always '')
      * 	@param	int		$type_user		0=Menu for backoffice, 1=Menu for front office
diff --git a/htdocs/core/menus/standard/auguria.lib.php b/htdocs/core/menus/standard/auguria.lib.php
index c395b775937..a820243ba66 100644
--- a/htdocs/core/menus/standard/auguria.lib.php
+++ b/htdocs/core/menus/standard/auguria.lib.php
@@ -202,7 +202,7 @@ function print_end_menu_array_auguria()
  * @param 	array		$menu_array_before  Table of menu entries to show before entries of menu handler
  * @param   array		$menu_array_after   Table of menu entries to show after entries of menu handler
  * @param  	array		&$tabMenu       	If array with menu entries already loaded, we put this array here (in most cases, it's empty)
- * @param	array		&$menu				Object Menu to return back list of menu entries
+ * @param	Menu		&$menu				Object Menu to return back list of menu entries
  * @param	int			$noout				Disable output (Initialise &$menu only).
  * @param	string		$forcemainmenu		'x'=Force mainmenu to mainmenu='x'
  * @param	string		$forceleftmenu		'all'=Force leftmenu to '' (= all)
diff --git a/htdocs/core/menus/standard/eldy.lib.php b/htdocs/core/menus/standard/eldy.lib.php
index 0088de9955c..e400c72c027 100644
--- a/htdocs/core/menus/standard/eldy.lib.php
+++ b/htdocs/core/menus/standard/eldy.lib.php
@@ -427,7 +427,7 @@ function print_end_menu_array()
  * @param 	array		$menu_array_before  Table of menu entries to show before entries of menu handler (menu->liste filled with menu->add)
  * @param   array		$menu_array_after   Table of menu entries to show after entries of menu handler (menu->liste filled with menu->add)
  * @param	array		&$tabMenu       	If array with menu entries already loaded, we put this array here (in most cases, it's empty)
- * @param	array		&$menu				Object Menu to return back list of menu entries
+ * @param	Menu		&$menu				Object Menu to return back list of menu entries
  * @param	int			$noout				Disable output (Initialise &$menu only).
  * @param	string		$forcemainmenu		'x'=Force mainmenu to mainmenu='x'
  * @param	string		$forceleftmenu		'all'=Force leftmenu to '' (= all)

From 63166f3f5c82d1723d2f87eb4eec2a021b720e33 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 15:05:00 +0200
Subject: [PATCH 030/118] Qual: Wrong type in method documentation

---
 htdocs/core/class/rssparser.class.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/htdocs/core/class/rssparser.class.php b/htdocs/core/class/rssparser.class.php
index 13c7db642b1..6569027d483 100644
--- a/htdocs/core/class/rssparser.class.php
+++ b/htdocs/core/class/rssparser.class.php
@@ -174,7 +174,7 @@ class RssParser
      * 	@param	string	$urlRSS		Url to parse
      * 	@param	int		$maxNb		Max nb of records to get (0 for no limit)
      * 	@param	int		$cachedelay	0=No cache, nb of seconds we accept cache files (cachedir must also be defined)
-     * 	@param	strnig	$cachedir	Directory where to save cache file
+     * 	@param	string	$cachedir	Directory where to save cache file
      *	@return	int					<0 if KO, >0 if OK
      */
     public function parser($urlRSS, $maxNb=0, $cachedelay=60, $cachedir='')
@@ -775,4 +775,4 @@ function xml2php($xml)
 
 }
 
-?>
\ No newline at end of file
+?>

From af7d2d0b5069a17e13491be884cb1fa3b673bc67 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 15:11:26 +0200
Subject: [PATCH 031/118] Qual: Wrong type in method documentation

---
 htdocs/core/class/rssparser.class.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/class/rssparser.class.php b/htdocs/core/class/rssparser.class.php
index 6569027d483..06d26c94edf 100644
--- a/htdocs/core/class/rssparser.class.php
+++ b/htdocs/core/class/rssparser.class.php
@@ -722,7 +722,7 @@ class RssParser
 /**
  * Function to convert an XML object into an array
  *
- * @param	string	$xml		Xml
+ * @param	SimpleXMLElement	$xml		Xml
  * @return	void
  */
 function xml2php($xml)

From b6312d1efdb1de64294d1b487e5e6a531f7cdbab Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 15:23:02 +0200
Subject: [PATCH 032/118] Qual: Missing method argument

---
 htdocs/core/class/stats.class.php | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/htdocs/core/class/stats.class.php b/htdocs/core/class/stats.class.php
index 874a2740edc..6162e0dcdd0 100644
--- a/htdocs/core/class/stats.class.php
+++ b/htdocs/core/class/stats.class.php
@@ -491,9 +491,10 @@ abstract class Stats
 	 *
      *     @param	int		$year       Year
      *     @param  	string	$sql        SQL
-     *     @return	array
+	 *     @param	int		$format		0=Label of absiss is a translated text, 1=Label of absiss is a number
+	 *     @return	array
 	 */
-	function _getAverageByMonth($year, $sql)
+	function _getAverageByMonth($year, $sql, $format=0)
 	{
 		$result=array();
 		$res=array();

From 43606c8ac4991aa779f3cd26d15eea2901454b1d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 15:24:09 +0200
Subject: [PATCH 033/118] Qual: Fixed typo

---
 htdocs/core/class/translate.class.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/class/translate.class.php b/htdocs/core/class/translate.class.php
index 7a855eb9325..394dd4fad82 100644
--- a/htdocs/core/class/translate.class.php
+++ b/htdocs/core/class/translate.class.php
@@ -703,7 +703,7 @@ class Translate
 	 */
 	function getCurrencyAmount($currency_code, $amount)
 	{
-		$symbol=$this->getCurrencSymbol($currency_code);
+		$symbol=$this->getCurrencySymbol($currency_code);
 
 		if (in_array($currency_code, array('USD'))) return $symbol.$amount;
 		else return $amount.$symbol;

From e5975d52a960553bc3d35ef627d2e2e0525c30c5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 15:28:00 +0200
Subject: [PATCH 034/118] Qual: Wrong type in method documentation

---
 htdocs/core/filemanagerdol/connectors/php/util.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/filemanagerdol/connectors/php/util.php b/htdocs/core/filemanagerdol/connectors/php/util.php
index d221c936fbf..0a7b5fbf9ad 100644
--- a/htdocs/core/filemanagerdol/connectors/php/util.php
+++ b/htdocs/core/filemanagerdol/connectors/php/util.php
@@ -51,7 +51,7 @@ function RemoveFromEnd($sourceString, $charToRemove)
 /**
  * FindBadUtf8
  *
- * @param 	unknown_type $string		String
+ * @param 	string $string		String
  * @return	boolean
  */
 function FindBadUtf8($string)

From aad43597860ca7574cba86761154c7502c144e21 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 15:33:15 +0200
Subject: [PATCH 035/118] Qual: Removed missing variable from function call

---
 htdocs/core/lib/agenda.lib.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/htdocs/core/lib/agenda.lib.php b/htdocs/core/lib/agenda.lib.php
index e66d24e576e..40d1e043c1d 100644
--- a/htdocs/core/lib/agenda.lib.php
+++ b/htdocs/core/lib/agenda.lib.php
@@ -386,14 +386,14 @@ function agenda_prepare_head()
 	$head[$h][2] = 'other';
 	$h++;
 
-	complete_head_from_modules($conf,$langs,$object,$head,$h,'agenda_admin');
+	complete_head_from_modules($conf,$langs,null,$head,$h,'agenda_admin');
 
 	$head[$h][0] = DOL_URL_ROOT."/admin/agenda_extrafields.php";
 	$head[$h][1] = $langs->trans("ExtraFields");
 	$head[$h][2] = 'attributes';
 	$h++;
 
-	complete_head_from_modules($conf,$langs,$object,$head,$h,'agenda_admin','remove');
+	complete_head_from_modules($conf,$langs,null,$head,$h,'agenda_admin','remove');
 
 
 	return $head;

From 75eb98033ffa5edec3cd9bff26e1fb84e4d7c587 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 15:33:51 +0200
Subject: [PATCH 036/118] Qual: Fixed typo

---
 htdocs/core/lib/ajax.lib.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/lib/ajax.lib.php b/htdocs/core/lib/ajax.lib.php
index 72592b1e68f..cddd5cc557e 100644
--- a/htdocs/core/lib/ajax.lib.php
+++ b/htdocs/core/lib/ajax.lib.php
@@ -272,7 +272,7 @@ function ajax_dialog($title,$message,$w=350,$h=150)
 {
 	global $langs;
 
-	$msg.= '<div id="dialog-info" title="'.dol_escape_htmltag($title).'">';
+	$msg= '<div id="dialog-info" title="'.dol_escape_htmltag($title).'">';
 	$msg.= $message;
 	$msg.= '</div>'."\n";
     $msg.= '<script type="text/javascript">

From 996704d25870669247fdc246c9f32221278a08cf Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 15:34:43 +0200
Subject: [PATCH 037/118] Qual: Removed missing variable from function call

---
 htdocs/core/lib/categories.lib.php | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/htdocs/core/lib/categories.lib.php b/htdocs/core/lib/categories.lib.php
index 179ff317294..293644be5dc 100644
--- a/htdocs/core/lib/categories.lib.php
+++ b/htdocs/core/lib/categories.lib.php
@@ -88,12 +88,12 @@ function categoriesadmin_prepare_head()
 	// Entries must be declared in modules descriptor with line
 	// $this->tabs = array('entity:+tabname:Title:@mymodule:/mymodule/mypage.php?id=__ID__');   to add new tab
 	// $this->tabs = array('entity:-tabname);   												to remove a tab
-	complete_head_from_modules($conf,$langs,$object,$head,$h,'categoriesadmin');
+	complete_head_from_modules($conf,$langs,null,$head,$h,'categoriesadmin');
 
-	complete_head_from_modules($conf,$langs,$object,$head,$h,'categoriesadmin','remove');
+	complete_head_from_modules($conf,$langs,null,$head,$h,'categoriesadmin','remove');
 
 	return $head;
 }
 
 
-?>
\ No newline at end of file
+?>

From 383032949938c66360e78d0d3c69d0f450bc4db7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 15:41:35 +0200
Subject: [PATCH 038/118] Qual: Removed missing variable

---
 htdocs/core/lib/company.lib.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/lib/company.lib.php b/htdocs/core/lib/company.lib.php
index 1c2af669bf9..952bd829f76 100644
--- a/htdocs/core/lib/company.lib.php
+++ b/htdocs/core/lib/company.lib.php
@@ -178,7 +178,7 @@ function societe_prepare_head2($object)
     if (empty($conf->global->SOCIETE_DISABLE_BANKACCOUNT))
     {
 	    $head[$h][0] = DOL_URL_ROOT .'/societe/rib.php?socid='.$object->id;
-	    $head[$h][1] = $langs->trans("BankAccount")." $account->number";
+	    $head[$h][1] = $langs->trans("BankAccount");
 	    $head[$h][2] = 'rib';
 	    $h++;
     }

From 229bc890d479ab5f1c8493ab697d33570bee3c09 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 15:43:17 +0200
Subject: [PATCH 039/118] Qual: Moved variable declaration for later usage

---
 htdocs/core/lib/company.lib.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/htdocs/core/lib/company.lib.php b/htdocs/core/lib/company.lib.php
index 952bd829f76..6aaa8a7e2f6 100644
--- a/htdocs/core/lib/company.lib.php
+++ b/htdocs/core/lib/company.lib.php
@@ -659,10 +659,10 @@ function show_contacts($conf,$langs,$db,$object,$backtopage='')
     $result = $db->query($sql);
     $num = $db->num_rows($result);
 
-    if ($num)
+	$var=true;
+	if ($num)
     {
         $i=0;
-        $var=true;
 
         while ($i < $num)
         {

From 652cb77e4091531a37f1955fc8b4861fdd76c5df Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 15:43:57 +0200
Subject: [PATCH 040/118] Qual: Removed missing variable from function call

---
 htdocs/core/lib/contract.lib.php | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/htdocs/core/lib/contract.lib.php b/htdocs/core/lib/contract.lib.php
index 3940fd00414..591d5746992 100644
--- a/htdocs/core/lib/contract.lib.php
+++ b/htdocs/core/lib/contract.lib.php
@@ -105,7 +105,7 @@ function contract_admin_prepare_head()
 	// Entries must be declared in modules descriptor with line
 	// $this->tabs = array('entity:+tabname:Title:@mymodule:/mymodule/mypage.php?id=__ID__');   to add new tab
 	// $this->tabs = array('entity:-tabname:Title:@mymodule:/mymodule/mypage.php?id=__ID__');   to remove a tab
-	complete_head_from_modules($conf,$langs,$object,$head,$h,'contract_admin');
+	complete_head_from_modules($conf,$langs,null,$head,$h,'contract_admin');
 
 	$head[$h][0] = DOL_URL_ROOT.'/contrat/admin/contract_extrafields.php';
 	$head[$h][1] = $langs->trans("ExtraFields");
@@ -114,9 +114,9 @@ function contract_admin_prepare_head()
 
 
 
-	complete_head_from_modules($conf,$langs,$object,$head,$h,'contract_admin','remove');
+	complete_head_from_modules($conf,$langs,null,$head,$h,'contract_admin','remove');
 
 		return $head;
 }
 
-?>
\ No newline at end of file
+?>

From 85d177064642598bc80c58c92677995752f361f3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 15:45:05 +0200
Subject: [PATCH 041/118] Qual: Removed missing variable from function call

---
 htdocs/core/lib/cron.lib.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/htdocs/core/lib/cron.lib.php b/htdocs/core/lib/cron.lib.php
index 630a2e2322c..34a21c83dab 100644
--- a/htdocs/core/lib/cron.lib.php
+++ b/htdocs/core/lib/cron.lib.php
@@ -39,9 +39,9 @@ function cronadmin_prepare_head()
     $head[$h][2] = 'setup';
     $h++;
 
-    complete_head_from_modules($conf, $langs, $object, $head, $h, 'cronadmin');
+    complete_head_from_modules($conf, $langs, null, $head, $h, 'cronadmin');
 
-    complete_head_from_modules($conf, $langs, $object, $head, $h, 'cronadmin', 'remove');
+    complete_head_from_modules($conf, $langs, null, $head, $h, 'cronadmin', 'remove');
 
 
     return $head;

From eca27d67116eaaf30f953429d4c9e7d9d7132c13 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 15:48:20 +0200
Subject: [PATCH 042/118] Qual: Wrong type in method documentation

---
 htdocs/core/lib/date.lib.php | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/htdocs/core/lib/date.lib.php b/htdocs/core/lib/date.lib.php
index 8a1c35ace9c..116eeb6739c 100644
--- a/htdocs/core/lib/date.lib.php
+++ b/htdocs/core/lib/date.lib.php
@@ -442,7 +442,7 @@ function dol_get_next_week($day, $week, $month, $year)
  * 	@param		mixed		$gm			False or 0 or 'server' = Return date to compare with server TZ, True or 1 to compare with GM date.
  *                          			Exemple: dol_get_first_day(1970,1,false) will return -3600 with TZ+1, after a dol_print_date will return 1970-01-01 00:00:00
  *                          			Exemple: dol_get_first_day(1970,1,true) will return 0 whatever is TZ, after a dol_print_date will return 1970-01-01 00:00:00
- *  @return		timestamp				Date for first day
+ *  @return		int						Date for first day
  */
 function dol_get_first_day($year,$month=1,$gm=false)
 {
@@ -455,7 +455,7 @@ function dol_get_first_day($year,$month=1,$gm=false)
  *	@param		int			$year		Year
  * 	@param		int			$month		Month
  * 	@param		boolean		$gm			False or 0 or 'server' = Return date to compare with server TZ, True or 1 to compare with GM date.
- *	@return		timestamp				Date for first day
+ *	@return		int						Date for first day
  */
 function dol_get_last_day($year,$month=12,$gm=false)
 {
@@ -551,8 +551,8 @@ function dol_get_first_day_week($day,$month,$year,$gm=false)
  *	Fonction retournant le nombre de jour feries, samedis et dimanches entre 2 dates entrees en timestamp. Dates must be UTC with hour, day, min to 0
  *	Called by function num_open_day
  *
- *	@param	    timestamp	$timestampStart     Timestamp de debut
- *	@param	    timestamp	$timestampEnd       Timestamp de fin
+ *	@param	    int			$timestampStart     Timestamp de debut
+ *	@param	    int			$timestampEnd       Timestamp de fin
  *  @param      string		$countrycode        Country code
  *	@return   	int								Nombre de jours feries
  */
@@ -685,8 +685,8 @@ function num_public_holiday($timestampStart, $timestampEnd, $countrycode='FR')
  *	Function to return number of days between two dates (date must be UTC date !)
  *  Example: 2012-01-01 2012-01-02 => 1 if lastday=0, 2 if lastday=1
  *
- *	@param	   timestamp	$timestampStart     Timestamp start UTC
- *	@param	   timestamp	$timestampEnd       Timestamp end UTC
+ *	@param	   int			$timestampStart     Timestamp start UTC
+ *	@param	   int			$timestampEnd       Timestamp end UTC
  *	@param     int			$lastday            Last day is included, 0: non, 1:oui
  *	@return    int								Number of days
  */
@@ -711,8 +711,8 @@ function num_between_day($timestampStart, $timestampEnd, $lastday=0)
 /**
  *	Function to return number of working days (and text of units) between two dates (working days)
  *
- *	@param	   	timestamp	$timestampStart     Timestamp for start date (date must be UTC to avoid calculation errors)
- *	@param	   	timestamp	$timestampEnd       Timestamp for end date (date must be UTC to avoid calculation errors)
+ *	@param	   	int			$timestampStart     Timestamp for start date (date must be UTC to avoid calculation errors)
+ *	@param	   	int			$timestampEnd       Timestamp for end date (date must be UTC to avoid calculation errors)
  *	@param     	int			$inhour             0: return number of days, 1: return number of hours
  *	@param		int			$lastday            We include last day, 0: no, 1:yes
  *  @param		int			$halfday			Tag to define half day when holiday start and end

From 82973eb0b763fe5479c53b1edd1003c5ac0a5414 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 15:49:13 +0200
Subject: [PATCH 043/118] Qual: Removed missing variable from function call

---
 htdocs/core/lib/fichinter.lib.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/htdocs/core/lib/fichinter.lib.php b/htdocs/core/lib/fichinter.lib.php
index 4b437d46e34..dc5668fd7d3 100644
--- a/htdocs/core/lib/fichinter.lib.php
+++ b/htdocs/core/lib/fichinter.lib.php
@@ -119,7 +119,7 @@ function fichinter_admin_prepare_head()
 	// Entries must be declared in modules descriptor with line
 	// $this->tabs = array('entity:+tabname:Title:@mymodule:/mymodule/mypage.php?id=__ID__');   to add new tab
 	// $this->tabs = array('entity:-tabname:Title:@mymodule:/mymodule/mypage.php?id=__ID__');   to remove a tab
-	complete_head_from_modules($conf,$langs,$object,$head,$h,'fichinter_admin');
+	complete_head_from_modules($conf,$langs,null,$head,$h,'fichinter_admin');
 
 	$head[$h][0] = DOL_URL_ROOT.'/fichinter/admin/fichinter_extrafields.php';
 	$head[$h][1] = $langs->trans("ExtraFields");
@@ -128,7 +128,7 @@ function fichinter_admin_prepare_head()
 
 
 
-	complete_head_from_modules($conf,$langs,$object,$head,$h,'fichinter_admin','remove');
+	complete_head_from_modules($conf,$langs,null,$head,$h,'fichinter_admin','remove');
 
 		return $head;
 }

From 234a2a0e276b0488f6290a5ac8001c530bad1c64 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 15:51:46 +0200
Subject: [PATCH 044/118] Qual: Removed call to inexistant object

---
 htdocs/core/lib/files.lib.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/htdocs/core/lib/files.lib.php b/htdocs/core/lib/files.lib.php
index 2b302af7e15..1606d1b8e38 100644
--- a/htdocs/core/lib/files.lib.php
+++ b/htdocs/core/lib/files.lib.php
@@ -879,7 +879,7 @@ function dol_delete_preview($object)
 	{
 		if ( ! dol_delete_file($file,1) )
 		{
-			$this->error=$langs->trans("ErrorFailedToOpenFile",$file);
+			$object->error=$langs->trans("ErrorFailedToOpenFile",$file);
 			return 0;
 		}
 	}
@@ -893,7 +893,7 @@ function dol_delete_preview($object)
 			{
 				if ( ! dol_delete_file($preview,1) )
 				{
-					$this->error=$langs->trans("ErrorFailedToOpenFile",$preview);
+					$object->error=$langs->trans("ErrorFailedToOpenFile",$preview);
 					return 0;
 				}
 			}

From 202344e8fb5db737358fd3906035b6b78e6efb58 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 15:53:45 +0200
Subject: [PATCH 045/118] Qual: Wrong type in method documentation

---
 htdocs/core/lib/files.lib.php | 30 +++++++++++++++---------------
 1 file changed, 15 insertions(+), 15 deletions(-)

diff --git a/htdocs/core/lib/files.lib.php b/htdocs/core/lib/files.lib.php
index 1606d1b8e38..8f56af5a10e 100644
--- a/htdocs/core/lib/files.lib.php
+++ b/htdocs/core/lib/files.lib.php
@@ -39,16 +39,16 @@ function dol_basename($pathfile)
  *  Scan a directory and return a list of files/directories.
  *  Content for string is UTF8 and dir separator is "/".
  *
- *  @param	string	$path        	Starting path from which to search
- *  @param	string	$types        	Can be "directories", "files", or "all"
- *  @param	int		$recursive		Determines whether subdirectories are searched
- *  @param	string	$filter        	Regex filter to restrict list. This regex value must be escaped for '/', since this char is used for preg_match function
- *  @param	string	$excludefilter  Array of Regex for exclude filter (example: array('\.meta$','^\.'))
- *  @param	string	$sortcriteria	Sort criteria ("","fullname","name","date","size")
- *  @param	string	$sortorder		Sort order (SORT_ASC, SORT_DESC)
- *	@param	int		$mode			0=Return array minimum keys loaded (faster), 1=Force all keys like date and size to be loaded (slower), 2=Force load of date only, 3=Force load of size only
- *  @param	int		$nohook			Disable all hooks
- *  @return	array					Array of array('name'=>'xxx','fullname'=>'/abc/xxx','date'=>'yyy','size'=>99,'type'=>'dir|file')
+ *  @param	string		$path        	Starting path from which to search
+ *  @param	string		$types        	Can be "directories", "files", or "all"
+ *  @param	int			$recursive		Determines whether subdirectories are searched
+ *  @param	string		$filter        	Regex filter to restrict list. This regex value must be escaped for '/', since this char is used for preg_match function
+ *  @param	string[]	$excludefilter  Array of Regex for exclude filter (example: array('\.meta$','^\.'))
+ *  @param	string		$sortcriteria	Sort criteria ("","fullname","name","date","size")
+ *  @param	string		$sortorder		Sort order (SORT_ASC, SORT_DESC)
+ *	@param	int			$mode			0=Return array minimum keys loaded (faster), 1=Force all keys like date and size to be loaded (slower), 2=Force load of date only, 3=Force load of size only
+ *  @param	int			$nohook			Disable all hooks
+ *  @return	array						Array of array('name'=>'xxx','fullname'=>'/abc/xxx','date'=>'yyy','size'=>99,'type'=>'dir|file')
  */
 function dol_dir_list($path, $types="all", $recursive=0, $filter="", $excludefilter="", $sortcriteria="name", $sortorder=SORT_ASC, $mode=0, $nohook=false)
 {
@@ -1279,11 +1279,11 @@ function dol_uncompress($inputfile,$outputdir)
 /**
  * Return file(s) into a directory (by default most recent)
  *
- * @param 	string	$dir			Directory to scan
- * @param	string	$regexfilter	Regex filter to restrict list. This regex value must be escaped for '/', since this char is used for preg_match function
- * @param	string	$excludefilter  Array of Regex for exclude filter (example: array('\.meta$','^\.')). This regex value must be escaped for '/', since this char is used for preg_match function
- * @param	int		$nohook			Disable all hooks
- * @return	string					Full path to most recent file
+ * @param 	string		$dir			Directory to scan
+ * @param	string		$regexfilter	Regex filter to restrict list. This regex value must be escaped for '/', since this char is used for preg_match function
+ * @param	string[]	$excludefilter  Array of Regex for exclude filter (example: array('\.meta$','^\.')). This regex value must be escaped for '/', since this char is used for preg_match function
+ * @param	int			$nohook			Disable all hooks
+ * @return	string						Full path to most recent file
  */
 function dol_most_recent_file($dir,$regexfilter='',$excludefilter=array('\.meta$','^\.'),$nohook=false)
 {

From 6fc9fbd7a604ae28d1ca9bc03254d037677aaa52 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 16:01:08 +0200
Subject: [PATCH 046/118] Qual: Derived missing variable from a known one

---
 htdocs/core/lib/files.lib.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/lib/files.lib.php b/htdocs/core/lib/files.lib.php
index 8f56af5a10e..faa4d7f1640 100644
--- a/htdocs/core/lib/files.lib.php
+++ b/htdocs/core/lib/files.lib.php
@@ -1755,7 +1755,7 @@ function dol_check_secure_access_document($modulepart,$original_file,$entity,$fu
 	{
 		$accessallowed=1;
 		$dir='files';
-		if ($type == 'application/x-bittorrent') $dir='torrents';
+		if (dol_mimetype($original_file) == 'application/x-bittorrent') $dir='torrents';
 		$original_file=$conf->bittorrent->dir_output.'/'.$dir.'/'.$original_file;
 	}
 

From 1c7011523d2c6996029afbc12b7235289db491fa Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 16:03:49 +0200
Subject: [PATCH 047/118] Qual: Missing global declaration

---
 htdocs/core/lib/functions.lib.php | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/htdocs/core/lib/functions.lib.php b/htdocs/core/lib/functions.lib.php
index 2db0ac1fe29..68d80576892 100644
--- a/htdocs/core/lib/functions.lib.php
+++ b/htdocs/core/lib/functions.lib.php
@@ -715,6 +715,8 @@ function dol_bc($var,$moreclass='')
  */
 function dol_format_address($object,$withcountry=0,$sep="\n")
 {
+	global $conf;
+
 	$ret='';
 	$countriesusingstate=array('AU','US','IN','GB','ES','UK','TR');
 

From 036cc7472f1371acf0d5b1c0fb1c4db378ca478b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 16:04:04 +0200
Subject: [PATCH 048/118] Qual: Removed missing variable from function call

---
 htdocs/core/lib/functions.lib.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/lib/functions.lib.php b/htdocs/core/lib/functions.lib.php
index 68d80576892..ff9710ae6fd 100644
--- a/htdocs/core/lib/functions.lib.php
+++ b/htdocs/core/lib/functions.lib.php
@@ -1430,7 +1430,7 @@ function dol_print_address($address, $htmlid, $mode, $id)
 	{
         if ($hookmanager) {
             $parameters = array('element' => $mode, 'id' => $id);
-            $reshook = $hookmanager->executeHooks('printAddress', $parameters, $address, $action);
+            $reshook = $hookmanager->executeHooks('printAddress', $parameters, $address);
             print $hookmanager->resPrint;
         }
         if (empty($reshook)) {

From 7a6b3a08275c8118a2dd17696fde3bf9a2a79bd2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 16:06:20 +0200
Subject: [PATCH 049/118] Qual: Missing variable declaration

---
 htdocs/core/lib/images.lib.php | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/htdocs/core/lib/images.lib.php b/htdocs/core/lib/images.lib.php
index 4e0a8e86789..e7e633231a3 100644
--- a/htdocs/core/lib/images.lib.php
+++ b/htdocs/core/lib/images.lib.php
@@ -658,7 +658,7 @@ function moneyMeter($actualValue=0, $pendingValue=0, $intentValue=0)
 
 	// actual
 	$sectionHeight = round(($actualValue / $maximumValue) * $height);
-	$totalHeight = $totalHeight + $sectionHeight;
+	$totalHeight = $sectionHeight;
 	if ( $sectionHeight > 0 )
 	{
 		$section = $formSection;
@@ -669,7 +669,7 @@ function moneyMeter($actualValue=0, $pendingValue=0, $intentValue=0)
 
 	// pending
 	$sectionHeight = round(($pendingValue / $maximumValue) * $height);
-	$totalHeight = $totalHeight + $sectionHeight;
+	$totalHeight += $sectionHeight;
 	if ( $sectionHeight > 0 )
 	{
 		$section = $formSection;
@@ -680,7 +680,7 @@ function moneyMeter($actualValue=0, $pendingValue=0, $intentValue=0)
 
 	// intent
 	$sectionHeight = round(($intentValue / $maximumValue) * $height);
-	$totalHeight = $totalHeight + $sectionHeight;
+	$totalHeight += $sectionHeight;
 	if ( $sectionHeight > 0 )
 	{
 		$section = $formSection;

From ca8cf9101c57705c6fe6f10117dadf319db6ac06 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 16:12:45 +0200
Subject: [PATCH 050/118] Qual: Removed missing variable from function call

---
 htdocs/core/lib/project.lib.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/htdocs/core/lib/project.lib.php b/htdocs/core/lib/project.lib.php
index 9316c2bcf68..007cb4a8184 100644
--- a/htdocs/core/lib/project.lib.php
+++ b/htdocs/core/lib/project.lib.php
@@ -179,7 +179,7 @@ function project_admin_prepare_head()
 	$head[$h][2] = 'project';
 	$h++;
 
-	complete_head_from_modules($conf,$langs,$object,$head,$h,'project_admin');
+	complete_head_from_modules($conf,$langs,null,$head,$h,'project_admin');
 
 	$head[$h][0] = DOL_URL_ROOT."/projet/admin/project_extrafields.php";
 	$head[$h][1] = $langs->trans("ExtraFieldsProject");
@@ -191,7 +191,7 @@ function project_admin_prepare_head()
 	$head[$h][2] = 'attributes_task';
 	$h++;
 
-	complete_head_from_modules($conf,$langs,$object,$head,$h,'project_admin','remove');
+	complete_head_from_modules($conf,$langs,null,$head,$h,'project_admin','remove');
 
 	return $head;
 }

From f1f550e55103f9516d6195e7d567361b72481f85 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 16:14:07 +0200
Subject: [PATCH 051/118] Qual: Removed missing variable from function call

---
 htdocs/core/lib/usergroups.lib.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/htdocs/core/lib/usergroups.lib.php b/htdocs/core/lib/usergroups.lib.php
index bf9c98dc903..d6097b6f5a1 100644
--- a/htdocs/core/lib/usergroups.lib.php
+++ b/htdocs/core/lib/usergroups.lib.php
@@ -179,9 +179,9 @@ function user_admin_prepare_head()
 	// Entries must be declared in modules descriptor with line
 	// $this->tabs = array('entity:+tabname:Title:@mymodule:/mymodule/mypage.php?id=__ID__');   to add new tab
 	// $this->tabs = array('entity:-tabname);   												to remove a tab
-	complete_head_from_modules($conf,$langs,$object,$head,$h,'useradmin');
+	complete_head_from_modules($conf,$langs,null,$head,$h,'useradmin');
 
-	complete_head_from_modules($conf,$langs,$object,$head,$h,'useradmin','remove');
+	complete_head_from_modules($conf,$langs,null,$head,$h,'useradmin','remove');
 
 	return $head;
 }

From d66ba0e026cda4a321f5a5da0c4f4615c884d137 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 16:16:29 +0200
Subject: [PATCH 052/118] Qual: Wrong type in method documentation

---
 htdocs/core/class/menubase.class.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/class/menubase.class.php b/htdocs/core/class/menubase.class.php
index 88908abfbe6..a754cc124e8 100644
--- a/htdocs/core/class/menubase.class.php
+++ b/htdocs/core/class/menubase.class.php
@@ -409,7 +409,7 @@ class Menubase
      * 	@param	int		$type_user		0=Menu for backoffice, 1=Menu for front office
      * 	@param	string	$menu_handler	Filter on name of menu_handler used (auguria, eldy...)
      * 	@param  array	&$tabMenu       Array with menu entries already loaded
-     * 	@return array    		       	Menu array for particular mainmenu value or full tabArray
+     * 	@return Menu    		       	Menu array for particular mainmenu value or full tabArray
      */
     function menuLeftCharger($newmenu, $mymainmenu, $myleftmenu, $type_user, $menu_handler, &$tabMenu)
     {

From 1c3c20105e50d6bd449342dcb7eaec29458588fb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 16:21:46 +0200
Subject: [PATCH 053/118] Qual: Wrong type in method documentation

---
 htdocs/core/menus/standard/auguria.lib.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/menus/standard/auguria.lib.php b/htdocs/core/menus/standard/auguria.lib.php
index a820243ba66..d633e0b68d1 100644
--- a/htdocs/core/menus/standard/auguria.lib.php
+++ b/htdocs/core/menus/standard/auguria.lib.php
@@ -206,7 +206,7 @@ function print_end_menu_array_auguria()
  * @param	int			$noout				Disable output (Initialise &$menu only).
  * @param	string		$forcemainmenu		'x'=Force mainmenu to mainmenu='x'
  * @param	string		$forceleftmenu		'all'=Force leftmenu to '' (= all)
- * @return	void
+ * @return	int
  */
 function print_left_auguria_menu($db,$menu_array_before,$menu_array_after,&$tabMenu,&$menu,$noout=0,$forcemainmenu='',$forceleftmenu='')
 {

From b68fb41d28a816909129a8630b0df96bdcb6b100 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 16:23:55 +0200
Subject: [PATCH 054/118] Qual: Wrong type in method documentation

---
 htdocs/core/menus/standard/eldy.lib.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/menus/standard/eldy.lib.php b/htdocs/core/menus/standard/eldy.lib.php
index e400c72c027..5d81f9d1846 100644
--- a/htdocs/core/menus/standard/eldy.lib.php
+++ b/htdocs/core/menus/standard/eldy.lib.php
@@ -431,7 +431,7 @@ function print_end_menu_array()
  * @param	int			$noout				Disable output (Initialise &$menu only).
  * @param	string		$forcemainmenu		'x'=Force mainmenu to mainmenu='x'
  * @param	string		$forceleftmenu		'all'=Force leftmenu to '' (= all)
- * @return	void
+ * @return	int
  */
 function print_left_eldy_menu($db,$menu_array_before,$menu_array_after,&$tabMenu,&$menu,$noout=0,$forcemainmenu='',$forceleftmenu='')
 {

From d717133d62aef2e2f7e611b9f802ce6ef5a0ce24 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 16:27:25 +0200
Subject: [PATCH 055/118] Qual: Removed dead code

---
 htdocs/core/menus/standard/auguria_menu.php | 14 +++++---------
 htdocs/core/menus/standard/eldy_menu.php    | 17 +++++++----------
 2 files changed, 12 insertions(+), 19 deletions(-)

diff --git a/htdocs/core/menus/standard/auguria_menu.php b/htdocs/core/menus/standard/auguria_menu.php
index ac84a0713f3..f9f08cbf91e 100644
--- a/htdocs/core/menus/standard/auguria_menu.php
+++ b/htdocs/core/menus/standard/auguria_menu.php
@@ -158,7 +158,7 @@ class MenuManager
      *  Show menu
      *
      *	@param	string	$mode		'top', 'left', 'jmobile'
-     *  @return	int     			Number of menu entries shown
+     *  @return	void
 	 */
 	function showmenu($mode)
 	{
@@ -172,16 +172,14 @@ class MenuManager
 	        $conf->global->MAIN_SEARCHFORM_CONTACT=0;
         }
 
-        $res='ErrorBadParameterForMode';
-
 		require_once DOL_DOCUMENT_ROOT.'/core/class/menu.class.php';
         $this->menu=new Menu();
 
-        if ($mode == 'top')  $res=print_auguria_menu($this->db,$this->atarget,$this->type_user,$this->tabMenu,$this->menu,0);
-        if ($mode == 'left') $res=print_left_auguria_menu($this->db,$this->menu_array,$this->menu_array_after,$this->tabMenu,$this->menu,0);
+        if ($mode == 'top')  print_auguria_menu($this->db,$this->atarget,$this->type_user,$this->tabMenu,$this->menu,0);
+        if ($mode == 'left') print_left_auguria_menu($this->db,$this->menu_array,$this->menu_array_after,$this->tabMenu,$this->menu,0);
         if ($mode == 'jmobile')
         {
-        	$res=print_auguria_menu($this->db,$this->atarget,$this->type_user,$this->tabMenu,$this->menu,1);
+        	print_auguria_menu($this->db,$this->atarget,$this->type_user,$this->tabMenu,$this->menu,1);
 
         	print '<!-- Generate menu list from menu handler '.$this->name.' -->'."\n";
         	foreach($this->menu->liste as $key => $val)		// $val['url','titre','level','enabled'=0|1|2,'target','mainmenu','leftmenu'
@@ -199,7 +197,7 @@ class MenuManager
         			$tmpmainmenu=$val['mainmenu'];
         			$tmpleftmenu='all';
         			$submenu=new Menu();
-        			$res=print_left_auguria_menu($this->db,$this->menu_array,$this->menu_array_after,$this->tabMenu,$submenu,1,$tmpmainmenu,$tmpleftmenu);
+        			print_left_auguria_menu($this->db,$this->menu_array,$this->menu_array_after,$this->tabMenu,$submenu,1,$tmpmainmenu,$tmpleftmenu);
         			$nexturl=dol_buildpath($submenu->liste[0]['url'],1);
 
         			$canonrelurl=preg_replace('/\?.*$/','',$relurl);
@@ -248,8 +246,6 @@ class MenuManager
         }
 
         unset($this->menu);
-
-        return $res;
     }
 }
 
diff --git a/htdocs/core/menus/standard/eldy_menu.php b/htdocs/core/menus/standard/eldy_menu.php
index 3c690a37719..5c6aed31880 100644
--- a/htdocs/core/menus/standard/eldy_menu.php
+++ b/htdocs/core/menus/standard/eldy_menu.php
@@ -112,7 +112,7 @@ class MenuManager
      *  Show menu
      *
      *	@param	string	$mode			'top', 'left', 'jmobile'
-     *  @return int     				Number of menu entries shown
+     *  @return void
      */
     function showmenu($mode)
     {
@@ -126,26 +126,24 @@ class MenuManager
         	$conf->global->MAIN_SEARCHFORM_CONTACT=0;
         }
 
-        $res='ErrorBadParameterForMode';
-
 		require_once DOL_DOCUMENT_ROOT.'/core/class/menu.class.php';
         $this->menu=new Menu();
 
         if (empty($conf->global->MAIN_MENU_INVERT))
         {
-        	if ($mode == 'top')  $res=print_eldy_menu($this->db,$this->atarget,$this->type_user,$this->tabMenu,$this->menu,0);
-        	if ($mode == 'left') $res=print_left_eldy_menu($this->db,$this->menu_array,$this->menu_array_after,$this->tabMenu,$this->menu,0);
+        	if ($mode == 'top')  print_eldy_menu($this->db,$this->atarget,$this->type_user,$this->tabMenu,$this->menu,0);
+        	if ($mode == 'left') print_left_eldy_menu($this->db,$this->menu_array,$this->menu_array_after,$this->tabMenu,$this->menu,0);
         }
         else
 		{
         	$conf->global->MAIN_SHOW_LOGO=0;
-        	if ($mode == 'top')  $res=print_left_eldy_menu($this->db,$this->menu_array,$this->menu_array_after,$this->tabMenu,$this->menu,0);
-        	if ($mode == 'left') $res=print_eldy_menu($this->db,$this->atarget,$this->type_user,$this->tabMenu,$this->menu,0);
+        	if ($mode == 'top')  print_left_eldy_menu($this->db,$this->menu_array,$this->menu_array_after,$this->tabMenu,$this->menu,0);
+        	if ($mode == 'left') print_eldy_menu($this->db,$this->atarget,$this->type_user,$this->tabMenu,$this->menu,0);
 		}
 
         if ($mode == 'jmobile')
         {
-        	$res=print_eldy_menu($this->db,$this->atarget,$this->type_user,$this->tabMenu,$this->menu,1);
+            print_eldy_menu($this->db,$this->atarget,$this->type_user,$this->tabMenu,$this->menu,1);
 
         	print '<!-- Generate menu list from menu handler '.$this->name.' -->'."\n";
         	foreach($this->menu->liste as $key => $val)		// $val['url','titre','level','enabled'=0|1|2,'target','mainmenu','leftmenu'
@@ -163,7 +161,7 @@ class MenuManager
         			$tmpmainmenu=$val['mainmenu'];
         			$tmpleftmenu='all';
         			$submenu=new Menu();
-	        		$res=print_left_eldy_menu($this->db,$this->menu_array,$this->menu_array_after,$this->tabMenu,$submenu,1,$tmpmainmenu,$tmpleftmenu);
+	        		print_left_eldy_menu($this->db,$this->menu_array,$this->menu_array_after,$this->tabMenu,$submenu,1,$tmpmainmenu,$tmpleftmenu);
         			$nexturl=dol_buildpath($submenu->liste[0]['url'],1);
 
         			$canonrelurl=preg_replace('/\?.*$/','',$relurl);
@@ -221,7 +219,6 @@ class MenuManager
         unset($this->menu);
 
         //print 'xx'.$mode;
-        return $res;
     }
 
 }

From 96c0c434049825156280b1220415802657d2f320 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 16:47:32 +0200
Subject: [PATCH 056/118] Qual: Missing global declaration

---
 htdocs/core/menus/standard/empty.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/menus/standard/empty.php b/htdocs/core/menus/standard/empty.php
index 30bd17906ce..cc1fb691c21 100644
--- a/htdocs/core/menus/standard/empty.php
+++ b/htdocs/core/menus/standard/empty.php
@@ -300,7 +300,7 @@ function print_start_menu_entry_empty($idsel,$classname,$showmode)
  */
 function print_text_menu_entry_empty($text, $showmode, $url, $id, $idsel, $classname, $atarget)
 {
-	global $conf;
+	global $conf,$langs;
 
 	if ($showmode == 1)
 	{

From fe05d3f2c4a8efd1597bea286910c8fc011a4c1a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 16:48:02 +0200
Subject: [PATCH 057/118] Qual: Missing global declaration

---
 htdocs/core/modules/action/rapport.pdf.php | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/htdocs/core/modules/action/rapport.pdf.php b/htdocs/core/modules/action/rapport.pdf.php
index d595dfe5579..fcbff330822 100644
--- a/htdocs/core/modules/action/rapport.pdf.php
+++ b/htdocs/core/modules/action/rapport.pdf.php
@@ -165,6 +165,8 @@ class CommActionRapport
 	 */
 	function _pages(&$pdf, $outputlangs)
 	{
+		global $conf;
+
 		$height=3;		// height for text separation
 		$pagenb=1;
 

From 6788c5b7f8569dc079811adfbc14da8a9918f696 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 16:53:02 +0200
Subject: [PATCH 058/118] Qual: Wrong type in method documentation

---
 htdocs/core/lib/pdf.lib.php | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/htdocs/core/lib/pdf.lib.php b/htdocs/core/lib/pdf.lib.php
index 6fbcceddf24..f79eec5e403 100644
--- a/htdocs/core/lib/pdf.lib.php
+++ b/htdocs/core/lib/pdf.lib.php
@@ -490,7 +490,7 @@ function pdf_watermark(&$pdf, $outputlangs, $h, $w, $unit, $text)
  *  @param  Account		$account         		Bank account object
  *  @param  int			$onlynumber      		Output only number
  *  @param	int			$default_font_size		Default font size
- *  @return	void
+ *  @return	float                               The Y PDF position
  */
 function pdf_bank(&$pdf,$outputlangs,$curx,$cury,$account,$onlynumber=0,$default_font_size=10)
 {
@@ -863,7 +863,7 @@ function pdf_pagefoot(&$pdf,$outputlangs,$paramfreetext,$fromcompany,$marge_bass
  *	@param	float		$h					Cell minimum height. The cell extends automatically if needed.
  *	@param	int			$align				Align
  *	@param	string		$default_font_size	Font size
- *	@return	void
+ *	@return	float                           The Y PDF position
  */
 function pdf_writeLinkedObjects(&$pdf,$object,$outputlangs,$posx,$posy,$w,$h,$align,$default_font_size)
 {
@@ -1186,7 +1186,7 @@ function pdf_getlineref_supplier($object,$i,$outputlangs,$hidedetails=0)
  *	@param	int			$i					Current line number
  *  @param  Translate	$outputlangs		Object langs for output
  *  @param	int			$hidedetails		Hide details (0=no, 1=yes, 2=just special lines)
- * 	@return	void
+ * 	@return	string
  */
 function pdf_getlinevatrate($object,$i,$outputlangs,$hidedetails=0)
 {
@@ -1213,7 +1213,7 @@ function pdf_getlinevatrate($object,$i,$outputlangs,$hidedetails=0)
  *	@param	int			$i					Current line number
  *  @param  Translate	$outputlangs		Object langs for output
  *  @param	int			$hidedetails		Hide details (0=no, 1=yes, 2=just special lines)
- * 	@return	void
+ * 	@return	string
  */
 function pdf_getlineupexcltax($object,$i,$outputlangs,$hidedetails=0)
 {
@@ -1271,7 +1271,7 @@ function pdf_getlineupwithtax($object,$i,$outputlangs,$hidedetails=0)
  *	@param	int			$i					Current line number
  *  @param  Translate	$outputlangs		Object langs for output
  *  @param	int			$hidedetails		Hide details (0=no, 1=yes, 2=just special lines)
- *  @return	void
+ *  @return	string
  */
 function pdf_getlineqty($object,$i,$outputlangs,$hidedetails=0)
 {
@@ -1301,7 +1301,7 @@ function pdf_getlineqty($object,$i,$outputlangs,$hidedetails=0)
  *	@param	int			$i					Current line number
  *  @param  Translate	$outputlangs		Object langs for output
  *  @param	int			$hidedetails		Hide details (0=no, 1=yes, 2=just special lines)
- * 	@return	void
+ * 	@return	string
  */
 function pdf_getlineqty_asked($object,$i,$outputlangs,$hidedetails=0)
 {
@@ -1331,7 +1331,7 @@ function pdf_getlineqty_asked($object,$i,$outputlangs,$hidedetails=0)
  *	@param	int			$i					Current line number
  *  @param  Translate	$outputlangs		Object langs for output
  *  @param	int			$hidedetails		Hide details (0=no, 1=yes, 2=just special lines)
- * 	@return	void
+ * 	@return	string
  */
 function pdf_getlineqty_shipped($object,$i,$outputlangs,$hidedetails=0)
 {
@@ -1391,7 +1391,7 @@ function pdf_getlineqty_keeptoship($object,$i,$outputlangs,$hidedetails=0)
  *	@param	int			$i					Current line number
  *  @param  Translate	$outputlangs		Object langs for output
  *  @param	int			$hidedetails		Hide details (0=no, 1=yes, 2=just special lines)
- * 	@return	void
+ * 	@return	string
  */
 function pdf_getlineremisepercent($object,$i,$outputlangs,$hidedetails=0)
 {

From 9e839f43e650bcc5b231d67f63e46dfebf699a18 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 16:54:26 +0200
Subject: [PATCH 059/118] Qual: Wrong type in method documentation

---
 htdocs/core/modules/barcode/mod_barcode_product_standard.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/htdocs/core/modules/barcode/mod_barcode_product_standard.php b/htdocs/core/modules/barcode/mod_barcode_product_standard.php
index 2d298712162..53a6d3caf35 100644
--- a/htdocs/core/modules/barcode/mod_barcode_product_standard.php
+++ b/htdocs/core/modules/barcode/mod_barcode_product_standard.php
@@ -62,7 +62,7 @@ class mod_barcode_product_standard extends ModeleNumRefBarCode
 
 	/**		Return description of module
 	 *
-	 * 		@param	string 		$langs		Object langs
+	 * 		@param	Translate 		$langs		Object langs
 	 * 		@return string      			Description of module
 	 */
 	function info($langs)
@@ -104,7 +104,7 @@ class mod_barcode_product_standard extends ModeleNumRefBarCode
 	 * Return an example of result returned by getNextValue
 	 *
 	 * @param	Translate	$langs			Object langs
-	 * @param	product		$objproduct		Object product
+	 * @param	Product		$objproduct		Object product
 	 * @return	string						Return string example
 	 */
 	function getExample($langs,$objproduct=0)

From f4f4eca8412830ec076899f5d7c2a6d4722305ef Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 16:58:49 +0200
Subject: [PATCH 060/118] Qual: Wrong variable name

---
 htdocs/core/modules/commande/modules_commande.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/modules/commande/modules_commande.php b/htdocs/core/modules/commande/modules_commande.php
index aa52d55bad3..5ddcc38e8d9 100644
--- a/htdocs/core/modules/commande/modules_commande.php
+++ b/htdocs/core/modules/commande/modules_commande.php
@@ -237,7 +237,7 @@ function commande_pdf_create($db, $object, $modele, $outputlangs, $hidedetails=0
 			include_once DOL_DOCUMENT_ROOT . '/core/class/interfaces.class.php';
 			$interface=new Interfaces($db);
 			$result=$interface->run_triggers('ORDER_BUILDDOC',$object,$user,$langs,$conf);
-			if ($result < 0) { $error++; $this->errors=$interface->errors; }
+			if ($result < 0) { $error++; $obj->errors=$interface->errors; }
 			// Fin appel triggers
 
 			return 1;

From 119e96a8b13b097df7672989233f0de61be3326c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 16:59:35 +0200
Subject: [PATCH 061/118] Qual: Missing global declaration

---
 htdocs/core/modules/commande/mod_commande_marbre.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/modules/commande/mod_commande_marbre.php b/htdocs/core/modules/commande/mod_commande_marbre.php
index b26f265cb25..c4117b5bfec 100644
--- a/htdocs/core/modules/commande/mod_commande_marbre.php
+++ b/htdocs/core/modules/commande/mod_commande_marbre.php
@@ -66,7 +66,7 @@ class mod_commande_marbre extends ModeleNumRefCommandes
 	 */
 	function canBeActivated()
 	{
-		global $conf,$langs;
+		global $conf,$langs,$db;
 
 		$coyymm=''; $max='';
 

From 2970ead6f36b10d357543e5bb22936f96df55048 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:03:07 +0200
Subject: [PATCH 062/118] Qual: Wrong type in method documentation

---
 .../modules/contract/doc/pdf_strato.modules.php    | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/htdocs/core/modules/contract/doc/pdf_strato.modules.php b/htdocs/core/modules/contract/doc/pdf_strato.modules.php
index 353b77ffaf7..bb8342de557 100644
--- a/htdocs/core/modules/contract/doc/pdf_strato.modules.php
+++ b/htdocs/core/modules/contract/doc/pdf_strato.modules.php
@@ -96,13 +96,13 @@ class pdf_strato extends ModelePDFContract
 	/**
      *  Function to build pdf onto disk
      *
-     *  @param		int		$object				Id of object to generate
-     *  @param		object	$outputlangs		Lang output object
-     *  @param		string	$srctemplatepath	Full path of source filename for generator using a template file
-     *  @param		int		$hidedetails		Do not show line details
-     *  @param		int		$hidedesc			Do not show desc
-     *  @param		int		$hideref			Do not show ref
-     *  @return     int             			1=OK, 0=KO
+     *  @param		CommonObject	$object				Id of object to generate
+     *  @param		object			$outputlangs		Lang output object
+     *  @param		string			$srctemplatepath	Full path of source filename for generator using a template file
+     *  @param		int				$hidedetails		Do not show line details
+     *  @param		int				$hidedesc			Do not show desc
+     *  @param		int				$hideref			Do not show ref
+     *  @return		int									1=OK, 0=KO
 	 */
 	function write_file($object,$outputlangs,$srctemplatepath='',$hidedetails=0,$hidedesc=0,$hideref=0)
 	{

From b3630cc5888aad69284445c1c050e25c6fab2abb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:05:23 +0200
Subject: [PATCH 063/118] Qual: Missing variable declaration

---
 htdocs/core/modules/contract/doc/pdf_strato.modules.php | 1 +
 1 file changed, 1 insertion(+)

diff --git a/htdocs/core/modules/contract/doc/pdf_strato.modules.php b/htdocs/core/modules/contract/doc/pdf_strato.modules.php
index bb8342de557..280e02120c7 100644
--- a/htdocs/core/modules/contract/doc/pdf_strato.modules.php
+++ b/htdocs/core/modules/contract/doc/pdf_strato.modules.php
@@ -253,6 +253,7 @@ class pdf_strato extends ModelePDFContract
 					$valide = $objectligne->id ? $objectligne->fetch($objectligne->id) : 0;
 					if ($valide > 0 || $object->specimen)
 					{
+						$curX = $this->posxdesc-1;
 						$curY = $nexY;
 						$pdf->SetFont('','', $default_font_size - 1);   // Into loop to work with multipage
 						$pdf->SetTextColor(0,0,0);

From d1f59b73d7d9403ef4949c492c5b20115e357f7e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:05:54 +0200
Subject: [PATCH 064/118] Qual: Wrong variable name

---
 htdocs/core/modules/contract/modules_contract.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/modules/contract/modules_contract.php b/htdocs/core/modules/contract/modules_contract.php
index 35a03dd8337..fb03a8a8115 100644
--- a/htdocs/core/modules/contract/modules_contract.php
+++ b/htdocs/core/modules/contract/modules_contract.php
@@ -231,7 +231,7 @@ function contract_pdf_create($db, $object, $modele, $outputlangs, $hidedetails=0
 			include_once DOL_DOCUMENT_ROOT . '/core/class/interfaces.class.php';
 			$interface=new Interfaces($db);
 			$result=$interface->run_triggers('CONTRACT_BUILDDOC',$object,$user,$langs,$conf);
-			if ($result < 0) { $error++; $this->errors=$interface->errors; }
+			if ($result < 0) { $error++; $obj->errors=$interface->errors; }
 			// Fin appel triggers
 
 			return 1;

From 11125f98be9dc5cd71a24908a6fad07c9ab6b2ee Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:06:21 +0200
Subject: [PATCH 065/118] Qual: Missing global declaration

---
 htdocs/core/modules/contract/mod_contract_serpis.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/modules/contract/mod_contract_serpis.php b/htdocs/core/modules/contract/mod_contract_serpis.php
index d819fb06af8..357483e7ae9 100644
--- a/htdocs/core/modules/contract/mod_contract_serpis.php
+++ b/htdocs/core/modules/contract/mod_contract_serpis.php
@@ -64,7 +64,7 @@ class mod_contract_serpis extends ModelNumRefContracts
 	 */
 	function canBeActivated()
 	{
-		global $conf,$langs;
+		global $conf,$langs,$db;
 
 		$coyymm=''; $max='';
 

From 3a7773081ee6bc5a39dcd41a7597f45b27c2e00e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:08:58 +0200
Subject: [PATCH 066/118] Qual: Missing method arguments

---
 htdocs/core/modules/dons/modules_don.php | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/htdocs/core/modules/dons/modules_don.php b/htdocs/core/modules/dons/modules_don.php
index ff05e6d8262..b825bacbb34 100644
--- a/htdocs/core/modules/dons/modules_don.php
+++ b/htdocs/core/modules/dons/modules_don.php
@@ -147,9 +147,12 @@ abstract class ModeleNumRefDons
  *	@param	string		$message		Message
  *	@param	string		$modele			Force le modele a utiliser ('' par defaut)
  *	@param	Translate	$outputlangs	Object langs
+ *  @param  int			$hidedetails    Hide details of lines
+ *  @param  int			$hidedesc       Hide description
+ *  @param  int			$hideref        Hide ref
  *	@return int         				0 if KO, 1 if OK
  */
-function don_create($db, $id, $message, $modele, $outputlangs)
+function don_create($db, $id, $message, $modele, $outputlangs, $hidedetails=0, $hidedesc=0, $hideref=0)
 {
     global $conf, $langs;
     $langs->load("bills");

From 32ced9a50271131c7ac25e5fe9e7b636c822adc5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:09:55 +0200
Subject: [PATCH 067/118] Qual: Removed missing variable

---
 htdocs/core/modules/dons/modules_don.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/modules/dons/modules_don.php b/htdocs/core/modules/dons/modules_don.php
index b825bacbb34..1527b134a8d 100644
--- a/htdocs/core/modules/dons/modules_don.php
+++ b/htdocs/core/modules/dons/modules_don.php
@@ -244,7 +244,7 @@ function don_create($db, $id, $message, $modele, $outputlangs, $hidedetails=0, $
     }
     else
     {
-        print $langs->trans("Error")." ".$langs->trans("ErrorFileDoesNotExists",$dir.$file);
+        print $langs->trans("Error")." ".$langs->trans("ErrorFileDoesNotExists",$file);
         return 0;
     }
 }

From 8b5b7203d5e4033f27de1775c438268baa773b49 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:10:57 +0200
Subject: [PATCH 068/118] Qual: Missing global declaration

---
 htdocs/core/modules/expedition/doc/pdf_merou.modules.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/modules/expedition/doc/pdf_merou.modules.php b/htdocs/core/modules/expedition/doc/pdf_merou.modules.php
index dafff8b81ea..63ab48d8138 100644
--- a/htdocs/core/modules/expedition/doc/pdf_merou.modules.php
+++ b/htdocs/core/modules/expedition/doc/pdf_merou.modules.php
@@ -431,7 +431,7 @@ class pdf_merou extends ModelePdfExpedition
 	 */
 	function _pagehead(&$pdf, $object, $showaddress, $outputlangs)
 	{
-		global $conf, $langs;
+		global $conf, $langs,$hookmanager;
 
 		$default_font_size = pdf_getPDFFontSize($outputlangs);
 

From 0cb58e0b52aca46e705fa1cc8537047fd8e1ccf3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:12:23 +0200
Subject: [PATCH 069/118] Qual: Wrong variable name

---
 htdocs/core/modules/expedition/modules_expedition.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/htdocs/core/modules/expedition/modules_expedition.php b/htdocs/core/modules/expedition/modules_expedition.php
index d205f662974..9a56b85582d 100644
--- a/htdocs/core/modules/expedition/modules_expedition.php
+++ b/htdocs/core/modules/expedition/modules_expedition.php
@@ -227,7 +227,7 @@ function expedition_pdf_create($db, $object, $modele, $outputlangs)
 			$interface=new Interfaces($db);
 			$result=$interface->run_triggers('SHIPPING_BUILDDOC',$object,$user,$langs,$conf);
 			if ($result < 0) {
-				$error++; $this->errors=$interface->errors;
+				$error++; $obj->errors=$interface->errors;
 			}
 			// End calls triggers
 
@@ -254,4 +254,4 @@ function expedition_pdf_create($db, $object, $modele, $outputlangs)
 		return 0;
     }
 }
-?>
\ No newline at end of file
+?>

From 12ba75143247a26fc23b69a176fd5eb696f19f21 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:12:44 +0200
Subject: [PATCH 070/118] Qual: Missing global declaration

---
 htdocs/core/modules/expedition/mod_expedition_safor.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/modules/expedition/mod_expedition_safor.php b/htdocs/core/modules/expedition/mod_expedition_safor.php
index 13fe06aded1..0b55ba39418 100644
--- a/htdocs/core/modules/expedition/mod_expedition_safor.php
+++ b/htdocs/core/modules/expedition/mod_expedition_safor.php
@@ -64,7 +64,7 @@ class mod_expedition_safor extends ModelNumRefExpedition
 	 */
 	function canBeActivated()
 	{
-		global $conf,$langs;
+		global $conf,$langs,$db;
 
 		$coyymm=''; $max='';
 

From 0a08f3c6e30ceb99c9a481fc94c55de5c569f3d4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:13:30 +0200
Subject: [PATCH 071/118] Qual: Missing global declaration

---
 htdocs/core/modules/export/export_excel.modules.php | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/htdocs/core/modules/export/export_excel.modules.php b/htdocs/core/modules/export/export_excel.modules.php
index 5a3f333577c..35f701d3860 100644
--- a/htdocs/core/modules/export/export_excel.modules.php
+++ b/htdocs/core/modules/export/export_excel.modules.php
@@ -228,6 +228,8 @@ class ExportExcel extends ModeleExports
 	 */
 	function write_title($array_export_fields_label,$array_selected_sorted,$outputlangs,$array_types)
 	{
+		global $conf;
+
 		// Create a format for the column headings
 		if (! empty($conf->global->MAIN_USE_PHP_WRITEEXCEL))
 		{
@@ -281,6 +283,8 @@ class ExportExcel extends ModeleExports
 	 */
 	function write_record($array_selected_sorted,$objp,$outputlangs,$array_types)
 	{
+		global $conf;
+
 		// Create a format for the column headings
 		if (! empty($conf->global->MAIN_USE_PHP_WRITEEXCEL))
 		{
@@ -398,6 +402,8 @@ class ExportExcel extends ModeleExports
      */
 	function close_file()
 	{
+		global $conf;
+
 		if (! empty($conf->global->MAIN_USE_PHP_WRITEEXCEL))
     	{
 	        $this->workbook->close();

From 1757c9d45e566eb85b595843bd65b2adfa7bc398 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:14:11 +0200
Subject: [PATCH 072/118] Qual: Missing global declaration

---
 htdocs/core/modules/export/export_excel2007.modules.php | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/htdocs/core/modules/export/export_excel2007.modules.php b/htdocs/core/modules/export/export_excel2007.modules.php
index 6d9a585e6be..aed29b28c28 100644
--- a/htdocs/core/modules/export/export_excel2007.modules.php
+++ b/htdocs/core/modules/export/export_excel2007.modules.php
@@ -80,6 +80,8 @@ class ExportExcel2007 extends ExportExcel
      */
 	function close_file()
 	{
+		global $conf;
+
 		if (! empty($conf->global->MAIN_USE_PHP_WRITEEXCEL))
     	{
 	        $this->workbook->close();

From 9960e5aa8f63a175faa18793cf4226c4da8e41a2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:15:07 +0200
Subject: [PATCH 073/118] Qual: Removed unused variable

---
 htdocs/core/class/commonobject.class.php                        | 2 +-
 .../modules/facture/doc/doc_generic_invoice_odt.modules.php     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/htdocs/core/class/commonobject.class.php b/htdocs/core/class/commonobject.class.php
index 838894fc851..004153e2fdc 100644
--- a/htdocs/core/class/commonobject.class.php
+++ b/htdocs/core/class/commonobject.class.php
@@ -1721,7 +1721,7 @@ abstract class CommonObject
      *	@param  string	$clause			OR, AND clause
      *	@return	void
      */
-    function fetchObjectLinked($sourceid='',$sourcetype='',$targetid='',$targettype='',$clause='OR')
+	function fetchObjectLinked($sourceid='',$sourcetype='',$targetid='',$targettype='',$clause='OR')
     {
         global $conf;
 
diff --git a/htdocs/core/modules/facture/doc/doc_generic_invoice_odt.modules.php b/htdocs/core/modules/facture/doc/doc_generic_invoice_odt.modules.php
index 559cc794ac7..3651d106951 100644
--- a/htdocs/core/modules/facture/doc/doc_generic_invoice_odt.modules.php
+++ b/htdocs/core/modules/facture/doc/doc_generic_invoice_odt.modules.php
@@ -391,7 +391,7 @@ class doc_generic_invoice_odt extends ModelePDFFactures
 				}
 
 				// Fetch info for linked propal
-				$linked_propal = $object->fetchObjectLinked('','','','');
+				$object->fetchObjectLinked('','','','');
 				//print_r($object->linkedObjects['propal']); exit;
 
 				$propal_object = $object->linkedObjects['propal'][0];

From 71cd774d043aa995cc31849cf1863a7e7d956711 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:16:22 +0200
Subject: [PATCH 074/118] Qual: Missing global declaration

---
 htdocs/core/modules/facture/mod_facture_mars.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/modules/facture/mod_facture_mars.php b/htdocs/core/modules/facture/mod_facture_mars.php
index 852d499e66e..21dc49c32f3 100644
--- a/htdocs/core/modules/facture/mod_facture_mars.php
+++ b/htdocs/core/modules/facture/mod_facture_mars.php
@@ -67,7 +67,7 @@ class mod_facture_mars extends ModeleNumRefFactures
 	 */
 	function canBeActivated()
 	{
-		global $langs,$conf;
+		global $langs,$conf,$db;
 
 		$langs->load("bills");
 

From 592b738f96ebb4687d504eca7fb105c34179616a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:16:39 +0200
Subject: [PATCH 075/118] Qual: Missing global declaration

---
 htdocs/core/modules/facture/mod_facture_terre.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/modules/facture/mod_facture_terre.php b/htdocs/core/modules/facture/mod_facture_terre.php
index 799dc1da204..60be7a1e311 100644
--- a/htdocs/core/modules/facture/mod_facture_terre.php
+++ b/htdocs/core/modules/facture/mod_facture_terre.php
@@ -65,7 +65,7 @@ class mod_facture_terre extends ModeleNumRefFactures
 	 */
 	function canBeActivated()
 	{
-		global $langs,$conf;
+		global $langs,$conf,$db;
 
 		$langs->load("bills");
 

From 9c5db27a700e3a1424aaf011d39b79108797af36 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:17:41 +0200
Subject: [PATCH 076/118] Qual: Wrong type in method documentation

---
 .../modules/fichinter/doc/pdf_soleil.modules.php   | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/htdocs/core/modules/fichinter/doc/pdf_soleil.modules.php b/htdocs/core/modules/fichinter/doc/pdf_soleil.modules.php
index 3aaae21aa11..8b7505b54c1 100644
--- a/htdocs/core/modules/fichinter/doc/pdf_soleil.modules.php
+++ b/htdocs/core/modules/fichinter/doc/pdf_soleil.modules.php
@@ -96,13 +96,13 @@ class pdf_soleil extends ModelePDFFicheinter
 	/**
 	 *  Function to build pdf onto disk
 	 *
-	 *  @param		int		$object				Id of object to generate
-	 *  @param		object	$outputlangs		Lang output object
-	 *  @param		string	$srctemplatepath	Full path of source filename for generator using a template file
-	 *  @param		int		$hidedetails		Do not show line details
-	 *  @param		int		$hidedesc			Do not show desc
-	 *  @param		int		$hideref			Do not show ref
-	 *  @return     int             			1=OK, 0=KO
+	 *  @param		CommonObject	$object				Id of object to generate
+	 *  @param		Translate		$outputlangs		Lang output object
+	 *  @param		string			$srctemplatepath	Full path of source filename for generator using a template file
+	 *  @param		int				$hidedetails		Do not show line details
+	 *  @param		int				$hidedesc			Do not show desc
+	 *  @param		int				$hideref			Do not show ref
+	 *  @return		int									1=OK, 0=KO
 	 */
 	function write_file($object,$outputlangs,$srctemplatepath='',$hidedetails=0,$hidedesc=0,$hideref=0)
 	{

From 96e12e75bb0158c0766ec2b64d30f4b9f8c9a6a1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:18:47 +0200
Subject: [PATCH 077/118] Qual: Missing variable declaration

---
 htdocs/core/modules/fichinter/doc/pdf_soleil.modules.php | 1 +
 1 file changed, 1 insertion(+)

diff --git a/htdocs/core/modules/fichinter/doc/pdf_soleil.modules.php b/htdocs/core/modules/fichinter/doc/pdf_soleil.modules.php
index 8b7505b54c1..0d28eda7b66 100644
--- a/htdocs/core/modules/fichinter/doc/pdf_soleil.modules.php
+++ b/htdocs/core/modules/fichinter/doc/pdf_soleil.modules.php
@@ -240,6 +240,7 @@ class pdf_soleil extends ModelePDFFicheinter
 					$valide = $objectligne->id ? $objectligne->fetch($objectligne->id) : 0;
 					if ($valide > 0 || $object->specimen)
 					{
+						$curX = $this->posxdesc-1;
 						$curY = $nexY;
 						$pdf->SetFont('','', $default_font_size - 1);   // Into loop to work with multipage
 						$pdf->SetTextColor(0,0,0);

From aacd65797200fb550c062ba19fe43714d612c46b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:19:08 +0200
Subject: [PATCH 078/118] Qual: Wrong variable name

---
 htdocs/core/modules/fichinter/modules_fichinter.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/modules/fichinter/modules_fichinter.php b/htdocs/core/modules/fichinter/modules_fichinter.php
index cb0336f2bd2..35e5fd4ed33 100644
--- a/htdocs/core/modules/fichinter/modules_fichinter.php
+++ b/htdocs/core/modules/fichinter/modules_fichinter.php
@@ -227,7 +227,7 @@ function fichinter_create($db, $object, $modele, $outputlangs, $hidedetails=0, $
 			include_once DOL_DOCUMENT_ROOT . '/core/class/interfaces.class.php';
 			$interface=new Interfaces($db);
 			$result=$interface->run_triggers('FICHINTER_BUILDDOC',$object,$user,$langs,$conf);
-			if ($result < 0) { $error++; $this->errors=$interface->errors; }
+			if ($result < 0) { $error++; $obj->errors=$interface->errors; }
 			// Fin appel triggers
 
 			return 1;

From 126d2522fd2d72290157746f798bc4b85f81c08e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:19:30 +0200
Subject: [PATCH 079/118] Qual: Missing global declaration

---
 htdocs/core/modules/fichinter/mod_pacific.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/modules/fichinter/mod_pacific.php b/htdocs/core/modules/fichinter/mod_pacific.php
index 227d04f5ba5..d50f0be861d 100644
--- a/htdocs/core/modules/fichinter/mod_pacific.php
+++ b/htdocs/core/modules/fichinter/mod_pacific.php
@@ -65,7 +65,7 @@ class mod_pacific extends ModeleNumRefFicheinter
 	 */
 	function canBeActivated()
 	{
-		global $langs,$conf;
+		global $langs,$conf,$db;
 
 		$langs->load("bills");
 

From e7d9423812a19ef12e6c6510c4d084fb9d92d281 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:19:48 +0200
Subject: [PATCH 080/118] Qual: Wrong variable name

---
 htdocs/core/modules/livraison/modules_livraison.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/htdocs/core/modules/livraison/modules_livraison.php b/htdocs/core/modules/livraison/modules_livraison.php
index e956d455640..bb4992fb3e2 100644
--- a/htdocs/core/modules/livraison/modules_livraison.php
+++ b/htdocs/core/modules/livraison/modules_livraison.php
@@ -230,7 +230,7 @@ function delivery_order_pdf_create($db, $object, $modele, $outputlangs='')
 			$interface=new Interfaces($db);
 			$result=$interface->run_triggers('DELIVERY_BUILDDOC',$object,$user,$langs,$conf);
 			if ($result < 0) {
-				$error++; $this->errors=$interface->errors;
+				$error++; $obj->errors=$interface->errors;
 			}
 			// Fin appel triggers
 
@@ -251,4 +251,4 @@ function delivery_order_pdf_create($db, $object, $modele, $outputlangs='')
 	}
 }
 
-?>
\ No newline at end of file
+?>

From 70606d04ea772cbd7fc2fd4f673eb7438db7e0bf Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:20:04 +0200
Subject: [PATCH 081/118] Qual: Missing global declaration

---
 htdocs/core/modules/livraison/mod_livraison_jade.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/modules/livraison/mod_livraison_jade.php b/htdocs/core/modules/livraison/mod_livraison_jade.php
index f3835620896..43b2c2e4cf8 100644
--- a/htdocs/core/modules/livraison/mod_livraison_jade.php
+++ b/htdocs/core/modules/livraison/mod_livraison_jade.php
@@ -70,7 +70,7 @@ class mod_livraison_jade extends ModeleNumRefDeliveryOrder
      */
     function canBeActivated()
     {
-        global $langs,$conf;
+        global $langs,$conf,$db;
 
         $langs->load("bills");
 

From 5d74a5a852550df7c8dfac839f518a725f2cc3cb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:21:44 +0200
Subject: [PATCH 082/118] Qual: Wrong variable name

---
 htdocs/core/modules/livraison/mod_livraison_saphir.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/htdocs/core/modules/livraison/mod_livraison_saphir.php b/htdocs/core/modules/livraison/mod_livraison_saphir.php
index 98e29ea33b9..da2f8bdcfb1 100644
--- a/htdocs/core/modules/livraison/mod_livraison_saphir.php
+++ b/htdocs/core/modules/livraison/mod_livraison_saphir.php
@@ -120,7 +120,7 @@ class mod_livraison_saphir extends ModeleNumRefDeliveryOrder
 			return 0;
 		}
 
-		$numFinal=get_next_value($db,$mask,'livraison','ref','',$objsoc->code_client,$livraison->date_livraison);
+		$numFinal=get_next_value($db,$mask,'livraison','ref','',$objsoc->code_client,$object->date_livraison);
 
 		return  $numFinal;
     }
@@ -153,4 +153,4 @@ class mod_livraison_saphir extends ModeleNumRefDeliveryOrder
 
 }
 
-?>
\ No newline at end of file
+?>

From 4f3a28e7ede0761ddc5a9f966a4daa72268fe227 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:23:29 +0200
Subject: [PATCH 083/118] Qual: Removed unused variable

---
 htdocs/core/modules/livraison/pdf/pdf_typhon.modules.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/modules/livraison/pdf/pdf_typhon.modules.php b/htdocs/core/modules/livraison/pdf/pdf_typhon.modules.php
index b9d61ec1049..eb8cb23907f 100644
--- a/htdocs/core/modules/livraison/pdf/pdf_typhon.modules.php
+++ b/htdocs/core/modules/livraison/pdf/pdf_typhon.modules.php
@@ -438,7 +438,7 @@ class pdf_typhon extends ModelePDFDeliveryOrder
 				}
 
 				// Affiche zone infos
-				$posy=$this->_tableau_info($pdf, $object, $bottomlasttab, $outputlangs);
+				$this->_tableau_info($pdf, $object, $bottomlasttab, $outputlangs);
 
 				// Pied de page
 				$this->_pagefoot($pdf,$object,$outputlangs);

From 7497a72b1db65ba0532d2f0b4426b2ff05aa2e7d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:26:03 +0200
Subject: [PATCH 084/118] Qual: Removed dead code

---
 htdocs/core/modules/livraison/pdf/pdf_typhon.modules.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/modules/livraison/pdf/pdf_typhon.modules.php b/htdocs/core/modules/livraison/pdf/pdf_typhon.modules.php
index eb8cb23907f..e9004283085 100644
--- a/htdocs/core/modules/livraison/pdf/pdf_typhon.modules.php
+++ b/htdocs/core/modules/livraison/pdf/pdf_typhon.modules.php
@@ -685,7 +685,7 @@ class pdf_typhon extends ModelePDFDeliveryOrder
 		$pdf->SetTextColor(0,0,60);
 		if ($object->date_valid)
 		{
-			$pdf->MultiCell(100, 4, $outputlangs->transnoentities("Date")." : " . dol_print_date(($object->date_delivery?$object->date_delivery:$date->valid),"%d %b %Y",false,$outputlangs,true), '', 'R');
+			$pdf->MultiCell(100, 4, $outputlangs->transnoentities("Date")." : " . dol_print_date($object->date_delivery,"%d %b %Y",false,$outputlangs,true), '', 'R');
 		}
 		else
 		{

From 20983b480723cc70baee4cefb0359198bbbe0d55 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:29:26 +0200
Subject: [PATCH 085/118] Qual: Removed unused variable

---
 htdocs/core/modules/member/modules_cards.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/htdocs/core/modules/member/modules_cards.php b/htdocs/core/modules/member/modules_cards.php
index 42c54fb4080..5732cbd829a 100644
--- a/htdocs/core/modules/member/modules_cards.php
+++ b/htdocs/core/modules/member/modules_cards.php
@@ -156,11 +156,11 @@ function members_card_pdf_create($db, $arrayofmembers, $modele, $outputlangs)
 
 	else
 	{
-		dol_print_error('',$langs->trans("Error")." ".$langs->trans("ErrorFileDoesNotExists",$dir.$file));
+		dol_print_error('',$langs->trans("Error")." ".$langs->trans("ErrorFileDoesNotExists",$file));
 		return -1;
 	}
 
 
 }
 
-?>
\ No newline at end of file
+?>

From f476bee0c7cdcdb9145d7a70c1fee404bd18f44e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:34:36 +0200
Subject: [PATCH 086/118] Qual: Missing variable declaration

---
 htdocs/core/modules/modCron.class.php | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/htdocs/core/modules/modCron.class.php b/htdocs/core/modules/modCron.class.php
index 131ee875c44..c7c221d0856 100644
--- a/htdocs/core/modules/modCron.class.php
+++ b/htdocs/core/modules/modCron.class.php
@@ -149,7 +149,9 @@ class modCron extends DolibarrModules
      */
     function init($options='')
     {
-        // Prevent pb of modules not correctly disabled
+	    $sql = array();
+
+	    // Prevent pb of modules not correctly disabled
         //$this->remove($options);
 
         return $this->_init($sql,$options);

From 988e7a137e65b1cbb647a3ee11d5ab7490f8ab5d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:35:21 +0200
Subject: [PATCH 087/118] Qual: Missing global declaration

---
 htdocs/core/modules/modExpedition.class.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/modules/modExpedition.class.php b/htdocs/core/modules/modExpedition.class.php
index b14b72ffdc3..bcdece7930f 100644
--- a/htdocs/core/modules/modExpedition.class.php
+++ b/htdocs/core/modules/modExpedition.class.php
@@ -243,7 +243,7 @@ class modExpedition extends DolibarrModules
 	 */
 	function init($options='')
 	{
-		global $conf;
+		global $conf,$langs;
 
 		// Permissions
 		$this->remove($options);

From db82a6f0e6743bac029c97c40582c2366b2a5d42 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:35:47 +0200
Subject: [PATCH 088/118] Qual: Missing global declaration

---
 htdocs/core/modules/modProjet.class.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/modules/modProjet.class.php b/htdocs/core/modules/modProjet.class.php
index 63e917ab04d..189df9c4b0d 100644
--- a/htdocs/core/modules/modProjet.class.php
+++ b/htdocs/core/modules/modProjet.class.php
@@ -298,7 +298,7 @@ class modProjet extends DolibarrModules
 	 */
 	function init($options='')
 	{
-		global $conf;
+		global $conf,$langs;
 
 		// Permissions
 		$this->remove($options);

From 858d1dc8d009de17dafa54f56220c3bef7dd5d49 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:36:40 +0200
Subject: [PATCH 089/118] Qual: Missing variable declaration

---
 htdocs/core/modules/modSkype.class.php | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/htdocs/core/modules/modSkype.class.php b/htdocs/core/modules/modSkype.class.php
index ab3f97899d9..c1c7d8aed76 100644
--- a/htdocs/core/modules/modSkype.class.php
+++ b/htdocs/core/modules/modSkype.class.php
@@ -99,6 +99,8 @@ class modSkype extends DolibarrModules
      */
     function init($options='')
     {
+		$sql = array();
+
         // Prevent pb of modules not correctly disabled
         //$this->remove($options);
 

From 6174099827d0488b4e991f339f14d9b917ddf146 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:37:47 +0200
Subject: [PATCH 090/118] Qual: Wrong type in method documentation

---
 htdocs/core/modules/product/mod_codeproduct_elephant.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/modules/product/mod_codeproduct_elephant.php b/htdocs/core/modules/product/mod_codeproduct_elephant.php
index fab503e7a56..ea0b6144c91 100644
--- a/htdocs/core/modules/product/mod_codeproduct_elephant.php
+++ b/htdocs/core/modules/product/mod_codeproduct_elephant.php
@@ -63,7 +63,7 @@ class mod_codeproduct_elephant extends ModeleProductCode
 
 	/**		Return description of module
 	 *
-	 * 		@param	string 		$langs		Object langs
+	 * 		@param	Translate	$langs		Object langs
 	 * 		@return string      			Description of module
 	 */
 	function info($langs)

From 2cfe27b43411d6a75080f69deb52f7d6a26e7bfe Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:38:15 +0200
Subject: [PATCH 091/118] Qual: Wrong type in method documentation

---
 htdocs/core/modules/product/mod_codeproduct_leopard.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/modules/product/mod_codeproduct_leopard.php b/htdocs/core/modules/product/mod_codeproduct_leopard.php
index 0864eeb7d77..fb044429dc7 100644
--- a/htdocs/core/modules/product/mod_codeproduct_leopard.php
+++ b/htdocs/core/modules/product/mod_codeproduct_leopard.php
@@ -63,7 +63,7 @@ class mod_codeproduct_leopard extends ModeleProductCode
 
 	/**		Return description of module
 	 *
-	 * 		@param	string	$langs		Object langs
+	 * 		@param	Translate	$langs	Object langs
 	 * 		@return string      		Description of module
 	 */
 	function info($langs)

From 0d92abc03704ee2c47786bb13397edbc5b40b240 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:38:32 +0200
Subject: [PATCH 092/118] Qual: Missing global declaration

---
 htdocs/core/modules/project/mod_project_simple.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/htdocs/core/modules/project/mod_project_simple.php b/htdocs/core/modules/project/mod_project_simple.php
index cce6e638336..fb2e6cf1386 100644
--- a/htdocs/core/modules/project/mod_project_simple.php
+++ b/htdocs/core/modules/project/mod_project_simple.php
@@ -67,7 +67,7 @@ class mod_project_simple extends ModeleNumRefProjects
      */
     function canBeActivated()
     {
-    	global $conf,$langs;
+    	global $conf,$langs,$db;
 
         $coyymm=''; $max='';
 
@@ -150,4 +150,4 @@ class mod_project_simple extends ModeleNumRefProjects
     }
 }
 
-?>
\ No newline at end of file
+?>

From 2abbc8845f08587cca327f9b98dbf2af81977a5b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:39:17 +0200
Subject: [PATCH 093/118] Qual: Missing global declaration

---
 htdocs/core/modules/project/task/mod_task_simple.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/htdocs/core/modules/project/task/mod_task_simple.php b/htdocs/core/modules/project/task/mod_task_simple.php
index 13c23cb4f73..f6acd1b4d7a 100644
--- a/htdocs/core/modules/project/task/mod_task_simple.php
+++ b/htdocs/core/modules/project/task/mod_task_simple.php
@@ -67,7 +67,7 @@ class mod_task_simple extends ModeleNumRefTask
      */
     function canBeActivated()
     {
-    	global $conf,$langs;
+    	global $conf,$langs,$db;
 
         $coyymm=''; $max='';
 
@@ -150,4 +150,4 @@ class mod_task_simple extends ModeleNumRefTask
     }
 }
 
-?>
\ No newline at end of file
+?>

From e561cc87f76bce387f4b1d9ea19c8d5218f1ca77 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:40:48 +0200
Subject: [PATCH 094/118] Qual: Wrong variable name

---
 .../modules/project/task/pdf/doc_generic_task_odt.modules.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/htdocs/core/modules/project/task/pdf/doc_generic_task_odt.modules.php b/htdocs/core/modules/project/task/pdf/doc_generic_task_odt.modules.php
index f3ccc773681..3d76834dc9e 100644
--- a/htdocs/core/modules/project/task/pdf/doc_generic_task_odt.modules.php
+++ b/htdocs/core/modules/project/task/pdf/doc_generic_task_odt.modules.php
@@ -562,7 +562,7 @@ class doc_generic_task_odt extends ModelePDFTask
 					if (!empty($project->fk_soc)) $socid = $project->fk_soc;
 
 					$tmparray=$this->get_substitutionarray_tasks($object,$outputlangs);
-					complete_substitutions_array($tmparray, $outputlangs, $task);
+					complete_substitutions_array($tmparray, $outputlangs, $object);
 					foreach($tmparray as $key => $val)
 					{
 						try
@@ -837,4 +837,4 @@ class doc_generic_task_odt extends ModelePDFTask
 	}
 
 }
-?>
\ No newline at end of file
+?>

From 1d52f6d6c25dd7c03ccaade617d90bf7d5ec91f5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:42:05 +0200
Subject: [PATCH 095/118] Qual: Fixed typo

---
 htdocs/core/modules/propale/doc/pdf_azur.modules.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/modules/propale/doc/pdf_azur.modules.php b/htdocs/core/modules/propale/doc/pdf_azur.modules.php
index af073ddc1ca..0c3a8c824fb 100644
--- a/htdocs/core/modules/propale/doc/pdf_azur.modules.php
+++ b/htdocs/core/modules/propale/doc/pdf_azur.modules.php
@@ -883,7 +883,7 @@ class pdf_azur extends ModelePDFPropales
 									$tvakey=str_replace('*','',$tvakey);
 									$tvacompl = " (".$outputlangs->transnoentities("NonPercuRecuperable").")";
 								}
-								$totalvat = $outputlangs->transcountrynoentities("TotalLT2".$mysoc->country_code).' ';
+								$totalvat = $outputlangs->transcountrynoentities("TotalLT2", $mysoc->country_code).' ';
 								$totalvat.=vatrate(abs($tvakey),1).$tvacompl;
 								$pdf->MultiCell($col2x-$col1x, $tab2_hl, $totalvat, 0, 'L', 1);
 

From e738a294e80491568ccdca84ed6f0c197c880fde Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:44:48 +0200
Subject: [PATCH 096/118] Qual: Wrong variable name

---
 htdocs/core/modules/propale/modules_propale.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/modules/propale/modules_propale.php b/htdocs/core/modules/propale/modules_propale.php
index b6948a530be..289862c8523 100644
--- a/htdocs/core/modules/propale/modules_propale.php
+++ b/htdocs/core/modules/propale/modules_propale.php
@@ -233,7 +233,7 @@ function propale_pdf_create($db, $object, $modele, $outputlangs, $hidedetails=0,
 			include_once DOL_DOCUMENT_ROOT . '/core/class/interfaces.class.php';
 			$interface=new Interfaces($db);
 			$result=$interface->run_triggers('PROPAL_BUILDDOC',$object,$user,$langs,$conf);
-			if ($result < 0) { $error++; $this->errors=$interface->errors; }
+			if ($result < 0) { $error++; $obj->errors=$interface->errors; }
 			// Fin appel triggers
 
 			return 1;

From 22263dc2c1416114866b7e9d7d8f4778c2aa8401 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:45:08 +0200
Subject: [PATCH 097/118] Qual: Missing global declaration

---
 htdocs/core/modules/propale/mod_propale_marbre.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/modules/propale/mod_propale_marbre.php b/htdocs/core/modules/propale/mod_propale_marbre.php
index d14c176e08b..86a774da08d 100644
--- a/htdocs/core/modules/propale/mod_propale_marbre.php
+++ b/htdocs/core/modules/propale/mod_propale_marbre.php
@@ -68,7 +68,7 @@ class mod_propale_marbre extends ModeleNumRefPropales
 	 */
 	function canBeActivated()
 	{
-		global $conf,$langs;
+		global $conf,$langs,$db;
 
 		$pryymm=''; $max='';
 

From aa1ff28158bd8907df6290a6cb31f52a7aad687d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:45:29 +0200
Subject: [PATCH 098/118] Qual: Missing global declaration

---
 htdocs/core/modules/rapport/pdf_paiement.class.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/modules/rapport/pdf_paiement.class.php b/htdocs/core/modules/rapport/pdf_paiement.class.php
index 3d3c45e1963..44946cdf38f 100644
--- a/htdocs/core/modules/rapport/pdf_paiement.class.php
+++ b/htdocs/core/modules/rapport/pdf_paiement.class.php
@@ -38,7 +38,7 @@ class pdf_paiement
 	 */
 	function __construct($db)
 	{
-		global $langs;
+		global $langs,$conf;
 		$langs->load("bills");
 		$langs->load("compta");
 

From f357d3c5abfe4d35bbb6921d51320283851e5851 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:45:58 +0200
Subject: [PATCH 099/118] Qual: Missing global declaration

---
 htdocs/core/modules/societe/modules_societe.class.php | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/htdocs/core/modules/societe/modules_societe.class.php b/htdocs/core/modules/societe/modules_societe.class.php
index 1944d373f09..d55795664a3 100644
--- a/htdocs/core/modules/societe/modules_societe.class.php
+++ b/htdocs/core/modules/societe/modules_societe.class.php
@@ -353,6 +353,8 @@ abstract class ModeleAccountancyCode
      */
     function get_code($db, $societe, $type='')
     {
+	    global $langs;
+
         return $langs->trans("NotAvailable");
     }
 }

From 953e196a2c10965f465776ed11d31dceff3b876d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:47:14 +0200
Subject: [PATCH 100/118] Qual: Missing variable declaration

---
 htdocs/core/modules/societe/modules_societe.class.php | 1 +
 1 file changed, 1 insertion(+)

diff --git a/htdocs/core/modules/societe/modules_societe.class.php b/htdocs/core/modules/societe/modules_societe.class.php
index d55795664a3..1386e1d37bc 100644
--- a/htdocs/core/modules/societe/modules_societe.class.php
+++ b/htdocs/core/modules/societe/modules_societe.class.php
@@ -376,6 +376,7 @@ function thirdparty_doc_create($db, $object, $message, $modele, $outputlangs)
 {
     global $conf,$langs,$user;
     $langs->load("bills");
+	$error=0;
 
     $dir = DOL_DOCUMENT_ROOT . "/core/modules/societe/doc";
     $srctemplatepath='';

From 9bb454b242dfa43da3d3725d177710b9f6311c14 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:47:23 +0200
Subject: [PATCH 101/118] Qual: Wrong variable name

---
 htdocs/core/modules/societe/modules_societe.class.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/modules/societe/modules_societe.class.php b/htdocs/core/modules/societe/modules_societe.class.php
index 1386e1d37bc..0771380c1cc 100644
--- a/htdocs/core/modules/societe/modules_societe.class.php
+++ b/htdocs/core/modules/societe/modules_societe.class.php
@@ -425,7 +425,7 @@ function thirdparty_doc_create($db, $object, $message, $modele, $outputlangs)
             $interface=new Interfaces($db);
             $result=$interface->run_triggers('COMPANY_BUILDDOC',$object,$user,$langs,$conf);
             if ($result < 0) {
-            	$error++; $this->errors=$interface->errors;
+            	$error++; $obj->errors=$interface->errors;
             }
             // Fin appel triggers
 

From 6366a66efd0961e0f79d306ad2b9ff5bde14cb2c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:48:09 +0200
Subject: [PATCH 102/118] Qual: Wrong type in method documentation

---
 htdocs/core/modules/societe/mod_codeclient_elephant.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/modules/societe/mod_codeclient_elephant.php b/htdocs/core/modules/societe/mod_codeclient_elephant.php
index 601b6743ad4..4bf251a0210 100644
--- a/htdocs/core/modules/societe/mod_codeclient_elephant.php
+++ b/htdocs/core/modules/societe/mod_codeclient_elephant.php
@@ -64,7 +64,7 @@ class mod_codeclient_elephant extends ModeleThirdPartyCode
 
 	/**		Return description of module
 	 *
-	 * 		@param	string 		$langs		Object langs
+	 * 		@param	Translate	$langs		Object langs
 	 * 		@return string      			Description of module
 	 */
 	function info($langs)

From 32f5ecfaa325cc465b60a61663b6d75a75f4cae3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:48:34 +0200
Subject: [PATCH 103/118] Qual: Wrong type in method documentation

---
 htdocs/core/modules/societe/mod_codeclient_leopard.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/htdocs/core/modules/societe/mod_codeclient_leopard.php b/htdocs/core/modules/societe/mod_codeclient_leopard.php
index affee5274ca..bedbdaad7ce 100644
--- a/htdocs/core/modules/societe/mod_codeclient_leopard.php
+++ b/htdocs/core/modules/societe/mod_codeclient_leopard.php
@@ -62,7 +62,7 @@ class mod_codeclient_leopard extends ModeleThirdPartyCode
 
 	/**		Return description of module
 	 *
-	 * 		@param	string	$langs		Object langs
+	 * 		@param	Translate	$langs	Object langs
 	 * 		@return string      		Description of module
 	 */
 	function info($langs)
@@ -119,4 +119,4 @@ class mod_codeclient_leopard extends ModeleThirdPartyCode
 	}
 }
 
-?>
\ No newline at end of file
+?>

From 370996d5c4544323da33d8f844cbce3d8fdba4af Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:48:55 +0200
Subject: [PATCH 104/118] Qual: Wrong type in method documentation

---
 htdocs/core/modules/societe/mod_codeclient_monkey.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/modules/societe/mod_codeclient_monkey.php b/htdocs/core/modules/societe/mod_codeclient_monkey.php
index 1e55a6256f3..292a692c3f8 100644
--- a/htdocs/core/modules/societe/mod_codeclient_monkey.php
+++ b/htdocs/core/modules/societe/mod_codeclient_monkey.php
@@ -64,7 +64,7 @@ class mod_codeclient_monkey extends ModeleThirdPartyCode
 
 	/**		Return description of module
 	 *
-	 * 		@param	string	$langs		Object langs
+	 * 		@param	Translate	$langs	Object langs
 	 * 		@return string      		Description of module
 	 */
 	function info($langs)

From 10a099424116bcea6470b654168ec6a392d1e28f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:49:47 +0200
Subject: [PATCH 105/118] Qual: Wrong type in method documentation

---
 htdocs/core/modules/societe/mod_codecompta_panicum.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/modules/societe/mod_codecompta_panicum.php b/htdocs/core/modules/societe/mod_codecompta_panicum.php
index 16bdcbfcf5b..db2216900fe 100644
--- a/htdocs/core/modules/societe/mod_codecompta_panicum.php
+++ b/htdocs/core/modules/societe/mod_codecompta_panicum.php
@@ -46,7 +46,7 @@ class mod_codecompta_panicum extends ModeleAccountancyCode
 	/**
 	 * Return description of module
 	 *
-	 * @param	string	$langs		Object langs
+	 * @param	Translate	$langs	Object langs
 	 * @return 	string      		Description of module
 	 */
 	function info($langs)

From c4569b10d0826e3a7973bbe46cd6cd94d46953dc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:50:26 +0200
Subject: [PATCH 106/118] Qual: Wrong variable name

---
 .../modules/supplier_invoice/modules_facturefournisseur.php     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/modules/supplier_invoice/modules_facturefournisseur.php b/htdocs/core/modules/supplier_invoice/modules_facturefournisseur.php
index fc225a4e22d..a646ad39a75 100644
--- a/htdocs/core/modules/supplier_invoice/modules_facturefournisseur.php
+++ b/htdocs/core/modules/supplier_invoice/modules_facturefournisseur.php
@@ -224,7 +224,7 @@ function supplier_invoice_pdf_create($db, $object, $modele, $outputlangs, $hided
 			include_once DOL_DOCUMENT_ROOT . '/core/class/interfaces.class.php';
 			$interface=new Interfaces($db);
 			$result=$interface->run_triggers('BILL_SUPPLIER_BUILDDOC',$object,$user,$langs,$conf);
-			if ($result < 0) { $error++; $this->errors=$interface->errors; }
+			if ($result < 0) { $error++; $obj->errors=$interface->errors; }
 			// End calls triggers
 
 			return 1;

From 79e2bf47376dec63ed30723c8aede97046a13428 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:50:45 +0200
Subject: [PATCH 107/118] Qual: Missing global declaration

---
 .../modules/supplier_invoice/mod_facture_fournisseur_cactus.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/modules/supplier_invoice/mod_facture_fournisseur_cactus.php b/htdocs/core/modules/supplier_invoice/mod_facture_fournisseur_cactus.php
index 0084a951882..55f8bb1f978 100644
--- a/htdocs/core/modules/supplier_invoice/mod_facture_fournisseur_cactus.php
+++ b/htdocs/core/modules/supplier_invoice/mod_facture_fournisseur_cactus.php
@@ -68,7 +68,7 @@ class mod_facture_fournisseur_cactus extends ModeleNumRefSuppliersInvoices
      */
     function canBeActivated()
     {
-    	global $conf,$langs;
+    	global $conf,$langs,$db;
 
         $siyymm=''; $max='';
 

From 8f215205fa6e85845e56143a27ae03935426f206 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:52:39 +0200
Subject: [PATCH 108/118] Qual: Wrong type in method documentation

---
 .../supplier_invoice/pdf/pdf_canelle.modules.php   | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/htdocs/core/modules/supplier_invoice/pdf/pdf_canelle.modules.php b/htdocs/core/modules/supplier_invoice/pdf/pdf_canelle.modules.php
index b6ed22e3c37..d45a63a0b9e 100644
--- a/htdocs/core/modules/supplier_invoice/pdf/pdf_canelle.modules.php
+++ b/htdocs/core/modules/supplier_invoice/pdf/pdf_canelle.modules.php
@@ -127,13 +127,13 @@ class pdf_canelle extends ModelePDFSuppliersInvoices
 	/**
      *  Function to build pdf onto disk
      *
-     *  @param		int		$object				Id of object to generate
-     *  @param		object	$outputlangs		Lang output object
-     *  @param		string	$srctemplatepath	Full path of source filename for generator using a template file
-     *  @param		int		$hidedetails		Do not show line details
-     *  @param		int		$hidedesc			Do not show desc
-     *  @param		int		$hideref			Do not show ref
-     *  @return 	int             			1=OK, 0=KO
+     *  @param		FactureFournisseur	$object				Id of object to generate
+     *  @param		Translate			$outputlangs		Lang output object
+     *  @param		string				$srctemplatepath	Full path of source filename for generator using a template file
+     *  @param		int					$hidedetails		Do not show line details
+     *  @param		int					$hidedesc			Do not show desc
+     *  @param		int					$hideref			Do not show ref
+     *  @return		int										1=OK, 0=KO
 	 */
 	function write_file($object, $outputlangs='', $srctemplatepath='', $hidedetails=0, $hidedesc=0, $hideref=0)
 	{

From 167457562e6a15df77b0055c804e5d2a034f72c0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:54:31 +0200
Subject: [PATCH 109/118] Qual: Wrong variable name

---
 .../core/modules/supplier_order/modules_commandefournisseur.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/modules/supplier_order/modules_commandefournisseur.php b/htdocs/core/modules/supplier_order/modules_commandefournisseur.php
index 72268b62831..50982a8b1c7 100644
--- a/htdocs/core/modules/supplier_order/modules_commandefournisseur.php
+++ b/htdocs/core/modules/supplier_order/modules_commandefournisseur.php
@@ -230,7 +230,7 @@ function supplier_order_pdf_create($db, $object, $modele, $outputlangs, $hidedet
 			$interface=new Interfaces($db);
 			$result=$interface->run_triggers('ORDER_SUPPLIER_BUILDDOC',$object,$user,$langs,$conf);
 			if ($result < 0) { 
-				$error++; $this->errors=$interface->errors; 
+				$error++; $obj->errors=$interface->errors;
 			}
 			// End calls triggers
 

From e3fa0332f49ea16414dbc54dd6bb3ccbd6ccec18 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:54:50 +0200
Subject: [PATCH 110/118] Qual: Missing global declaration

---
 .../modules/supplier_order/mod_commande_fournisseur_muguet.php  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/modules/supplier_order/mod_commande_fournisseur_muguet.php b/htdocs/core/modules/supplier_order/mod_commande_fournisseur_muguet.php
index 66c07355b29..e74263304e3 100644
--- a/htdocs/core/modules/supplier_order/mod_commande_fournisseur_muguet.php
+++ b/htdocs/core/modules/supplier_order/mod_commande_fournisseur_muguet.php
@@ -68,7 +68,7 @@ class mod_commande_fournisseur_muguet extends ModeleNumRefSuppliersOrders
      */
     function canBeActivated()
     {
-    	global $conf,$langs;
+    	global $conf,$langs,$db;
 
         $coyymm=''; $max='';
 

From 490b45ea7e136b36a2d7b7dc299d85d59c3f8efd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:56:06 +0200
Subject: [PATCH 111/118] Qual: Wrong type in method documentation

---
 .../supplier_order/pdf/pdf_muscadet.modules.php    | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/htdocs/core/modules/supplier_order/pdf/pdf_muscadet.modules.php b/htdocs/core/modules/supplier_order/pdf/pdf_muscadet.modules.php
index 2b2f598a9e8..23b502524b9 100644
--- a/htdocs/core/modules/supplier_order/pdf/pdf_muscadet.modules.php
+++ b/htdocs/core/modules/supplier_order/pdf/pdf_muscadet.modules.php
@@ -132,13 +132,13 @@ class pdf_muscadet extends ModelePDFSuppliersOrders
     /**
      *  Function to build pdf onto disk
      *
-     *  @param		int		$object				Id of object to generate
-     *  @param		object	$outputlangs		Lang output object
-     *  @param		string	$srctemplatepath	Full path of source filename for generator using a template file
-     *  @param		int		$hidedetails		Do not show line details
-     *  @param		int		$hidedesc			Do not show desc
-     *  @param		int		$hideref			Do not show ref
-     *  @return     int             			1=OK, 0=KO
+     *  @param		CommandeFournisseur	$object				Id of object to generate
+     *  @param		Translate			$outputlangs		Lang output object
+     *  @param		string				$srctemplatepath	Full path of source filename for generator using a template file
+     *  @param		int					$hidedetails		Do not show line details
+     *  @param		int					$hidedesc			Do not show desc
+     *  @param		int					$hideref			Do not show ref
+     *  @return		int										1=OK, 0=KO
      */
 	function write_file($object,$outputlangs='',$srctemplatepath='',$hidedetails=0,$hidedesc=0,$hideref=0)
 	{

From 7852020b3da996a3f125a097fe26ed500861f59c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 17:58:15 +0200
Subject: [PATCH 112/118] Qual: Missing global declaration

---
 htdocs/core/modules/supplier_order/pdf/pdf_muscadet.modules.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/modules/supplier_order/pdf/pdf_muscadet.modules.php b/htdocs/core/modules/supplier_order/pdf/pdf_muscadet.modules.php
index 23b502524b9..29d41e3dde7 100644
--- a/htdocs/core/modules/supplier_order/pdf/pdf_muscadet.modules.php
+++ b/htdocs/core/modules/supplier_order/pdf/pdf_muscadet.modules.php
@@ -142,7 +142,7 @@ class pdf_muscadet extends ModelePDFSuppliersOrders
      */
 	function write_file($object,$outputlangs='',$srctemplatepath='',$hidedetails=0,$hidedesc=0,$hideref=0)
 	{
-		global $user,$langs,$conf,$hookmanager;
+		global $user,$langs,$conf,$hookmanager,$mysoc;
 
 		if (! is_object($outputlangs)) $outputlangs=$langs;
 		// For backward compatibility with FPDF, force output charset to ISO, because FPDF expect text to be encoded in ISO

From a57b7d4ed2c7335f3e1d7749fde5cbbaa82939a3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 18:05:54 +0200
Subject: [PATCH 113/118] Qual: Derived missing variable from a known one

---
 htdocs/core/modules/syslog/mod_syslog_chromephp.php | 12 ++++++------
 htdocs/core/modules/syslog/mod_syslog_firephp.php   | 12 ++++++------
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/htdocs/core/modules/syslog/mod_syslog_chromephp.php b/htdocs/core/modules/syslog/mod_syslog_chromephp.php
index e8291a2daf3..06d37dfa431 100644
--- a/htdocs/core/modules/syslog/mod_syslog_chromephp.php
+++ b/htdocs/core/modules/syslog/mod_syslog_chromephp.php
@@ -112,7 +112,7 @@ class mod_syslog_chromephp extends LogHandler implements LogHandlerInterface
 	/**
 	 * 	Output log content
 	 *
-	 *	@param	string	$content	Content to log
+	 *	@param	array	$content	Content to log
 	 * 	@return	void
 	 */
 	public function export($content)
@@ -133,14 +133,14 @@ class mod_syslog_chromephp extends LogHandler implements LogHandlerInterface
 			include_once 'ChromePhp.class.php';
 			set_include_path($oldinclude);
 			ob_start();	// To be sure headers are not flushed until all page is completely processed
-			if ($level == LOG_ERR) ChromePhp::error($message);
-			elseif ($level == LOG_WARNING) ChromePhp::warn($message);
-			elseif ($level == LOG_INFO) ChromePhp::log($message);
-			else ChromePhp::log($message);
+			if ($content['level'] == LOG_ERR) ChromePhp::error($content['message']);
+			elseif ($content['level'] == LOG_WARNING) ChromePhp::warn($content['message']);
+			elseif ($content['level'] == LOG_INFO) ChromePhp::log($content['message']);
+			else ChromePhp::log($content['message']);
 		}
 		catch (Exception $e)
 		{
 			// Do not use dol_syslog here to avoid infinite loop
 		}
 	}
-}
\ No newline at end of file
+}
diff --git a/htdocs/core/modules/syslog/mod_syslog_firephp.php b/htdocs/core/modules/syslog/mod_syslog_firephp.php
index 4a95a89862f..8ff2a52fa05 100644
--- a/htdocs/core/modules/syslog/mod_syslog_firephp.php
+++ b/htdocs/core/modules/syslog/mod_syslog_firephp.php
@@ -110,7 +110,7 @@ class mod_syslog_firephp extends LogHandler implements LogHandlerInterface
 	/**
 	 * 	Output log content
 	 *
-	 *	@param	string	$content	Content to log
+	 *	@param	array	$content	Content to log
 	 * 	@return	void
 	 */
 	public function export($content)
@@ -132,10 +132,10 @@ class mod_syslog_firephp extends LogHandler implements LogHandlerInterface
 			set_include_path($oldinclude);
 			ob_start();	// To be sure headers are not flushed until all page is completely processed
 			$firephp = FirePHP::getInstance(true);
-			if ($level == LOG_ERR) $firephp->error($message);
-			elseif ($level == LOG_WARNING) $firephp->warn($message);
-			elseif ($level == LOG_INFO) $firephp->log($message);
-			else $firephp->log($message);
+			if ($content['level'] == LOG_ERR) $firephp->error($content['message']);
+			elseif ($content['level'] == LOG_WARNING) $firephp->warn($content['message']);
+			elseif ($content['level'] == LOG_INFO) $firephp->log($content['message']);
+			else $firephp->log($content['message']);
 		}
 		catch (Exception $e)
 		{
@@ -143,4 +143,4 @@ class mod_syslog_firephp extends LogHandler implements LogHandlerInterface
 			return false;
 		}
 	}
-}
\ No newline at end of file
+}

From 11ef3ef34ec740b78081220cec60be800826ea47 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 18:07:31 +0200
Subject: [PATCH 114/118] Qual: Missing variable declaration

---
 htdocs/core/search_page.php | 1 +
 1 file changed, 1 insertion(+)

diff --git a/htdocs/core/search_page.php b/htdocs/core/search_page.php
index a05b4014899..9eb635262d7 100644
--- a/htdocs/core/search_page.php
+++ b/htdocs/core/search_page.php
@@ -65,6 +65,7 @@ $nbofsearch=0;
 $hookmanager->initHooks(array('searchform'));
 
 // Define $searchform
+$searchform = '';
 // TODO Mutualize code here with function left_menu into main.inc.php page
 if ((( ! empty($conf->societe->enabled) && (empty($conf->global->SOCIETE_DISABLE_PROSPECTS) || empty($conf->global->SOCIETE_DISABLE_CUSTOMERS))) || ! empty($conf->fournisseur->enabled)) && ! empty($conf->global->MAIN_SEARCHFORM_SOCIETE) && $user->rights->societe->lire)
 {

From 152fbbd7f68248bc4b9134c4c6d17e464925118d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 18:07:47 +0200
Subject: [PATCH 115/118] Qual: Wrong type in method documentation

---
 htdocs/main.inc.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/main.inc.php b/htdocs/main.inc.php
index 97604e4ca75..1f49083a876 100644
--- a/htdocs/main.inc.php
+++ b/htdocs/main.inc.php
@@ -1788,7 +1788,7 @@ function getHelpParamFor($helppagename,$langs)
  *  @param  string	$title              Title search area
  *  @param  string	$htmlmodesearch     Value to set into parameter "mode_search" ('soc','contact','products','member',...)
  *  @param  string	$htmlinputname      Field Name input form
- *  @return	void
+ *  @return	string
  */
 function printSearchForm($urlaction,$urlobject,$title,$htmlmodesearch,$htmlinputname)
 {

From ae11a151d7d5bc885b7ec7260ad645707e63c3b3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 18:11:48 +0200
Subject: [PATCH 116/118] Qual: Derived missing variable from a known one

---
 htdocs/cron/class/cronjob.class.php | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/htdocs/cron/class/cronjob.class.php b/htdocs/cron/class/cronjob.class.php
index 19db345f2cc..f1fc788a198 100644
--- a/htdocs/cron/class/cronjob.class.php
+++ b/htdocs/cron/class/cronjob.class.php
@@ -916,7 +916,8 @@ class Cronjob extends CommonObject
 		if ($this->jobtype=='method')
 		{
 			// load classes
-			$ret=dol_include_once("/".$this->module_name."/class/".$this->classesname,$this->objectname);
+			$file = "/".$this->module_name."/class/".$this->classesname;
+			$ret=dol_include_once($file,$this->objectname);
 			if ($ret===false)
 			{
 				$this->error=$langs->trans('CronCannotLoadClass',$file,$this->objectname);

From 7cdabb7d6c6cb8042c8c2fe6f0ab2a46701d4939 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 18:16:22 +0200
Subject: [PATCH 117/118] Qual: Derived missing variable from a known one

---
 htdocs/expedition/class/expedition.class.php | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/htdocs/expedition/class/expedition.class.php b/htdocs/expedition/class/expedition.class.php
index 1a59167a503..7d889d415d4 100644
--- a/htdocs/expedition/class/expedition.class.php
+++ b/htdocs/expedition/class/expedition.class.php
@@ -101,6 +101,7 @@ class Expedition extends CommonObject
 		$this->products = array();
 
 		// List of long language codes for status
+		$this->statuts = array();
 		$this->statuts[-1] = 'StatusSendingCanceled';
 		$this->statuts[0]  = 'StatusSendingDraft';
 		$this->statuts[1]  = 'StatusSendingValidated';
@@ -1087,7 +1088,7 @@ class Expedition extends CommonObject
 				$line->volume_units   	= $obj->volume_units;
 
 				// For invoicing
-				$tabprice = calcul_price_total($obj->qty_shipped, $obj->subprice, $obj->remise_percent, $obj->tva_tx, $obj->localtax1_tx, $obj->localtax2_tx, 0, 'HT', $info_bits, $obj->fk_product_type);	// We force type to 0
+				$tabprice = calcul_price_total($obj->qty_shipped, $obj->subprice, $obj->remise_percent, $obj->tva_tx, $obj->localtax1_tx, $obj->localtax2_tx, 0, 'HT', $obj->info_bits, $obj->fk_product_type);	// We force type to 0
 				$line->desc	         	= $obj->description;		// We need ->desc because some code into CommonObject use desc (property defined for other elements)
 				$line->qty 				= $obj->qty_shipped;
 				$line->total_ht			= $tabprice[0];

From 20842a5c45e3e5ea18279c4c8f0b0a82d907fccc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Doursenaud?= <rdoursenaud@gpcsolutions.fr>
Date: Wed, 23 Apr 2014 18:17:02 +0200
Subject: [PATCH 118/118] Qual: Missing variable declaration

---
 htdocs/expedition/class/expeditionbatch.class.php | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/htdocs/expedition/class/expeditionbatch.class.php b/htdocs/expedition/class/expeditionbatch.class.php
index e361548309d..27893018ce2 100644
--- a/htdocs/expedition/class/expeditionbatch.class.php
+++ b/htdocs/expedition/class/expeditionbatch.class.php
@@ -103,6 +103,8 @@ class ExpeditionLigneBatch extends CommonObject
 	 * @return	int						<0 if KO, Id of record (>0) if OK
 	 */
 	function create($id_line_expdet) {
+		$error = 0;
+
 		$id_line_expdet = (int) $id_line_expdet;
 		
 		$sql = "INSERT INTO ".MAIN_DB_PREFIX.self::$_table_element." (";