diff --git a/htdocs/adherents/class/adherent.class.php b/htdocs/adherents/class/adherent.class.php
index b4cedc98118..d009f12fdc8 100644
--- a/htdocs/adherents/class/adherent.class.php
+++ b/htdocs/adherents/class/adherent.class.php
@@ -216,22 +216,22 @@ class Adherent extends CommonObject
'__ID__'=>$this->id,
'__MEMBER_ID__'=>$this->id,
'__CIVILITY__'=>$this->getCivilityLabel(),
- '__FIRSTNAME__'=>$msgishtml?dol_htmlentitiesbr($this->firstname):$this->firstname,
- '__LASTNAME__'=>$msgishtml?dol_htmlentitiesbr($this->lastname):$this->lastname,
+ '__FIRSTNAME__'=>$msgishtml?dol_htmlentitiesbr($this->firstname):($this->firstname?$this->firstname:''),
+ '__LASTNAME__'=>$msgishtml?dol_htmlentitiesbr($this->lastname):($this->lastname?$this->lastname:''),
'__FULLNAME__'=>$msgishtml?dol_htmlentitiesbr($this->getFullName($langs)):$this->getFullName($langs),
- '__COMPANY__'=>$msgishtml?dol_htmlentitiesbr($this->societe):$this->societe,
- '__ADDRESS__'=>$msgishtml?dol_htmlentitiesbr($this->address):$this->address,
- '__ZIP__'=>$msgishtml?dol_htmlentitiesbr($this->zip):$this->zip,
- '__TOWN__'=>$msgishtml?dol_htmlentitiesbr($this->town):$this->town,
- '__COUNTRY__'=>$msgishtml?dol_htmlentitiesbr($this->country):$this->country,
- '__EMAIL__'=>$msgishtml?dol_htmlentitiesbr($this->email):$this->email,
- '__BIRTH__'=>$msgishtml?dol_htmlentitiesbr($birthday):$birthday,
- '__PHOTO__'=>$msgishtml?dol_htmlentitiesbr($this->photo):$this->photo,
- '__LOGIN__'=>$msgishtml?dol_htmlentitiesbr($this->login):$this->login,
- '__PASSWORD__'=>$msgishtml?dol_htmlentitiesbr($this->pass):$this->pass,
- '__PHONE__'=>$msgishtml?dol_htmlentitiesbr($this->phone):$this->phone,
- '__PHONEPRO__'=>$msgishtml?dol_htmlentitiesbr($this->phone_perso):$this->phone_perso,
- '__PHONEMOBILE__'=>$msgishtml?dol_htmlentitiesbr($this->phone_mobile):$this->phone_mobile,
+ '__COMPANY__'=>$msgishtml?dol_htmlentitiesbr($this->societe):($this->societe?$this->societe:''),
+ '__ADDRESS__'=>$msgishtml?dol_htmlentitiesbr($this->address):($this->address?$this->address:''),
+ '__ZIP__'=>$msgishtml?dol_htmlentitiesbr($this->zip):($this->zip?$this->zip:''),
+ '__TOWN__'=>$msgishtml?dol_htmlentitiesbr($this->town):($this->town?$this->town:''),
+ '__COUNTRY__'=>$msgishtml?dol_htmlentitiesbr($this->country):($this->country?$this->country:''),
+ '__EMAIL__'=>$msgishtml?dol_htmlentitiesbr($this->email):($this->email?$this->email:''),
+ '__BIRTH__'=>$msgishtml?dol_htmlentitiesbr($birthday):($birthday?$birthday:''),
+ '__PHOTO__'=>$msgishtml?dol_htmlentitiesbr($this->photo):($this->photo?$this->photo:''),
+ '__LOGIN__'=>$msgishtml?dol_htmlentitiesbr($this->login):($this->login?$this->login:''),
+ '__PASSWORD__'=>$msgishtml?dol_htmlentitiesbr($this->pass):($this->pass?$this->pass:''),
+ '__PHONE__'=>$msgishtml?dol_htmlentitiesbr($this->phone):($this->phone?$this->phone:''),
+ '__PHONEPRO__'=>$msgishtml?dol_htmlentitiesbr($this->phone_perso):($this->phone_perso?$this->phone_perso:''),
+ '__PHONEMOBILE__'=>$msgishtml?dol_htmlentitiesbr($this->phone_mobile):($this->phone_mobile?$this->phone_mobile:'')
);
complete_substitutions_array($substitutionarray, $langs, $this);
diff --git a/htdocs/core/actions_massactions.inc.php b/htdocs/core/actions_massactions.inc.php
index 00ffe03c7ed..300c06216f7 100644
--- a/htdocs/core/actions_massactions.inc.php
+++ b/htdocs/core/actions_massactions.inc.php
@@ -69,6 +69,8 @@ if (! $error && $massaction == 'confirm_presend')
$listofobjectid=array();
$listofobjectthirdparties=array();
$listofobjectref=array();
+ $attachedfilesThirdpartyObj=array();
+ $oneemailperrecipient=(GETPOST('oneemailperrecipient')=='on'?1:0);
if (! $error)
{
@@ -93,7 +95,7 @@ if (! $error && $massaction == 'confirm_presend')
}
// Check mandatory parameters
- if (empty($user->email))
+ if (GETPOST('fromtype','alpha') === 'user' && empty($user->email))
{
$error++;
setEventMessages($langs->trans("NoSenderEmailDefined"), null, 'warnings');
@@ -193,7 +195,6 @@ if (! $error && $massaction == 'confirm_presend')
$sendtocc=implode(',',$tmparray);
//var_dump($listofobjectref);exit;
- $attachedfiles=array('paths'=>array(), 'names'=>array(), 'mimes'=>array());
$listofqualifiedobj=array();
$listofqualifiedref=array();
$thirdpartywithoutemail=array();
@@ -208,7 +209,7 @@ if (! $error && $massaction == 'confirm_presend')
$resaction.='
'.$langs->trans('ErrorOnlyProposalNotDraftCanBeSentInMassAction',$objectobj->ref).'
';
continue; // Payment done or started or canceled
}
- if ($objectclass == 'Commande' && $objectoj->statut == Commande::STATUS_DRAFT)
+ if ($objectclass == 'Commande' && $objectobj->statut == Commande::STATUS_DRAFT)
{
$langs->load("errors");
$nbignored++;
@@ -263,12 +264,12 @@ if (! $error && $massaction == 'confirm_presend')
if (dol_is_file($file))
{
- // Create form object
- $attachedfiles=array(
- 'paths'=>array_merge($attachedfiles['paths'],array($file)),
- 'names'=>array_merge($attachedfiles['names'],array($filename)),
- 'mimes'=>array_merge($attachedfiles['mimes'],array($mime))
- );
+ // Create form object
+ $attachedfilesThirdpartyObj[$thirdpartyid][$objectid]=array(
+ 'paths'=>array($file),
+ 'names'=>array($filename),
+ 'mimes'=>array($mime)
+ );
}
else
{
@@ -333,12 +334,16 @@ if (! $error && $massaction == 'confirm_presend')
if ($objectclass == 'CommandeFournisseur') $sendtobcc .= (empty($conf->global->MAIN_MAIL_AUTOCOPY_SUPPLIER_ORDER_TO) ? '' : (($sendtobcc?", ":"").$conf->global->MAIN_MAIL_AUTOCOPY_SUPPLIER_ORDER_TO));
if ($objectclass == 'FactureFournisseur') $sendtobcc .= (empty($conf->global->MAIN_MAIL_AUTOCOPY_SUPPLIER_INVOICE_TO) ? '' : (($sendtobcc?", ":"").$conf->global->MAIN_MAIL_AUTOCOPY_SUPPLIER_INVOICE_TO));
- // $listofqualifiedobj is array with key = object id of qualified objects for the current thirdparty
- $oneemailperrecipient=(GETPOST('oneemailperrecipient')=='on'?1:0);
+ // $listofqualifiedobj is array with key = object id and value is instance of qualified objects, for the current thirdparty (but thirdparty property is not loaded yet)
+
$looparray=array();
if (! $oneemailperrecipient)
{
$looparray = $listofqualifiedobj;
+ foreach ($looparray as $key => $objecttmp)
+ {
+ $looparray[$key]->thirdparty = $thirdparty;
+ }
}
else
{
@@ -347,8 +352,9 @@ if (! $error && $massaction == 'confirm_presend')
$looparray[0]=$objectforloop;
}
//var_dump($looparray);exit;
-
- foreach ($looparray as $objecttmp) // $objecttmp is a real object or an empty if we choose to send one email per thirdparty instead of per record
+ dol_syslog("We have set an array of ".count($looparray)." emails to send. oneemailperrecipient=".$oneemailperrecipient);
+ //var_dump($oneemailperrecipient); var_dump($listofqualifiedobj); var_dump($listofqualifiedref);
+ foreach ($looparray as $objectid => $objecttmp) // $objecttmp is a real object or an empty object if we choose to send one email per thirdparty instead of one per object
{
// Make substitution in email content
$substitutionarray=getCommonSubstitutionArray($langs, 0, null, $objecttmp);
@@ -358,20 +364,54 @@ if (! $error && $massaction == 'confirm_presend')
$substitutionarray['__CHECK_READ__'] = '
';
$parameters=array('mode'=>'formemail');
+
+ if ( ! empty( $listofobjectthirdparties ) ) {
+ $parameters['listofobjectthirdparties'] = $listofobjectthirdparties;
+ }
+ if ( ! empty( $listofobjectref ) ) {
+ $parameters['listofobjectref'] = $listofobjectref;
+ }
+
complete_substitutions_array($substitutionarray, $langs, $objecttmp, $parameters);
- $subject=make_substitutions($subject, $substitutionarray);
- $message=make_substitutions($message, $substitutionarray);
+ $subjectreplaced=make_substitutions($subject, $substitutionarray);
+ $messagereplaced=make_substitutions($message, $substitutionarray);
+
+
+ $attachedfiles=array('paths'=>array(), 'names'=>array(), 'mimes'=>array());
+ if($oneemailperrecipient)
+ {
+ // if "one email per recipient" isn't check we must collate $attachedfiles by thirdparty
+ if(is_array($attachedfilesThirdpartyObj[$thirdparty->id]) && count($attachedfilesThirdpartyObj[$thirdparty->id]))
+ {
+ foreach ($attachedfilesThirdpartyObj[$thirdparty->id] as $keyObjId => $objAttachedFiles){
+ // Create form object
+ $attachedfiles=array(
+ 'paths'=>array_merge($attachedfiles['paths'], $objAttachedFiles['paths']),
+ 'names'=>array_merge($attachedfiles['names'], $objAttachedFiles['names']),
+ 'mimes'=>array_merge($attachedfiles['mimes'], $objAttachedFiles['mimes'])
+ );
+ }
+ }
+ }
+ elseif(!empty($attachedfilesThirdpartyObj[$thirdparty->id][$objectid])){
+ // Create form object
+ // if "one email per recipient" isn't check we must separate $attachedfiles by object
+ $attachedfiles=$attachedfilesThirdpartyObj[$thirdparty->id][$objectid];
+ }
$filepath = $attachedfiles['paths'];
$filename = $attachedfiles['names'];
$mimetype = $attachedfiles['mimes'];
+
+
+
//var_dump($filepath);
// Send mail (substitutionarray must be done just before this)
- require_once(DOL_DOCUMENT_ROOT.'/core/class/CMailFile.class.php');
- $mailfile = new CMailFile($subject,$sendto,$from,$message,$filepath,$mimetype,$filename,$sendtocc,$sendtobcc,$deliveryreceipt,-1);
+ require_once DOL_DOCUMENT_ROOT.'/core/class/CMailFile.class.php';
+ $mailfile = new CMailFile($subjectreplaced, $sendto, $from, $messagereplaced, $filepath, $mimetype, $filename, $sendtocc, $sendtobcc, $deliveryreceipt, -1);
if ($mailfile->error)
{
$resaction.=''.$mailfile->error.'
';
@@ -386,8 +426,12 @@ if (! $error && $massaction == 'confirm_presend')
$error=0;
// Insert logs into agenda
- foreach($listofqualifiedobj as $objid => $objectobj)
+ foreach($listofqualifiedobj as $objid2 => $objectobj2)
{
+ if ((! $oneemailperrecipient) && $objid2 != $objectid) continue; // We discard this pass to avoid duplicate with other pass in looparray at higher level
+
+ dol_syslog("Try to insert email event into agenda for objid=".$objid2." => objectobj=".get_class($objectobj2));
+
/*if ($objectclass == 'Propale') $actiontypecode='AC_PROP';
if ($objectclass == 'Commande') $actiontypecode='AC_COM';
if ($objectclass == 'Facture') $actiontypecode='AC_FAC';
@@ -399,18 +443,18 @@ if (! $error && $massaction == 'confirm_presend')
if ($message)
{
if ($sendtocc) $actionmsg = dol_concatdesc($actionmsg, $langs->transnoentities('Bcc') . ": " . $sendtocc);
- $actionmsg = dol_concatdesc($actionmsg, $langs->transnoentities('MailTopic') . ": " . $subject);
+ $actionmsg = dol_concatdesc($actionmsg, $langs->transnoentities('MailTopic') . ": " . $subjectreplaced);
$actionmsg = dol_concatdesc($actionmsg, $langs->transnoentities('TextUsedInTheMessageBody') . ":");
- $actionmsg = dol_concatdesc($actionmsg, $message);
+ $actionmsg = dol_concatdesc($actionmsg, $messagereplaced);
}
$actionmsg2='';
// Initialisation donnees
- $objectobj->sendtoid = 0;
- $objectobj->actionmsg = $actionmsg; // Long text
- $objectobj->actionmsg2 = $actionmsg2; // Short text
- $objectobj->fk_element = $objid;
- $objectobj->elementtype = $objectobj->element;
+ $objectobj2->sendtoid = 0;
+ $objectobj2->actionmsg = $actionmsg; // Long text
+ $objectobj2->actionmsg2 = $actionmsg2; // Short text
+ $objectobj2->fk_element = $objid2;
+ $objectobj2->elementtype = $objectobj2->element;
$triggername = strtoupper(get_class($objectobj)) .'_SENTBYMAIL';
if ($triggername == 'SOCIETE_SENTBYMAIL') $triggername = 'COMPANY_SENTBYEMAIL';
@@ -425,9 +469,9 @@ if (! $error && $massaction == 'confirm_presend')
if (! empty($triggername))
{
// Appel des triggers
- include_once(DOL_DOCUMENT_ROOT . "/core/class/interfaces.class.php");
+ include_once DOL_DOCUMENT_ROOT . "/core/class/interfaces.class.php";
$interface=new Interfaces($db);
- $result=$interface->run_triggers($triggername, $objectobj, $user, $langs, $conf);
+ $result=$interface->run_triggers($triggername, $objectobj2, $user, $langs, $conf);
if ($result < 0) { $error++; $errors=$interface->errors; }
// Fin appel triggers
@@ -437,9 +481,9 @@ if (! $error && $massaction == 'confirm_presend')
dol_syslog("Error in trigger ".$triggername.' '.$db->lasterror(), LOG_ERR);
}
}
-
- $nbsent++;
}
+
+ $nbsent++; // Nb of email sent (may be lower than number of record selected if we group thirdparties)
}
else
{
@@ -504,6 +548,8 @@ if ($massaction == 'confirm_createbills')
$objecttmp = new Facture($db);
if (!empty($createbills_onebythird) && !empty($TFactThird[$cmd->socid])) $objecttmp = $TFactThird[$cmd->socid]; // If option "one bill per third" is set, we use already created order.
else {
+ // Load extrafields of order
+ $cmd->fetch_optionals();
$objecttmp->socid = $cmd->socid;
$objecttmp->type = Facture::TYPE_STANDARD;
@@ -521,6 +567,8 @@ if ($massaction == 'confirm_createbills')
$objecttmp->origin = 'commande';
$objecttmp->origin_id = $id_order;
+ $objecttmp->array_options = $cmd->array_options; // Copy extrafields
+
$res = $objecttmp->create($user);
if($res > 0) $nb_bills_created++;
@@ -560,6 +608,12 @@ if ($massaction == 'confirm_createbills')
for ($i=0;$i<$num;$i++)
{
$desc=($lines[$i]->desc?$lines[$i]->desc:$lines[$i]->libelle);
+ // If we build one invoice for several order, we must put the invoice of order on the line
+ if (! empty($createbills_onebythird))
+ {
+ $desc=dol_concatdesc($desc, $langs->trans("Order").' '.$cmd->ref.' - '.dol_print_date($cmd->date, 'day', $langs));
+ }
+
if ($lines[$i]->subprice < 0)
{
// Negative line, we create a discount line
@@ -670,6 +724,7 @@ if ($massaction == 'confirm_createbills')
if (! $error && $validate_invoices)
{
$massaction = $action = 'builddoc';
+
foreach($TAllFact as &$objecttmp)
{
$result = $objecttmp->validate($user);
@@ -687,7 +742,12 @@ if ($massaction == 'confirm_createbills')
$donotredirect = 1;
$upload_dir = $conf->facture->dir_output;
$permissioncreate=$user->rights->facture->creer;
+
+ // Call action to build doc
+ $savobject = $object;
+ $object = $objecttmp;
include DOL_DOCUMENT_ROOT.'/core/actions_builddoc.inc.php';
+ $object = $savobject;
}
$massaction = $action = 'confirm_createbills';
@@ -696,7 +756,7 @@ if ($massaction == 'confirm_createbills')
if (! $error)
{
$db->commit();
- setEventMessage($langs->trans('BillCreated', $nb_bills_created));
+ setEventMessages($langs->trans('BillCreated', $nb_bills_created), null, 'mesgs');
// Make a redirect to avoid to bill twice if we make a refresh or back
$param='';
diff --git a/htdocs/core/class/html.formmail.class.php b/htdocs/core/class/html.formmail.class.php
index 9b9bb32865e..38987b36185 100644
--- a/htdocs/core/class/html.formmail.class.php
+++ b/htdocs/core/class/html.formmail.class.php
@@ -908,7 +908,6 @@ class FormMail extends Form
$defaultmessage=preg_replace("/^(
)+/","",$defaultmessage);
$defaultmessage=preg_replace("/^\n+/","",$defaultmessage);
}
-
$out.= '';
$out.= '| '.$langs->trans("MailText").' | ';
$out.= '';
diff --git a/htdocs/core/lib/functions.lib.php b/htdocs/core/lib/functions.lib.php
index 7a70608f303..05024437a63 100644
--- a/htdocs/core/lib/functions.lib.php
+++ b/htdocs/core/lib/functions.lib.php
@@ -5733,6 +5733,8 @@ function make_substitutions($text, $substitutionarray, $outputlangs=null)
// Make substitition for array $substitutionarray
foreach ($substitutionarray as $key => $value)
{
+ if (! isset($value)) continue; // If value is null, it same than not having substitution key at all into array, we do not replace.
+
if ($key == '__SIGNATURE__' && (! empty($conf->global->MAIN_MAIL_DO_NOT_USE_SIGN))) $value=''; // Protection
if ($key == '__USER_SIGNATURE__' && (! empty($conf->global->MAIN_MAIL_DO_NOT_USE_SIGN))) $value=''; // Protection
diff --git a/htdocs/core/tpl/massactions_pre.tpl.php b/htdocs/core/tpl/massactions_pre.tpl.php
index 48989b2daec..e525bd739a3 100644
--- a/htdocs/core/tpl/massactions_pre.tpl.php
+++ b/htdocs/core/tpl/massactions_pre.tpl.php
@@ -36,11 +36,12 @@ if ($massaction == 'presend')
{
$langs->load("mails");
+ $listofselectedid = array();
+ $listofselectedthirdparties = array();
+ $listofselectedref = array();
+
if (! GETPOST('cancel', 'alpha'))
{
- $listofselectedid = array();
- $listofselectedthirdparties = array();
- $listofselectedref = array();
foreach ($arrayofselected as $toselectid)
{
$result = $objecttmp->fetch($toselectid);
@@ -106,7 +107,8 @@ if ($massaction == 'presend')
$formmail->withtoreadonly = 1;
}
- $formmail->withoptiononeemailperrecipient = empty($liste)?0:((GETPOST('oneemailperrecipient')=='on')?1:-1);
+ $formmail->withoptiononeemailperrecipient = ((count($listofselectedref) == 1 && count(reset($listofselectedref)) == 1) || empty($liste)) ? 0 : ((GETPOST('oneemailperrecipient')=='on')?1:-1);
+
$formmail->withto = empty($liste)?(GETPOST('sendto','alpha')?GETPOST('sendto','alpha'):array()):$liste;
$formmail->withtofree = empty($liste)?1:0;
$formmail->withtocc = 1;
@@ -125,6 +127,7 @@ if ($massaction == 'presend')
// Make substitution in email content
$substitutionarray = getCommonSubstitutionArray($langs, 0, null, $object);
+
$substitutionarray['__EMAIL__'] = $sendto;
$substitutionarray['__CHECK_READ__'] = (is_object($object) && is_object($object->thirdparty)) ? ' ' : '';
$substitutionarray['__PERSONALIZED__'] = ''; // deprecated
|