From 08f99b42724cc1e78364bcb352bfd15810102664 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jean=20Traull=C3=A9?= <jtraulle@opencomp.fr>
Date: Thu, 15 Aug 2019 15:39:49 +0200
Subject: [PATCH] Fix codestyle lessc.class.php should be excluded from ruleset
 as it is an external lib

---
 dev/setup/codesniffer/ruleset.xml | 1 +
 htdocs/core/lib/files.lib.php     | 2 +-
 htdocs/core/lib/website.lib.php   | 4 ++--
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/dev/setup/codesniffer/ruleset.xml b/dev/setup/codesniffer/ruleset.xml
index daf73e5b2a7..89ea98a051b 100644
--- a/dev/setup/codesniffer/ruleset.xml
+++ b/dev/setup/codesniffer/ruleset.xml
@@ -6,6 +6,7 @@
 	<exclude-pattern type="relative">build/html</exclude-pattern>
 	<exclude-pattern type="relative">build/aps</exclude-pattern>
 	<exclude-pattern type="relative">documents</exclude-pattern>
+	<exclude-pattern type="relative">htdocs/core/class/lessc.class.php</exclude-pattern>
 	<exclude-pattern type="relative">htdocs/custom</exclude-pattern>
 	<exclude-pattern type="relative">htdocs/includes</exclude-pattern>
 	<exclude-pattern type="relative">htdocs/install/doctemplates/websites</exclude-pattern>
diff --git a/htdocs/core/lib/files.lib.php b/htdocs/core/lib/files.lib.php
index 79b0badf0ff..a5bbd68a736 100644
--- a/htdocs/core/lib/files.lib.php
+++ b/htdocs/core/lib/files.lib.php
@@ -1911,7 +1911,7 @@ function dol_compress_file($inputfile, $outputfile, $mode = "gz")
 				dol_syslog("Class ZipArchive is set so we zip using ZipArchive to zip into ".$outputfile.' rootPath='.$rootPath);
 				$zip = new ZipArchive;
 
-				if ($zip->open($outputfile, ZipArchive::CREATE)!==TRUE) {
+				if ($zip->open($outputfile, ZipArchive::CREATE)!==true) {
 					$errormsg="Failed to open file ".$outputfile."\n";
 					dol_syslog("dol_compress_file failure - ".$errormsg, LOG_ERR);
 					return -6;
diff --git a/htdocs/core/lib/website.lib.php b/htdocs/core/lib/website.lib.php
index 4696e2adc8f..bc1e08353cb 100644
--- a/htdocs/core/lib/website.lib.php
+++ b/htdocs/core/lib/website.lib.php
@@ -33,7 +33,7 @@
  * @return	boolean							True if OK
  * @see dolWebsiteOutput() for function used to replace content in a web server context
  */
-function dolWebsiteReplacementOfLinks($website, $content, $removephppart = 0, $contenttype='html')
+function dolWebsiteReplacementOfLinks($website, $content, $removephppart = 0, $contenttype = 'html')
 {
 	$nbrep = 0;
 
@@ -191,7 +191,7 @@ function dolKeepOnlyPhpCode($str)
  * @return  void
  * @see	dolWebsiteReplacementOfLinks()  for function used to replace content in the backoffice context.
  */
-function dolWebsiteOutput($content, $contenttype='html', $containerid='')
+function dolWebsiteOutput($content, $contenttype = 'html', $containerid = '')
 {
 	global $db, $langs, $conf, $user;
 	global $dolibarr_main_url_root, $dolibarr_main_data_root;