Removed rule with +99% of false positives
This commit is contained in:
parent
e5b615f484
commit
0b6123328d
2
.github/workflows/exakat.yml
vendored
2
.github/workflows/exakat.yml
vendored
@ -13,5 +13,5 @@ jobs:
|
||||
- name: Exakat
|
||||
uses: docker://exakat/exakat-ga
|
||||
with:
|
||||
ignore_rules: 'Classes/UseInstanceof,Performances/PrePostIncrement,Functions/WrongNumberOfArguments,Variables/UndefinedVariable,Classes/DontUnsetProperties,Classes/NonPpp,Classes/StaticMethodsCalledFromObject,Classes/UseClassOperator,Functions/UsesDefaultArguments,Php/NoClassInGlobal,Php/ShouldUseCoalesce,Structures/MergeIfThen,Structures/ElseIfElseif,Structures/RepeatedPrint,Structures/UselessParenthesis,Structures/SwitchWithoutDefault,Structures/ShouldMakeTernary,Structures/UseConstant'
|
||||
ignore_rules: 'Classes/UseInstanceof,Performances/PrePostIncrement,Functions/UndefinedFunctions,Functions/WrongNumberOfArguments,Variables/UndefinedVariable,Classes/DontUnsetProperties,Classes/NonPpp,Classes/StaticMethodsCalledFromObject,Classes/UseClassOperator,Functions/UsesDefaultArguments,Php/NoClassInGlobal,Php/ShouldUseCoalesce,Php/WrongTypeForNativeFunction,Structures/MergeIfThen,Structures/ElseIfElseif,Structures/RepeatedPrint,Structures/UselessParenthesis,Structures/SwitchWithoutDefault,Structures/ShouldMakeTernary,Structures/UseConstant'
|
||||
ignore_dirs: '/htdocs/includes,/htdocs/build,/htdocs/dev,/htdocs/doc,/htdocs/scripts,/htdocs/test'
|
||||
@ -77,6 +77,11 @@ class InterfaceActionsAuto extends DolibarrTriggers
|
||||
{
|
||||
if (empty($conf->agenda->enabled)) return 0; // Module not active, we do nothing
|
||||
|
||||
// Do not log events when trigger is for creating event (infinite loop)
|
||||
if (preg_match('/^ACTION_/', $action)) {
|
||||
return 0;
|
||||
}
|
||||
|
||||
$key = 'MAIN_AGENDA_ACTIONAUTO_'.$action;
|
||||
//var_dump($action.' - '.$conf->global->$key);exit;
|
||||
|
||||
@ -84,10 +89,6 @@ class InterfaceActionsAuto extends DolibarrTriggers
|
||||
if (empty($conf->global->$key)) {
|
||||
return 0;
|
||||
}
|
||||
// Do not log events when trigger is for creating event (infinite loop)
|
||||
if (preg_match('/^ACTION_/', $action)) {
|
||||
return 0;
|
||||
}
|
||||
|
||||
$langs->load("agenda");
|
||||
|
||||
|
||||
Loading…
Reference in New Issue
Block a user