From 16ad953d102fd9e153a80f7de67c1420b5f5bf16 Mon Sep 17 00:00:00 2001
From: Regis Houssin <regis@dolibarr.fr>
Date: Mon, 17 Sep 2012 08:13:29 +0200
Subject: [PATCH] Fix: best practice

---
 htdocs/core/tpl/admin_extrafields.tpl.php | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/htdocs/core/tpl/admin_extrafields.tpl.php b/htdocs/core/tpl/admin_extrafields.tpl.php
index 9cecc48cc2d..73750892cc2 100644
--- a/htdocs/core/tpl/admin_extrafields.tpl.php
+++ b/htdocs/core/tpl/admin_extrafields.tpl.php
@@ -20,23 +20,20 @@
 <!-- BEGIN PHP TEMPLATE admin_extrafields.tpl.php -->
 <script type="text/javascript">
     jQuery(document).ready(function() {
-    	function init_typeoffields()
+    	function init_typeoffields(type)
     	{
-    		var type = jQuery("#type").val();
     		var size = jQuery("#size");
-
     		if (type == 'date') { size.val('').attr('disabled','disabled'); }
     		else if (type == 'datetime') { size.val('').attr('disabled','disabled'); }
     		else if (type == 'double') { size.val('24,8').removeAttr('disabled'); }
     		else if (type == 'int') { size.val('10').removeAttr('disabled'); }
     		else if (type == 'text') { size.val('2000').removeAttr('disabled'); }
     		else if (type == 'varchar') { size.val('255').removeAttr('disabled'); }
-    		else if (type == '') { size.val('').attr('disabled','disabled'); }
-    		else size.attr('disabled','disabled');
+    		else size.val('').attr('disabled','disabled');
     	}
     	init_typeoffields();
     	jQuery("#type").change(function() {
-    		init_typeoffields();
+    		init_typeoffields($(this).val());
     	});
     });
 </script>