lainwir3d/dolibarr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

FIX #22964 #23012

Browse Source
This commit is contained in:
Laurent Destailleur 2023-01-26 02:06:40 +01:00
parent c2b9f05fe8
commit 1a4cb5b4e2
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
htdocs/core/class/commonobject.class.php
View File

@ -1207,7 +1207,7 @@ abstract class CommonObject
// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
/** /**
* Delete all links between an object $this and all its contacts * Delete all links between an object $this and all its contacts in llx_element_contact
* *
* @param string $source '' or 'internal' or 'external' * @param string $source '' or 'internal' or 'external'
* @param string $code Type of contact (code or id) * @param string $code Type of contact (code or id)
@ -1224,12 +1224,16 @@ abstract class CommonObject
} }
$listId = implode(",", $temp); $listId = implode(",", $temp);
$sql = "DELETE FROM ".MAIN_DB_PREFIX."element_contact"; // If $listId is empty, we have not criteria on fk_c_type_contact so we will delete record on element_id for
$sql .= " WHERE element_id = ".((int) $this->id); // any type or record instead of only the ones of the current object. So we do nothing in such a case.
if ($listId) { if (empty($listId)) {
$sql .= " AND fk_c_type_contact IN (".$this->db->sanitize($listId).")"; return 0;
} }
$sql = "DELETE FROM ".$this->db->prefix()."element_contact";
$sql .= " WHERE element_id = ".((int) $this->id);
$sql .= " AND fk_c_type_contact IN (".$this->db->sanitize($listId).")";
dol_syslog(get_class($this)."::delete_linked_contact", LOG_DEBUG); dol_syslog(get_class($this)."::delete_linked_contact", LOG_DEBUG);
if ($this->db->query($sql)) { if ($this->db->query($sql)) {
return 1; return 1;