Update api_invoices.class.php

This commit is contained in:
Laurent Destailleur 2017-10-07 13:28:04 +02:00 committed by GitHub
parent 925a86b2ba
commit 1b399dc8dd

View File

@ -310,9 +310,9 @@ class Invoices extends DolibarrApi
* Deletes a line of a given invoice * Deletes a line of a given invoice
* *
* @param int $id Id of invoice * @param int $id Id of invoice
* @param int $rowid Id of the line to delete * @param int $lineid Id of the line to delete
* *
* @url DELETE {id}/deleteline * @url DELETE {id}/deleteline/{lineid}
* *
* @return array * @return array
* @throws 304 * @throws 304
@ -320,13 +320,17 @@ class Invoices extends DolibarrApi
* @throws 401 * @throws 401
* @throws 404 * @throws 404
*/ */
function deleteLine($id, $rowid) { function deleteLine($id, $lineid) {
if(! DolibarrApiAccess::$user->rights->facture->creer) { if(! DolibarrApiAccess::$user->rights->facture->creer) {
throw new RestException(401); throw new RestException(401);
} }
if(empty($rowid)) { if(empty($lineid)) {
throw new RestException(400, 'RowID is mandatory'); throw new RestException(400, 'Line ID is mandatory');
}
if( ! DolibarrApi::_checkAccessToResource('facture',$id)) {
throw new RestException(401, 'Access not allowed for login '.DolibarrApiAccess::$user->login);
} }
$result = $this->invoice->fetch($id); $result = $this->invoice->fetch($id);
@ -334,17 +338,13 @@ class Invoices extends DolibarrApi
throw new RestException(404, 'Invoice not found'); throw new RestException(404, 'Invoice not found');
} }
$result = $this->invoice->deleteline($lineid);
$result = $this->invoice->deleteline($rowid);
if( $result < 0) { if( $result < 0) {
throw new RestException(304); throw new RestException(304);
} }
$result = $this->invoice->fetch($id); $result = $this->invoice->fetch($id);
if( ! DolibarrApi::_checkAccessToResource('facture',$this->invoice->id)) {
throw new RestException(401, 'Access not allowed for login '.DolibarrApiAccess::$user->login);
}
$this->invoice->getLinesArray(); $this->invoice->getLinesArray();
$result = array(); $result = array();
foreach ($this->invoice->lines as $line) { foreach ($this->invoice->lines as $line) {