From 213c23275ce01cee6a3a837136065623d8d3edbb Mon Sep 17 00:00:00 2001
From: Lamrani Abdel <lamrani002@gmail.com>
Date: Thu, 10 Nov 2022 12:15:06 +0100
Subject: [PATCH] Fix issue scrutinizer change varible modepaimentid by
 modepaymentid and ->modepayement by

---
 htdocs/core/modules/dons/html_cerfafr.modules.php | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/htdocs/core/modules/dons/html_cerfafr.modules.php b/htdocs/core/modules/dons/html_cerfafr.modules.php
index 792c8434ba4..83c2504be3d 100644
--- a/htdocs/core/modules/dons/html_cerfafr.modules.php
+++ b/htdocs/core/modules/dons/html_cerfafr.modules.php
@@ -120,18 +120,18 @@ class html_cerfafr extends ModeleDon
 
 				// This is not the proper way to do it but $formclass->form_modes_reglement
 				// prints the translation instead of returning it
-				if ($don->modepaiementid) {
-					$formclass->load_cache_types_paiements();
-					$paymentmode = $formclass->cache_types_paiements[$don->modepaiementid]['label'];
+				$formclass->load_cache_types_paiements();
+				if ($don->modepaymentid) {
+					$paymentmode = $formclass->cache_types_paiements[$don->modepaymentid]['label'];
 				} else {
 					$paymentmode = '';
 				}
-
-				if ($don->modepaymentcode == 'CHQ') {
+				$modepaymentcode = $formclass->cache_types_paiements[$don->modepaymentid]['code'];
+				if ($modepaymentcode == 'CHQ') {
 					$ModePaiement = '<td width="25%"><input type="checkbox"> Remise d\'espèces</td><td width="25%"><input type="checkbox" disabled="true" checked="checked"> Chèque</td><td width="50%"><input type="checkbox"> Virement, prélèvement, carte bancaire</td>';
-				} elseif ($don->modepaymentcode == 'LIQ') {
+				} elseif ($modepaymentcode == 'LIQ') {
 					$ModePaiement = '<td width="25%"><input type="checkbox" checked="checked"> Remise d\'espèces</td><td width="25%"><input type="checkbox"> Chèque</td><td width="50%"><input type="checkbox"> Virement, prélèvement, carte bancaire</td>';
-				} elseif ($don->modepaymentcode == 'VIR' || $don->modepaymentcode == 'PRE' || $don->modepaymentcode == 'CB') {
+				} elseif ($modepaymentcode == 'VIR' || $modepaymentcode == 'PRE' || $modepaymentcode == 'CB') {
 					$ModePaiement = '<td width="25%"><input type="checkbox"> Remise d\'espèces</td><td width="25%"><input type="checkbox"> Chèque</td><td width="50%"><input type="checkbox" checked="checked"> Virement, prélèvement, carte bancaire</td>';
 				} else {
 					$ModePaiement = '<td width="25%"><input type="checkbox"> Remise d\'espèces</td><td width="25%"><input type="checkbox"> Chèque</td><td width="50%"><input type="checkbox"> Virement, prélèvement, carte bancaire</td>';