lainwir3d/dolibarr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update mod_barcode_product_standard.php

Browse Source 
Fix #15633: Product creation: EAN13 barcode automatic generation incompatible with EAN13 existing barcode scanning, unusable function.
#15918 
ok with @eldy
Avoid  sql call if no joker at the end of mask
Treat EAN13 in a more evolutive code form to prepare needs for other barcodes with key
This commit is contained in:
zuiko 2021-01-19 11:40:53 +01:00 committed by GitHub
parent 432d45b289
commit 21fac1ff7a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 18 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
htdocs/core/modules/barcode/mod_barcode_product_standard.php
View File

@ -206,23 +206,28 @@ class mod_barcode_product_standard extends ModeleNumRefBarCode
$now = dol_now(); $now = dol_now();
$numFinal = get_next_value($db, $mask, 'product', $field, $where, '', $now); $numFinal = get_next_value($db, $mask, 'product', $field, $where, '', $now);
//if EAN13 calculate and substitute the last 13th character (* or ?) used in the mask by the EAN13 key //Begin barcode with key: for barcode with key (EAN13...) calculate and substitute the last character (* or ?) used in the mask by the key
if ((substr($numFinal, -1)=='*') or (substr($numFinal, -1)=='?')) // if last mask character is * or ? a joker, probably we have to calculate a key as last character (EAN13...)
{
$literaltype = ''; $literaltype = '';
$literaltype = $this->literalBarcodeType($db,$type);//get literal_Barcode_Type $literaltype = $this->literalBarcodeType($db,$type);//get literal_Barcode_Type
if ($literaltype=='EAN13') //EAN13 rowid = 2 switch ($literaltype)
{ {
if (strlen($numFinal)==13) case 'EAN13': //EAN13 rowid = 2
{ if (strlen($numFinal)==13)// be sure that the mask length is correct for EAN13
if ((substr($numFinal, -1)=='*') or (substr($numFinal, -1)=='?')) // if last mask character is * or ?
{ {
$ean = substr($numFinal, 0, 12); //take first 12 digits $ean = substr($numFinal, 0, 12); //take first 12 digits
$eansum = barcode_gen_ean_sum($ean); $eansum = barcode_gen_ean_sum($ean);
$ean .= $eansum; //substitute the last character by the key $ean .= $eansum; //substitute the las character by the key
$numFinal = $ean; $numFinal = $ean;
} }
break;
// Other barcode cases with key could be written here
default:
break;
} }
} }
//EAN13 end //End barcode with key
return $numFinal; return $numFinal;
} }