Fix unset gender property in contact class

This commit is contained in:
Tobias Sekan 2020-02-04 09:00:31 +01:00 committed by GitHub
parent 22824026ef
commit 24c305dc7f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -992,19 +992,25 @@ class Contact extends CommonObject
}
/**
* Set property ->gender from property ->civility_id
* Set the property "gender" of this class, based on the property "civility_id"
* or use property "civility_code" as fallback, when "civility_id" is not available.
*
* @return void
*/
public function setGenderFromCivility()
{
unset($this->gender);
if (in_array($this->civility_id, array('MR'))) {
$this->gender = 'man';
} elseif (in_array($this->civility_id, array('MME', 'MLE'))) {
$this->gender = 'woman';
}
unset($this->gender);
if (in_array($this->civility_id, array('MR')) || in_array($this->civility_code, array('MR')))
{
$this->gender = 'man';
}
elseif(in_array($this->civility_id, array('MME','MLE')) || in_array($this->civility_code, array('MME','MLE')))
{
$this->gender = 'woman';
}
}
// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps