From 267ef1986d469c4219f720e13d672c08d42c5a3e Mon Sep 17 00:00:00 2001
From: Laurent Destailleur <eldy@destailleur.fr>
Date: Thu, 16 Feb 2023 04:25:11 +0100
Subject: [PATCH] Return better message when decrypt key is empty

---
 htdocs/core/lib/security.lib.php | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/htdocs/core/lib/security.lib.php b/htdocs/core/lib/security.lib.php
index 63bba22796c..dcead2541bd 100644
--- a/htdocs/core/lib/security.lib.php
+++ b/htdocs/core/lib/security.lib.php
@@ -179,6 +179,9 @@ function dolDecrypt($chain, $key = '')
 	if (preg_match('/^dolcrypt:([^:]+):(.+)$/', $chain, $reg)) {
 		$ciphering = $reg[1];
 		if (function_exists('openssl_decrypt')) {
+			if (empty($key)) {
+				return 'Error dolDecrypt decrypt key is empty';
+			}
 			$tmpexplode = explode(':', $reg[2]);
 			if (!empty($tmpexplode[1]) && is_string($tmpexplode[0])) {
 				$newchain = openssl_decrypt($tmpexplode[1], $ciphering, $key, 0, $tmpexplode[0]);
@@ -186,7 +189,7 @@ function dolDecrypt($chain, $key = '')
 				$newchain = openssl_decrypt($tmpexplode[0], $ciphering, $key, 0, null);
 			}
 		} else {
-			$newchain = 'Error function openssl_decrypt() not available';
+			$newchain = 'Error dolDecrypt function openssl_decrypt() not available';
 		}
 		return $newchain;
 	} else {