From 1f91a763ff0b8995b1a3b1fe4d761a341cf9ab44 Mon Sep 17 00:00:00 2001 From: BENKE Charlene <1179011+defrance@users.noreply.github.com> Date: Sat, 1 Dec 2018 11:44:46 +0100 Subject: [PATCH] scrutinizer major error correction It seems like $tasksarray can also be of type string. However, the property $lines is declared as type array>. Maybe add an additional type check? --- .../core/modules/project/doc/pdf_beluga.modules.php | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/htdocs/core/modules/project/doc/pdf_beluga.modules.php b/htdocs/core/modules/project/doc/pdf_beluga.modules.php index 40ae5097d2f..1120046702f 100644 --- a/htdocs/core/modules/project/doc/pdf_beluga.modules.php +++ b/htdocs/core/modules/project/doc/pdf_beluga.modules.php @@ -1,7 +1,7 @@ - * Copyright (C) 2015 Charlie Benke - * Copyright (C) 2018 Laurent Destailleur +/* Copyright (C) 2010-2012 Regis Houssin + * Copyright (C) 2015-2018 Charlene Benke + * Copyright (C) 2018 Laurent Destailleur * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -191,10 +191,11 @@ class pdf_beluga extends ModelePDFProjects // Complete object by loading several other informations $task = new Task($this->db); - $tasksarray = $task->getTasksArray(0,0,$object->id); + $tasksarray = array(); + $tasksarray = $task->getTasksArray(0, 0, $object->id); - if (! $object->id > 0) // Special case when used with object = specimen, we may return all lines - { + // Special case when used with object = specimen, we may return all lines + if (! $object->id > 0) { $tasksarray=array_slice($tasksarray, 0, min(5, count($tasksarray))); }