diff --git a/.project b/.project index 02fcef8deec..4e829deb2dc 100644 --- a/.project +++ b/.project @@ -20,8 +20,14 @@ + + net.sf.eclipsecs.core.CheckstyleBuilder + + + org.eclipse.php.core.PHPNature + net.sf.eclipsecs.core.CheckstyleNature diff --git a/.settings/org.eclipse.php.debug.core.Debug_Process_Preferences.prefs b/.settings/org.eclipse.php.debug.core.Debug_Process_Preferences.prefs index e5e4b5c90b5..26dd722c195 100644 --- a/.settings/org.eclipse.php.debug.core.Debug_Process_Preferences.prefs +++ b/.settings/org.eclipse.php.debug.core.Debug_Process_Preferences.prefs @@ -1,8 +1,8 @@ -#Thu Jun 24 20:12:23 CEST 2010 +#Wed Jul 21 18:10:37 CEST 2010 eclipse.preferences.version=1 org.eclipse.php.debug.core.use-project-settings=true -org.eclipse.php.debug.coredefaultPHP=PHP Wamp 5.2.8 -org.eclipse.php.debug.coreoutput_encoding= +org.eclipse.php.debug.coredefaultPHP=PHP Wamp 5.3.0 +org.eclipse.php.debug.coreoutput_encoding=UTF-8 org.eclipse.php.debug.corephp_debugger_id=org.eclipse.php.debug.core.xdebugDebugger org.eclipse.php.debug.corestop_at_first_line_string=true -org.eclipse.php.debug.coretransfer_encoding= +org.eclipse.php.debug.coretransfer_encoding=UTF-8 diff --git a/dev/phpcheckstyle/README b/dev/phpcheckstyle/README index 8a89afa2321..84c6b1bbdc8 100644 --- a/dev/phpcheckstyle/README +++ b/dev/phpcheckstyle/README @@ -13,4 +13,9 @@ Set path ro run.php file for localhost Choose a PHP version, Set parameter string with --src %f --config "phpstandard.cfg.xml" --format console -Choose php as Filename extension \ No newline at end of file +Choose php as Filename extension +Check Print PHP output to console +Then add patern + * %f INFO Line:%n - %m Warning + * %f WARNING Line:%n - %m Warning + * %f ERROR Line:%n - %m Error \ No newline at end of file diff --git a/dev/phpcheckstyle/phpstandard.cfg.xml b/dev/phpcheckstyle/phpstandard.cfg.xml index 6301e1393fd..b185d6dcffe 100644 --- a/dev/phpcheckstyle/phpstandard.cfg.xml +++ b/dev/phpcheckstyle/phpstandard.cfg.xml @@ -1,18 +1,20 @@ - + + - + @@ -28,7 +30,7 @@ - + @@ -37,7 +39,7 @@ - + @@ -47,7 +49,7 @@ - + @@ -72,7 +74,7 @@ - + @@ -82,18 +84,16 @@ - - - - + + + - - + + @@ -108,27 +108,34 @@ - + + + - + --> + + - + + - + --> + + + @@ -150,8 +157,8 @@ --> - - + + @@ -168,50 +175,50 @@ - - - - - - - - - - - - - + + + + + + + + + + + + + - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + - - - + + + @@ -231,7 +238,7 @@ - + @@ -264,7 +271,7 @@ With the exception of for iterators, all variable incrementation or decrementation should occur in their own toplevel statement to increase readability. --> - + - + diff --git a/htdocs/compta/export/class/ComptaJournalPaiement.class.php b/htdocs/compta/export/class/ComptaJournalPaiement.class.php index 73cd06dcabf..2d64093a08c 100644 --- a/htdocs/compta/export/class/ComptaJournalPaiement.class.php +++ b/htdocs/compta/export/class/ComptaJournalPaiement.class.php @@ -20,7 +20,7 @@ */ /** - * \file htdocs/compta/export/class/ComptaJournalPaiement.php + * \file htdocs/compta/export/class/ComptaJournalPaiement.class.php * \ingroup compta * \brief Fichier de la classe export compta journal * \version $Id$ @@ -40,7 +40,7 @@ class ComptaJournalPaiement $this->db = $db; } - function GeneratePdf($user, $dir, $excid, $excref) + function generatePdf($user, $dir, $excid, $excref) { global $conf,$langs; diff --git a/htdocs/compta/export/class/ComptaJournalPdf.class.php b/htdocs/compta/export/class/ComptaJournalPdf.class.php index c7bd4b29a8e..de7ef82e784 100644 --- a/htdocs/compta/export/class/ComptaJournalPdf.class.php +++ b/htdocs/compta/export/class/ComptaJournalPdf.class.php @@ -18,7 +18,7 @@ */ /** - * \file htdocs/compta/export/class/ComptaJournalPdf.php + * \file htdocs/compta/export/class/ComptaJournalPdf.class.php * \ingroup compta * \brief Fichier de la classe export compta journal * \version $Id$ diff --git a/htdocs/compta/export/class/ComptaJournalVente.class.php b/htdocs/compta/export/class/ComptaJournalVente.class.php index 627c89261d2..3da1ec4fd69 100644 --- a/htdocs/compta/export/class/ComptaJournalVente.class.php +++ b/htdocs/compta/export/class/ComptaJournalVente.class.php @@ -19,7 +19,7 @@ */ /** - \file htdocs/compta/export/classComptaJournalVente.php + \file htdocs/compta/export/class/ComptaJournalVente.class.php \ingroup compta \brief Fichier de la classe export compta journal \version $Id$ @@ -40,7 +40,7 @@ class ComptaJournalVente { } - function GeneratePdf($user, $dir, $excid, $excref) + function generatePdf($user, $dir, $excid, $excref) { global $conf, $langs; diff --git a/htdocs/compta/export/index.php b/htdocs/compta/export/index.php index 28d1d37eced..94ab0a1d76d 100644 --- a/htdocs/compta/export/index.php +++ b/htdocs/compta/export/index.php @@ -72,12 +72,12 @@ if ($_GET["action"] == 'export') /* G�n�ration du journal des Paiements */ $jp= new ComptaJournalPaiement($db); - $jp->GeneratePdf($user, $dir, $exc->id, $exc->ref); + $jp->generatePdf($user, $dir, $exc->id, $exc->ref); /* G�n�ration du journal des Ventes */ $jp= new ComptaJournalVente($db); - $jp->GeneratePdf($user, $dir, $exc->id, $exc->ref); + $jp->generatePdf($user, $dir, $exc->id, $exc->ref); } /* diff --git a/htdocs/compta/paiement/cheque/class/remisecheque.class.php b/htdocs/compta/paiement/cheque/class/remisecheque.class.php index bab7f5d3591..ecb005f5b5f 100644 --- a/htdocs/compta/paiement/cheque/class/remisecheque.class.php +++ b/htdocs/compta/paiement/cheque/class/remisecheque.class.php @@ -62,7 +62,7 @@ class RemiseCheque extends CommonObject * \param ref Ref record * \return int <0 if KO, >= 0 if OK */ - function Fetch($id,$ref='') + function fetch($id,$ref='') { global $conf; @@ -117,7 +117,7 @@ class RemiseCheque extends CommonObject * \param account_id Compte bancaire concerne * \return int <0 if KO, >0 if OK */ - function Create($user, $account_id) + function create($user, $account_id) { global $conf; @@ -220,7 +220,7 @@ class RemiseCheque extends CommonObject if ($this->id > 0 && $this->errno == 0) { - if ($this->UpdateAmount() <> 0) + if ($this->updateAmount() <> 0) { $this->errno = -1027; dol_syslog("RemiseCheque::Create ERREUR ($this->errno)"); @@ -254,7 +254,7 @@ class RemiseCheque extends CommonObject \brief Supprime la remise en base \param user utilisateur qui effectue l'operation */ - function Delete($user='') + function delete($user='') { global $conf; @@ -308,7 +308,7 @@ class RemiseCheque extends CommonObject * \brief Validate receipt * \param user User */ - function Validate($user) + function validate($user) { global $langs,$conf; @@ -530,7 +530,7 @@ class RemiseCheque extends CommonObject * \brief Mets a jour le montant total * \return int, 0 en cas de succes */ - function UpdateAmount() + function updateAmount() { global $conf; @@ -563,13 +563,13 @@ class RemiseCheque extends CommonObject if (!$resql) { $this->errno = -1030; - dol_syslog("RemiseCheque::UpdateAmount ERREUR UPDATE ($this->errno)"); + dol_syslog("RemiseCheque::updateAmount ERREUR UPDATE ($this->errno)"); } } else { $this->errno = -1031; - dol_syslog("RemiseCheque::UpdateAmount ERREUR SELECT ($this->errno)"); + dol_syslog("RemiseCheque::updateAmount ERREUR SELECT ($this->errno)"); } if ($this->errno === 0) @@ -579,7 +579,7 @@ class RemiseCheque extends CommonObject else { $this->db->rollback(); - dol_syslog("RemiseCheque::UpdateAmount ROLLBACK ($this->errno)"); + dol_syslog("RemiseCheque::updateAmount ROLLBACK ($this->errno)"); } return $this->errno; @@ -590,7 +590,7 @@ class RemiseCheque extends CommonObject \param user utilisateur qui effectue l'operation \param account_id Compte bancaire concerne */ - function RemoveCheck($account_id) + function removeCheck($account_id) { $this->errno = 0; @@ -604,12 +604,12 @@ class RemiseCheque extends CommonObject $resql = $this->db->query($sql); if ($resql) { - $this->UpdateAmount(); + $this->updateAmount(); } else { $this->errno = -1032; - dol_syslog("RemiseCheque::RemoveCheck ERREUR UPDATE ($this->errno)"); + dol_syslog("RemiseCheque::removeCheck ERREUR UPDATE ($this->errno)"); } } return 0; diff --git a/htdocs/compta/paiement/cheque/fiche.php b/htdocs/compta/paiement/cheque/fiche.php index 3c77fe8d3e1..9d7e5ca30c7 100644 --- a/htdocs/compta/paiement/cheque/fiche.php +++ b/htdocs/compta/paiement/cheque/fiche.php @@ -111,7 +111,7 @@ if ($_REQUEST['action'] == 'confirm_delete' && $_REQUEST['confirm'] == 'yes' && if ($_REQUEST['action'] == 'confirm_valide' && $_REQUEST['confirm'] == 'yes' && $user->rights->banque->cheque) { $remisecheque = new RemiseCheque($db); - $result = $remisecheque->Fetch($_GET["id"]); + $result = $remisecheque->fetch($_GET["id"]); $result = $remisecheque->Validate($user); if ($result >= 0) { @@ -127,7 +127,7 @@ if ($_REQUEST['action'] == 'confirm_valide' && $_REQUEST['confirm'] == 'yes' && if ($_POST['action'] == 'builddoc' && $user->rights->banque->cheque) { $remisecheque = new RemiseCheque($db); - $result = $remisecheque->Fetch($_GET["id"]); + $result = $remisecheque->fetch($_GET["id"]); /*if ($_REQUEST['model']) { @@ -141,7 +141,7 @@ if ($_POST['action'] == 'builddoc' && $user->rights->banque->cheque) $outputlangs->setDefaultLang($_REQUEST['lang_id']); } - $result = $remisecheque->GeneratePdf($_POST["model"], $outputlangs); + $result = $remisecheque->generatePdf($_POST["model"], $outputlangs); if ($result <= 0) { dol_print_error($db,$remisecheque->error); diff --git a/htdocs/compta/prelevement/fiche.php b/htdocs/compta/prelevement/fiche.php index 98246733baa..05c0f727723 100644 --- a/htdocs/compta/prelevement/fiche.php +++ b/htdocs/compta/prelevement/fiche.php @@ -84,7 +84,7 @@ if ($_POST["action"] == 'infotrans') if ($_POST["action"] == 'infocredit') { $bon = new BonPrelevement($db,""); - $bon->Fetch($_GET["id"]); + $bon->fetch($_GET["id"]); $dt = mktime(12,0,0,$_POST["remonth"],$_POST["reday"],$_POST["reyear"]); $error = $bon->set_infocredit($user, $dt);