diff --git a/htdocs/admin/system/modules.php b/htdocs/admin/system/modules.php
index 7181b35f858..1b482e13238 100644
--- a/htdocs/admin/system/modules.php
+++ b/htdocs/admin/system/modules.php
@@ -25,8 +25,9 @@
require '../../main.inc.php';
require_once DOL_DOCUMENT_ROOT.'/core/lib/functions2.lib.php';
-if (!$user->admin)
+if (!$user->admin) {
accessforbidden();
+}
// Load translation files required by the page
$langs->loadLangs(array("install", "other", "admin"));
@@ -68,8 +69,7 @@ $parameters = array();
$reshook = $hookmanager->executeHooks('doActions', $parameters, $object, $action); // Note that $action and $object may have been modified by some hooks
if ($reshook < 0) setEventMessages($hookmanager->error, $hookmanager->errors, 'errors');
-if (empty($reshook))
-{
+if (empty($reshook)) {
// Selection of new fields
include DOL_DOCUMENT_ROOT.'/core/actions_changeselectedfields.inc.php';
}
@@ -83,30 +83,23 @@ $modules_fullpath = array();
$modulesdir = dolGetModulesDirs();
$rights_ids = array();
-foreach ($modulesdir as $dir)
-{
+foreach ($modulesdir as $dir) {
$handle = @opendir(dol_osencode($dir));
- if (is_resource($handle))
- {
- while (($file = readdir($handle)) !== false)
- {
- if (is_readable($dir.$file) && substr($file, 0, 3) == 'mod' && substr($file, dol_strlen($file) - 10) == '.class.php')
- {
+ if (is_resource($handle)) {
+ while (($file = readdir($handle)) !== false) {
+ if (is_readable($dir.$file) && substr($file, 0, 3) == 'mod' && substr($file, dol_strlen($file) - 10) == '.class.php') {
$modName = substr($file, 0, dol_strlen($file) - 10);
- if ($modName)
- {
+ if ($modName) {
//print 'xx'.$dir.$file.'
';
- if (in_array($file, $modules_files))
- {
+ if (in_array($file, $modules_files)) {
// File duplicate
print "Warning duplicate file found : ".$file." (Found ".$dir.$file.", already found ".$modules_fullpath[$file].")
";
}
else {
// File to load
$res = include_once $dir.$file;
- if (class_exists($modName))
- {
+ if (class_exists($modName)) {
try {
$objMod = new $modName($db);
@@ -114,8 +107,7 @@ foreach ($modulesdir as $dir)
$modules_files[$objMod->numero] = $file;
$modules_fullpath[$file] = $dir.$file;
}
- catch (Exception $e)
- {
+ catch (Exception $e) {
dol_syslog("Failed to load ".$dir.$file." ".$e->getMessage(), LOG_ERR);
}
}
@@ -131,8 +123,7 @@ foreach ($modulesdir as $dir)
}
// create pre-filtered list for modules
-foreach ($modules as $key=>$module)
-{
+foreach ($modules as $key=>$module) {
$newModule = new stdClass();
$newModule->name = $module->getName();
@@ -141,8 +132,7 @@ foreach ($modules as $key=>$module)
$alt = $module->name.' - '.$modules_files[$key];
- if (!empty($module->picto))
- {
+ if (!empty($module->picto)) {
if (preg_match('/^\//', $module->picto)) $newModule->picto = img_picto($alt, $module->picto, 'width="14px"', 1);
else $newModule->picto = img_object($alt, $module->picto, 'width="14px"');
}
@@ -151,12 +141,9 @@ foreach ($modules as $key=>$module)
}
$permission = array();
- if ($module->rights)
- {
- foreach ($module->rights as $rights)
- {
- if (empty($rights[0]))
- {
+ if ($module->rights) {
+ foreach ($module->rights as $rights) {
+ if (empty($rights[0])) {
continue;
}
@@ -173,14 +160,11 @@ foreach ($modules as $key=>$module)
if ($search_version && !stristr($newModule->version, $search_version)) continue;
if ($search_id && !stristr($newModule->id, $search_id)) continue;
- if ($search_permission)
- {
+ if ($search_permission) {
$found = false;
- foreach ($newModule->permission as $permission)
- {
- if (stristr($permission, $search_permission))
- {
+ foreach ($newModule->permission as $permission) {
+ if (stristr($permission, $search_permission)) {
$found = true;
break;
}
@@ -224,26 +208,22 @@ print '
| '; print ''; print ' | '; } -if ($arrayfields['version']['checked']) -{ +if ($arrayfields['version']['checked']) { print ''; print ''; print ' | '; } -if ($arrayfields['id']['checked']) -{ +if ($arrayfields['id']['checked']) { print ''; print ''; print ' | '; } -if ($arrayfields['permission']['checked']) -{ +if ($arrayfields['permission']['checked']) { print ''; print ''; print ' | '; @@ -258,20 +238,16 @@ print '
| '; print $module->picto; print ' '.$module->name; print " | "; } - if ($arrayfields['version']['checked']) - { + if ($arrayfields['version']['checked']) { print ''.$module->version.' | '; } - if ($arrayfields['id']['checked']) - { + if ($arrayfields['id']['checked']) { print ''.$module->id.' | '; } - if ($arrayfields['permission']['checked']) - { + if ($arrayfields['permission']['checked']) { $idperms = ''; - foreach ($module->permission as $permission) - { - $idperms .= ($idperms ? ", " : "").$permission; + foreach ($module->permission as $permission) { + $idperms .= ($idperms ? ", " : "").$permission; $translationKey = "Permission".$permission; - if (empty($langs->tab_translate[$translationKey])) - { + + if (empty($langs->tab_translate[$translationKey])) { $tooltip = 'Missing translation (key '.$translation.' not found in admin.lang)'; $idperms .= '