Updated is_ip comment and added a test for is_ip function

htdocs/core/lib/functions2.lib.php

@@ -1365,9 +1365,7 @@ function getListOfModels($db,$type,$maxfilenamelength=0)
  * This function evaluates a string that should be a valid IPv4
  *
  * @param	string $ip IP Address
- * @return	It returns 0 if $ip is not a valid IPv4
+ * @return	int 0 if not valid, 1 if valid and public IP, 2 if valid and private range IP
- * 			It returns 1 if $ip is a valid IPv4 and is a public IP
- * 			It returns 2 if $ip is a valid IPv4 and is a private lan IP
  */
 function is_ip($ip)
 {

test/phpunit/Functions2LibTest.php

@@ -154,4 +154,23 @@ class Functions2LibTest extends PHPUnit_Framework_TestCase
     	$this->assertEquals(0,$result);
     }
 
+	/**
+	 * is_ip
+	 *
+	 * @return void
+	 */
+	public function testIsIp() {
+
+		//Test not valid IP
+		$result = is_ip('192.168.1.267');
+		$this->assertEquals(0, $result);
+
+		//Test private range IP
+		$result = is_ip('192.168.1.1');
+		$this->assertEquals(2, $result);
+
+		//Test public range IP
+		$result = is_ip('91.121.33.228');
+		$this->assertEquals(1, $result);
+	}
 }