FIX: propal list: bad error management for set not ssigned mass action

This commit is contained in:
Marc de Lima Lucio 2022-03-22 10:54:04 +01:00
parent cf64fc288d
commit 3aae8cc3bb

View File

@ -405,27 +405,28 @@ if ($action == "sign" && $permissiontoclose) {
} }
} }
} }
if ($action == "nosign" && $permissiontoclose) { if ($action == "nosign" && $permissiontoclose) {
if (GETPOST('confirm') == 'yes') { if (GETPOST('confirm') == 'yes') {
$tmpproposal = new Propal($db); $tmpproposal = new Propal($db);
$db->begin(); $db->begin();
$error = 0; $error = 0;
foreach ($toselect as $checked) { foreach ($toselect as $checked) {
if ($tmpproposal->fetch($checked)) { if ($tmpproposal->fetch($checked) > 0) {
if ($tmpproposal->statut == $tmpproposal::STATUS_VALIDATED) { if ($tmpproposal->statut == $tmpproposal::STATUS_VALIDATED) {
$tmpproposal->statut = $tmpproposal::STATUS_NOTSIGNED; $tmpproposal->statut = $tmpproposal::STATUS_NOTSIGNED;
if ($tmpproposal->closeProposal($user, $tmpproposal::STATUS_NOTSIGNED)) { if ($tmpproposal->closeProposal($user, $tmpproposal::STATUS_NOTSIGNED) > 0) {
setEventMessage($tmpproposal->ref." ".$langs->trans('NoSigned'), 'mesgs'); setEventMessage($tmpproposal->ref." ".$langs->trans('NoSigned'), 'mesgs');
} else { } else {
dol_print_error($db); setEventMessages($tmpproposal->error, $tmpproposal->errors, 'errors');
$error++; $error++;
} }
} else { } else {
setEventMessage($tmpproposal->ref." ".$langs->trans('CantBeClosed'), 'errors'); setEventMessage($tmpproposal->ref." ".$langs->trans('CantBeNoSign'), 'errors');
$error++; $error++;
} }
} else { } else {
dol_print_error($db); setEventMessages($tmpproposal->error, $tmpproposal->errors, 'errors');
$error++; $error++;
} }
} }