lainwir3d/dolibarr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix security hole

Browse Source
This commit is contained in:
Laurent Destailleur 2015-09-13 22:50:08 +02:00
parent 4eedec0274
commit 3b01b8cb47
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
htdocs/filefunc.inc.php
View File

@ -67,7 +67,9 @@ $conffiletoshow = "htdocs/conf/conf.php";
// Include configuration // Include configuration
// --- End of part replaced by Dolibarr packager makepack-dolibarr // --- End of part replaced by Dolibarr packager makepack-dolibarr
// Replace conf filename with "conf" parameter on url by GET // Replace conf filename with "conf" parameter on url by GET
/* Disabled. This is a serious security hole
if (! empty($_GET['conf'])) if (! empty($_GET['conf']))
{ {
$confname=basename($_GET['conf']); $confname=basename($_GET['conf']);
@ -77,7 +79,7 @@ if (! empty($_GET['conf']))
$confname=basename(empty($_COOKIE['dolconf']) ? 'conf' : $_COOKIE['dolconf']); $confname=basename(empty($_COOKIE['dolconf']) ? 'conf' : $_COOKIE['dolconf']);
$conffile = 'conf/'.$confname.'.php'; $conffile = 'conf/'.$confname.'.php';
} }
*/
// Include configuration // Include configuration
$result=@include_once $conffile; // Keep @ because with some error reporting this break the redirect $result=@include_once $conffile; // Keep @ because with some error reporting this break the redirect