Merge pull request #9247 from frederic34/missingReturn

return comment
This commit is contained in:
Laurent Destailleur 2018-08-16 00:35:39 +02:00 committed by GitHub
commit 3b245f1b30
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
27 changed files with 311 additions and 254 deletions

View File

@ -218,9 +218,9 @@
<severity>5</severity> <severity>5</severity>
</rule> </rule>
<rule ref="PEAR.Commenting.FunctionComment.MissingReturn"> <!--<rule ref="PEAR.Commenting.FunctionComment.MissingReturn">
<severity>0</severity> <severity>0</severity>
</rule> </rule>-->
<rule ref="PEAR.Commenting.FunctionComment.Missing"> <rule ref="PEAR.Commenting.FunctionComment.Missing">
<severity>0</severity> <severity>0</severity>
</rule> </rule>

View File

@ -185,6 +185,7 @@ class AccountancyExport
* Function who chose which export to use with the default config * Function who chose which export to use with the default config
* *
* @param unknown $TData data * @param unknown $TData data
* @return void
*/ */
public function export(&$TData) { public function export(&$TData) {
global $conf, $langs; global $conf, $langs;
@ -602,6 +603,7 @@ class AccountancyExport
* *
* @param unknown $str data * @param unknown $str data
* @param integer $size data * @param integer $size data
* @return string
*/ */
public static function trunc($str, $size) { public static function trunc($str, $size) {
return dol_trunc($str, $size, 'right', 'UTF-8', 1); return dol_trunc($str, $size, 'right', 'UTF-8', 1);

View File

@ -2454,6 +2454,7 @@ class Adherent extends CommonObject
* Existing categories are left untouch. * Existing categories are left untouch.
* *
* @param int[]|int $categories Category or categories IDs * @param int[]|int $categories Category or categories IDs
* @return void
*/ */
public function setCategories($categories) public function setCategories($categories)
{ {

View File

@ -82,6 +82,7 @@ class PrestaShopWebservice
* Take the status code and throw an exception if the server didn't return 200 or 201 code * Take the status code and throw an exception if the server didn't return 200 or 201 code
* *
* @param int $status_code Status code of an HTTP return * @param int $status_code Status code of an HTTP return
* @return void
*/ */
protected function checkStatusCode($status_code) protected function checkStatusCode($status_code)
{ {

View File

@ -217,6 +217,7 @@ class DolibarrApi
* @param string $feature2 Feature to check, second level of permission (optional). Can be or check with 'level1|level2'. * @param string $feature2 Feature to check, second level of permission (optional). Can be or check with 'level1|level2'.
* @param string $dbt_keyfield Field name for socid foreign key if not fk_soc. Not used if objectid is null (optional) * @param string $dbt_keyfield Field name for socid foreign key if not fk_soc. Not used if objectid is null (optional)
* @param string $dbt_select Field name for select if not rowid. Not used if objectid is null (optional) * @param string $dbt_select Field name for select if not rowid. Not used if objectid is null (optional)
* @return bool
* @throws RestException * @throws RestException
*/ */
static function _checkAccessToResource($resource, $resource_id=0, $dbtablename='', $feature2='', $dbt_keyfield='fk_soc', $dbt_select='rowid') { static function _checkAccessToResource($resource, $resource_id=0, $dbtablename='', $feature2='', $dbt_keyfield='fk_soc', $dbt_select='rowid') {

View File

@ -188,6 +188,7 @@ class Setup extends DolibarrApi
* @param int $id ID of country * @param int $id ID of country
* @param string $lang Code of the language the name of the * @param string $lang Code of the language the name of the
* country must be translated to * country must be translated to
* @return array Array of cleaned object properties
* *
* @url GET dictionary/countries/{id} * @url GET dictionary/countries/{id}
* *
@ -293,6 +294,7 @@ class Setup extends DolibarrApi
* @param Ccountry $country Country * @param Ccountry $country Country
* @param string $lang Code of the language the name of the * @param string $lang Code of the language the name of the
* country must be translated to * country must be translated to
* @return void
*/ */
private function translateLabel($country, $lang) private function translateLabel($country, $lang)
{ {

View File

@ -28,6 +28,7 @@ class Status
{ {
/** /**
* Get status (Dolibarr version) * Get status (Dolibarr version)
* @return array
*/ */
function index() { function index() {
global $conf; global $conf;

View File

@ -105,7 +105,8 @@ class BlockedLogAuthority
/** /**
* Add a new block to the chain * Add a new block to the chain
* *
* @param string $block new block to chain * @param string $block new block to chain
* @return void
*/ */
public function addBlock($block) { public function addBlock($block) {

View File

@ -18,9 +18,6 @@
* See https://medium.com/@lhartikk/a-blockchain-in-200-lines-of-code-963cc1cc0e54 * See https://medium.com/@lhartikk/a-blockchain-in-200-lines-of-code-963cc1cc0e54
*/ */
/*ini_set('unserialize_callback_func', 'mycallback'); /*ini_set('unserialize_callback_func', 'mycallback');
function mycallback($classname) function mycallback($classname)
@ -171,6 +168,7 @@ class BlockedLog
/** /**
* Try to retrieve source object (it it still exists) * Try to retrieve source object (it it still exists)
* @return string
*/ */
public function getObjectLink() public function getObjectLink()
{ {
@ -286,6 +284,7 @@ class BlockedLog
/** /**
* try to retrieve user author * try to retrieve user author
* @return string
*/ */
public function getUser() public function getUser()
{ {
@ -1029,6 +1028,7 @@ class BlockedLog
* Check if module was already used or not for at least one recording. * Check if module was already used or not for at least one recording.
* *
* @param int $ignoresystem Ignore system events for the test * @param int $ignoresystem Ignore system events for the test
* @return bool
*/ */
function alreadyUsed($ignoresystem=0) function alreadyUsed($ignoresystem=0)
{ {
@ -1055,4 +1055,3 @@ class BlockedLog
} }
} }

View File

@ -943,6 +943,7 @@ class Account extends CommonObject
* Existing categories are left untouch. * Existing categories are left untouch.
* *
* @param int[]|int $categories Category or categories IDs * @param int[]|int $categories Category or categories IDs
* @return void
*/ */
public function setCategories($categories) { public function setCategories($categories) {
// Handle single category // Handle single category
@ -2282,4 +2283,3 @@ class AccountLine extends CommonObject
} }
} }

View File

@ -1334,6 +1334,7 @@ class Contact extends CommonObject
* Existing categories are left untouch. * Existing categories are left untouch.
* *
* @param int[]|int $categories Category or categories IDs * @param int[]|int $categories Category or categories IDs
* @return void
*/ */
public function setCategories($categories) public function setCategories($categories)
{ {

View File

@ -6810,6 +6810,7 @@ abstract class CommonObject
* Function to load data from a SQL pointer into properties of current object $this * Function to load data from a SQL pointer into properties of current object $this
* *
* @param stdClass $obj Contain data of object from database * @param stdClass $obj Contain data of object from database
* @return void
*/ */
protected function setVarsFromFetchObj(&$obj) protected function setVarsFromFetchObj(&$obj)
{ {

View File

@ -171,6 +171,8 @@ class CoreObject extends CommonObject
/** /**
* Function to fetch children objects * Function to fetch children objects
*
* @return void
*/ */
public function fetchChild() public function fetchChild()
{ {
@ -207,6 +209,7 @@ class CoreObject extends CommonObject
* Function to update children data * Function to update children data
* *
* @param User $user user object * @param User $user user object
* @return void
*/ */
public function saveChild(User &$user) public function saveChild(User &$user)
{ {

View File

@ -1594,6 +1594,7 @@ function dol_banner_tab($object, $paramid, $morehtml='', $shownav=1, $fieldid='r
* @param string $langkey Translation key * @param string $langkey Translation key
* @param string $fieldkey Key of the html select field the text refers to * @param string $fieldkey Key of the html select field the text refers to
* @param int $fieldrequired 1=Field is mandatory * @param int $fieldrequired 1=Field is mandatory
* @return string
* @deprecated Form::editfieldkey * @deprecated Form::editfieldkey
*/ */
function fieldLabel($langkey, $fieldkey, $fieldrequired=0) function fieldLabel($langkey, $fieldkey, $fieldrequired=0)
@ -7431,6 +7432,7 @@ function getAdvancedPreviewUrl($modulepart, $relativepath, $alldata=0, $param=''
* *
* @param string $htmlname Id of html object * @param string $htmlname Id of html object
* @param string $addlink Add a 'link to' after * @param string $addlink Add a 'link to' after
* @return string
*/ */
function ajax_autoselect($htmlname, $addlink='') function ajax_autoselect($htmlname, $addlink='')
{ {
@ -7568,6 +7570,7 @@ function dol_mimetype($file, $default='application/octet-stream', $mode=0)
* @param int $id id of line * @param int $id id of line
* @param bool $checkentity add filter on entity * @param bool $checkentity add filter on entity
* @param string $rowidfield name of the column rowid * @param string $rowidfield name of the column rowid
* @return string
*/ */
function getDictvalue($tablename, $field, $id, $checkentity=false, $rowidfield='rowid') function getDictvalue($tablename, $field, $id, $checkentity=false, $rowidfield='rowid')
{ {

View File

@ -233,6 +233,7 @@ function dolNumberToWord($numero, $langs, $numorcurrency='number')
* @param integer $hundreds Hundreds * @param integer $hundreds Hundreds
* @param integer $tens Tens * @param integer $tens Tens
* @param integer $units Units * @param integer $units Units
* @return string
*/ */
function hundreds2text($hundreds, $tens, $units) function hundreds2text($hundreds, $tens, $units)
{ {

View File

@ -263,6 +263,7 @@ function pdf_getHeightForLogo($logo, $url = false)
* *
* @param TCPDF $pdf PDF initialized object * @param TCPDF $pdf PDF initialized object
* @param string $htmlcontent HTML Contect * @param string $htmlcontent HTML Contect
* @return number
* @see getStringHeight * @see getStringHeight
*/ */
function pdfGetHeightForHtmlContent(&$pdf, $htmlcontent) function pdfGetHeightForHtmlContent(&$pdf, $htmlcontent)
@ -2120,4 +2121,3 @@ function pdf_getSizeForImage($realpath)
} }
return array('width'=>$width,'height'=>$height); return array('width'=>$width,'height'=>$height);
} }

View File

@ -77,6 +77,7 @@ class pdf_tcpdflabel extends CommonStickerGenerator
* @param int $y y position in user units * @param int $y y position in user units
* @param int $w width in user units * @param int $w width in user units
* @param int $h height in user units * @param int $h height in user units
* @return void
*/ */
private function writeBarcode(&$pdf, $code, $encoding, $is2d, $x, $y, $w, $h) private function writeBarcode(&$pdf, $code, $encoding, $is2d, $x, $y, $w, $h)
{ {

View File

@ -1297,6 +1297,7 @@ class ExpenseReport extends CommonObject
* @param User $fuser User * @param User $fuser User
* @param Details $details Details * @param Details $details Details
* @param int $notrigger Disable triggers * @param int $notrigger Disable triggers
* @return int
*/ */
function setDeny($fuser,$details,$notrigger=0) function setDeny($fuser,$details,$notrigger=0)
{ {

View File

@ -99,6 +99,7 @@ class MyModuleFunctionalTest extends \PHPUnit_Extensions_Selenium2TestCase
/** /**
* Global test setup * Global test setup
* @return void
*/ */
public static function setUpBeforeClass() public static function setUpBeforeClass()
{ {
@ -106,6 +107,7 @@ class MyModuleFunctionalTest extends \PHPUnit_Extensions_Selenium2TestCase
/** /**
* Unit test setup * Unit test setup
* @return void
*/ */
public function setUp() public function setUp()
{ {
@ -115,6 +117,7 @@ class MyModuleFunctionalTest extends \PHPUnit_Extensions_Selenium2TestCase
/** /**
* Verify pre conditions * Verify pre conditions
* @return void
*/ */
protected function assertPreConditions() protected function assertPreConditions()
{ {
@ -122,6 +125,7 @@ class MyModuleFunctionalTest extends \PHPUnit_Extensions_Selenium2TestCase
/** /**
* Handle Dolibarr authentication * Handle Dolibarr authentication
* @return void
*/ */
private function authenticate() private function authenticate()
{ {
@ -142,6 +146,7 @@ class MyModuleFunctionalTest extends \PHPUnit_Extensions_Selenium2TestCase
/** /**
* Test enabling developer mode * Test enabling developer mode
* @return bool
*/ */
public function testEnableDeveloperMode() public function testEnableDeveloperMode()
{ {
@ -161,6 +166,7 @@ class MyModuleFunctionalTest extends \PHPUnit_Extensions_Selenium2TestCase
* Test enabling the module * Test enabling the module
* *
* @depends testEnableDeveloperMode * @depends testEnableDeveloperMode
* @return bool
*/ */
public function testModuleEnabled() public function testModuleEnabled()
{ {
@ -186,6 +192,7 @@ class MyModuleFunctionalTest extends \PHPUnit_Extensions_Selenium2TestCase
* Test access to the configuration page * Test access to the configuration page
* *
* @depends testModuleEnabled * @depends testModuleEnabled
* @return bool
*/ */
public function testConfigurationPage() public function testConfigurationPage()
{ {
@ -198,6 +205,7 @@ class MyModuleFunctionalTest extends \PHPUnit_Extensions_Selenium2TestCase
* Test access to the about page * Test access to the about page
* *
* @depends testConfigurationPage * @depends testConfigurationPage
* @return bool
*/ */
public function testAboutPage() public function testAboutPage()
{ {
@ -210,6 +218,7 @@ class MyModuleFunctionalTest extends \PHPUnit_Extensions_Selenium2TestCase
* Test about page is rendering Markdown * Test about page is rendering Markdown
* *
* @depends testAboutPage * @depends testAboutPage
* @return bool
*/ */
public function testAboutPageRendersMarkdownReadme() public function testAboutPageRendersMarkdownReadme()
{ {
@ -226,6 +235,7 @@ class MyModuleFunctionalTest extends \PHPUnit_Extensions_Selenium2TestCase
* Test box is properly declared * Test box is properly declared
* *
* @depends testModuleEnabled * @depends testModuleEnabled
* @return bool
*/ */
public function testBoxDeclared() public function testBoxDeclared()
{ {
@ -238,6 +248,7 @@ class MyModuleFunctionalTest extends \PHPUnit_Extensions_Selenium2TestCase
* Test trigger is properly enabled * Test trigger is properly enabled
* *
* @depends testModuleEnabled * @depends testModuleEnabled
* @return bool
*/ */
public function testTriggerDeclared() public function testTriggerDeclared()
{ {
@ -254,6 +265,7 @@ class MyModuleFunctionalTest extends \PHPUnit_Extensions_Selenium2TestCase
* Test trigger is properly declared * Test trigger is properly declared
* *
* @depends testTriggerDeclared * @depends testTriggerDeclared
* @return bool
*/ */
public function testTriggerEnabled() public function testTriggerEnabled()
{ {
@ -268,6 +280,7 @@ class MyModuleFunctionalTest extends \PHPUnit_Extensions_Selenium2TestCase
/** /**
* Verify post conditions * Verify post conditions
* @return void
*/ */
protected function assertPostConditions() protected function assertPostConditions()
{ {
@ -275,6 +288,7 @@ class MyModuleFunctionalTest extends \PHPUnit_Extensions_Selenium2TestCase
/** /**
* Unit test teardown * Unit test teardown
* @return void
*/ */
public function tearDown() public function tearDown()
{ {
@ -282,6 +296,7 @@ class MyModuleFunctionalTest extends \PHPUnit_Extensions_Selenium2TestCase
/** /**
* Global test teardown * Global test teardown
* @return void
*/ */
public static function tearDownAfterClass() public static function tearDownAfterClass()
{ {

View File

@ -32,6 +32,7 @@ class MyObjectTest extends \PHPUnit_Framework_TestCase
{ {
/** /**
* Global test setup * Global test setup
* @return void
*/ */
public static function setUpBeforeClass() public static function setUpBeforeClass()
{ {
@ -40,6 +41,7 @@ class MyObjectTest extends \PHPUnit_Framework_TestCase
/** /**
* Unit test setup * Unit test setup
* @return void
*/ */
protected function setUp() protected function setUp()
{ {
@ -48,6 +50,7 @@ class MyObjectTest extends \PHPUnit_Framework_TestCase
/** /**
* Verify pre conditions * Verify pre conditions
* @return void
*/ */
protected function assertPreConditions() protected function assertPreConditions()
{ {
@ -56,6 +59,7 @@ class MyObjectTest extends \PHPUnit_Framework_TestCase
/** /**
* A sample test * A sample test
* @return bool
*/ */
public function testSomething() public function testSomething()
{ {
@ -66,6 +70,7 @@ class MyObjectTest extends \PHPUnit_Framework_TestCase
/** /**
* Verify post conditions * Verify post conditions
* @return void
*/ */
protected function assertPostConditions() protected function assertPostConditions()
{ {
@ -74,6 +79,7 @@ class MyObjectTest extends \PHPUnit_Framework_TestCase
/** /**
* Unit test teardown * Unit test teardown
* @return void
*/ */
protected function tearDown() protected function tearDown()
{ {
@ -82,6 +88,7 @@ class MyObjectTest extends \PHPUnit_Framework_TestCase
/** /**
* Global test teardown * Global test teardown
* @return void
*/ */
public static function tearDownAfterClass() public static function tearDownAfterClass()
{ {
@ -92,6 +99,7 @@ class MyObjectTest extends \PHPUnit_Framework_TestCase
* Unsuccessful test * Unsuccessful test
* *
* @param Exception $e Exception * @param Exception $e Exception
* @return void
* @throws Exception * @throws Exception
*/ */
protected function onNotSuccessfulTest(Exception $e) protected function onNotSuccessfulTest(Exception $e)

View File

@ -397,8 +397,8 @@ class MultiCurrency extends CommonObject
* *
* @return int -1 if KO, 1 if OK * @return int -1 if KO, 1 if OK
*/ */
public function addRate($rate) public function addRate($rate)
{ {
$currencyRate = new CurrencyRate($this->db); $currencyRate = new CurrencyRate($this->db);
$currencyRate->rate = $rate; $currencyRate->rate = $rate;
@ -412,16 +412,16 @@ class MultiCurrency extends CommonObject
$this->rate = null; $this->rate = null;
return -1; return -1;
} }
} }
/** /**
* Try get label of code in llx_currency then add rate * Try get label of code in llx_currency then add rate
* *
* @param string $code currency code * @param string $code currency code
* @param double $rate new rate * @param double $rate new rate
* *
* @return int -1 if KO, 1 if OK, 2 if label found and OK * @return int -1 if KO, 1 if OK, 2 if label found and OK
*/ */
function addRateFromDolibarr($code, $rate) function addRateFromDolibarr($code, $rate)
{ {
global $db, $user; global $db, $user;
@ -450,25 +450,25 @@ class MultiCurrency extends CommonObject
return -1; return -1;
} }
/** /**
* Add new entry into llx_multicurrency_rate to historise * Add new entry into llx_multicurrency_rate to historise
* *
* @param double $rate rate value * @param double $rate rate value
* *
* @return int <0 if KO, >0 if OK * @return int <0 if KO, >0 if OK
*/ */
public function updateRate($rate) public function updateRate($rate)
{ {
return $this->addRate($rate); return $this->addRate($rate);
} }
/** /**
* Fetch CurrencyRate object in $this->rate * Fetch CurrencyRate object in $this->rate
* *
* @return int <0 if KO, 0 if not found, >0 if OK * @return int <0 if KO, 0 if not found, >0 if OK
*/ */
public function getRate() public function getRate()
{ {
$sql = 'SELECT cr.rowid'; $sql = 'SELECT cr.rowid';
$sql.= ' FROM '.MAIN_DB_PREFIX.$this->table_element_line.' as cr'; $sql.= ' FROM '.MAIN_DB_PREFIX.$this->table_element_line.' as cr';
$sql.= ' WHERE cr.fk_multicurrency = '.$this->id; $sql.= ' WHERE cr.fk_multicurrency = '.$this->id;
@ -481,9 +481,9 @@ class MultiCurrency extends CommonObject
return $this->rate->fetch($obj->rowid); return $this->rate->fetch($obj->rowid);
} }
} }
/** /**
* Get id of currency from code * Get id of currency from code
* *
* @param DoliDB $db object db * @param DoliDB $db object db
@ -491,8 +491,8 @@ class MultiCurrency extends CommonObject
* *
* @return 0 if not found, >0 if OK * @return 0 if not found, >0 if OK
*/ */
public static function getIdFromCode(&$db, $code) public static function getIdFromCode(&$db, $code)
{ {
global $conf; global $conf;
$sql = 'SELECT rowid FROM '.MAIN_DB_PREFIX.'multicurrency WHERE code = \''.$db->escape($code).'\' AND entity = '.$conf->entity; $sql = 'SELECT rowid FROM '.MAIN_DB_PREFIX.'multicurrency WHERE code = \''.$db->escape($code).'\' AND entity = '.$conf->entity;
@ -501,9 +501,9 @@ class MultiCurrency extends CommonObject
$resql = $db->query($sql); $resql = $db->query($sql);
if ($resql && $obj = $db->fetch_object($resql)) return $obj->rowid; if ($resql && $obj = $db->fetch_object($resql)) return $obj->rowid;
else return 0; else return 0;
} }
/** /**
* Get id and rate of currency from code * Get id and rate of currency from code
* *
* @param DoliDB $db object db * @param DoliDB $db object db
@ -513,8 +513,8 @@ class MultiCurrency extends CommonObject
* @return array [0] => id currency * @return array [0] => id currency
* [1] => rate * [1] => rate
*/ */
public static function getIdAndTxFromCode(&$db, $code, $date_document='') public static function getIdAndTxFromCode(&$db, $code, $date_document='')
{ {
global $conf; global $conf;
$sql1 = 'SELECT m.rowid, mc.rate FROM '.MAIN_DB_PREFIX.'multicurrency m'; $sql1 = 'SELECT m.rowid, mc.rate FROM '.MAIN_DB_PREFIX.'multicurrency m';
@ -539,53 +539,54 @@ class MultiCurrency extends CommonObject
return array(0, 1); return array(0, 1);
} }
} }
/** /**
* Get the conversion of amount with invoice rate * Get the conversion of amount with invoice rate
* *
* @param int $fk_facture id of facture * @param int $fk_facture id of facture
* @param double $amount amount to convert * @param double $amount amount to convert
* @param string $way dolibarr mean the amount is in dolibarr currency * @param string $way dolibarr mean the amount is in dolibarr currency
* @param string $table facture or facture_fourn * @param string $table facture or facture_fourn
* *
* @return double amount converted * @return double amount converted
*/ */
public static function getAmountConversionFromInvoiceRate($fk_facture, $amount, $way='dolibarr', $table='facture') public static function getAmountConversionFromInvoiceRate($fk_facture, $amount, $way='dolibarr', $table='facture')
{ {
global $db; global $db;
$multicurrency_tx = self::getInvoiceRate($fk_facture, $table); $multicurrency_tx = self::getInvoiceRate($fk_facture, $table);
if ($multicurrency_tx) if ($multicurrency_tx)
{ {
if ($way == 'dolibarr') return $amount * $multicurrency_tx; if ($way == 'dolibarr') return $amount * $multicurrency_tx;
else return $amount / $multicurrency_tx; else return $amount / $multicurrency_tx;
} }
else return $amount; else return $amount;
} }
/** /**
* Get current invoite rate * Get current invoite rate
* *
* @param int $fk_facture id of facture * @param int $fk_facture id of facture
* @param string $table facture or facture_fourn * @param string $table facture or facture_fourn
*/ * @return bool
public static function getInvoiceRate($fk_facture, $table='facture') */
{ public static function getInvoiceRate($fk_facture, $table='facture')
global $db; {
global $db;
$sql = 'SELECT multicurrency_tx FROM '.MAIN_DB_PREFIX.$table.' WHERE rowid = '.$fk_facture; $sql = 'SELECT multicurrency_tx FROM '.MAIN_DB_PREFIX.$table.' WHERE rowid = '.$fk_facture;
dol_syslog(__METHOD__,LOG_DEBUG); dol_syslog(__METHOD__,LOG_DEBUG);
$resql = $db->query($sql); $resql = $db->query($sql);
if ($resql && ($line = $db->fetch_object($resql))) if ($resql && ($line = $db->fetch_object($resql)))
{ {
return $line->multicurrency_tx; return $line->multicurrency_tx;
} }
return false; return false;
} }
/** /**
* With free account we can't set source then recalcul all rates to force another source * With free account we can't set source then recalcul all rates to force another source
@ -621,19 +622,20 @@ class MultiCurrency extends CommonObject
* Sync rates from api * Sync rates from api
* *
* @param array $response array of reponse from api to sync dolibarr rates * @param array $response array of reponse from api to sync dolibarr rates
* @return void
*/ */
public static function syncRates($response) public static function syncRates($response)
{ {
global $db,$conf; global $db,$conf;
$ch = curl_init('http://apilayer.net/api/live?access_key='.$key.''); $ch = curl_init('http://apilayer.net/api/live?access_key='.$key.'');
curl_setopt($ch, CURLOPT_RETURNTRANSFER, true); curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
$response = curl_exec($ch); $response = curl_exec($ch);
curl_close($ch); curl_close($ch);
$response = json_decode($response); $response = json_decode($response);
if ($response->success) if ($response->success)
{ {
$TRate = $response->quotes; $TRate = $response->quotes;
$timestamp = $response->timestamp; $timestamp = $response->timestamp;
@ -667,14 +669,14 @@ class MultiCurrency extends CommonObject
* @param string $code current code to search * @param string $code current code to search
* @return boolean True if exists, false if not exists * @return boolean True if exists, false if not exists
*/ */
public static function checkCodeAlreadyExists($code) public static function checkCodeAlreadyExists($code)
{ {
global $db; global $db;
$currency = new MultiCurrency($db); $currency = new MultiCurrency($db);
if ($currency->fetch('', $code) > 0) return true; if ($currency->fetch('', $code) > 0) return true;
else return false; else return false;
} }
} }
/** /**

View File

@ -4504,6 +4504,7 @@ class Product extends CommonObject
* Existing categories are left untouch. * Existing categories are left untouch.
* *
* @param int[]|int $categories Category or categories IDs * @param int[]|int $categories Category or categories IDs
* @return void
*/ */
public function setCategories($categories) { public function setCategories($categories) {
// Handle single category // Handle single category

View File

@ -1904,6 +1904,7 @@ class Project extends CommonObject
* Existing categories are left untouch. * Existing categories are left untouch.
* *
* @param int[]|int $categories Category or categories IDs * @param int[]|int $categories Category or categories IDs
* @return void
*/ */
public function setCategories($categories) public function setCategories($categories)
{ {
@ -1972,4 +1973,3 @@ class Project extends CommonObject
} }
} }

View File

@ -63,6 +63,7 @@ class ActionsStripeconnect
* @param array $parameters Parameters * @param array $parameters Parameters
* @param Object $object Object * @param Object $object Object
* @param string $action Action * @param string $action Action
* @return bool
*/ */
function formObjectOptions($parameters, &$object, &$action) function formObjectOptions($parameters, &$object, &$action)
{ {

View File

@ -579,6 +579,7 @@ class ActionsTicket
* *
* @param User $user User for action * @param User $user User for action
* @param string $action Action string * @param string $action Action string
* @return int
*/ */
private function newMessage($user, &$action) private function newMessage($user, &$action)
{ {
@ -792,6 +793,7 @@ class ActionsTicket
* *
* @param User $user User for action * @param User $user User for action
* @param string $action Action string * @param string $action Action string
* @return void
*/ */
private function newMessagePublic($user, &$action) private function newMessagePublic($user, &$action)
{ {
@ -962,6 +964,7 @@ class ActionsTicket
* Get ticket info * Get ticket info
* *
* @param int $id Object id * @param int $id Object id
* @return void
*/ */
public function getInfo($id) public function getInfo($id)
{ {
@ -976,6 +979,7 @@ class ActionsTicket
* Get action title * Get action title
* *
* @param string $action Type of action * @param string $action Type of action
* @return string
*/ */
public function getTitle($action = '') public function getTitle($action = '')
{ {
@ -998,6 +1002,7 @@ class ActionsTicket
* View html list of logs * View html list of logs
* *
* @param boolean $show_user Show user who make action * @param boolean $show_user Show user who make action
* @return void
*/ */
public function viewTicketLogs($show_user = true) public function viewTicketLogs($show_user = true)
{ {
@ -1058,6 +1063,7 @@ class ActionsTicket
* *
* @param boolean $show_user Show user who make action * @param boolean $show_user Show user who make action
* @param Ticket $object Object * @param Ticket $object Object
* @return void
*/ */
public function viewTimelineTicketLogs($show_user = true, $object = true) public function viewTimelineTicketLogs($show_user = true, $object = true)
{ {
@ -1165,6 +1171,7 @@ class ActionsTicket
* *
* @param boolean $show_private Show private messages * @param boolean $show_private Show private messages
* @param boolean $show_user Show user who make action * @param boolean $show_user Show user who make action
* @return void
*/ */
public function viewTicketMessages($show_private, $show_user = true) public function viewTicketMessages($show_private, $show_user = true)
{ {
@ -1237,6 +1244,7 @@ class ActionsTicket
* @param boolean $show_private Show private messages * @param boolean $show_private Show private messages
* @param boolean $show_user Show user who make action * @param boolean $show_user Show user who make action
* @param Ticket $object Object ticket * @param Ticket $object Object ticket
* @return void
*/ */
public function viewTicketTimelineMessages($show_private, $show_user, Ticket $object) public function viewTicketTimelineMessages($show_private, $show_user, Ticket $object)
{ {
@ -1308,6 +1316,7 @@ class ActionsTicket
* @param string $message Email message * @param string $message Email message
* @param int $send_internal_cc Receive a copy on internal email ($conf->global->TICKET_NOTIFICATION_EMAIL_FROM) * @param int $send_internal_cc Receive a copy on internal email ($conf->global->TICKET_NOTIFICATION_EMAIL_FROM)
* @param array $array_receiver Array of receiver. exemple array('name' => 'John Doe', 'email' => 'john@doe.com', etc...) * @param array $array_receiver Array of receiver. exemple array('name' => 'John Doe', 'email' => 'john@doe.com', etc...)
* @return void
*/ */
public function sendTicketMessageByEmail($subject, $message, $send_internal_cc = 0, $array_receiver = array()) public function sendTicketMessageByEmail($subject, $message, $send_internal_cc = 0, $array_receiver = array())
{ {

View File

@ -910,6 +910,7 @@ class User extends CommonObject
* Existing categories are left untouch. * Existing categories are left untouch.
* *
* @param int[]|int $categories Category or categories IDs * @param int[]|int $categories Category or categories IDs
* @return void
*/ */
public function setCategories($categories) public function setCategories($categories)
{ {
@ -3147,4 +3148,3 @@ class User extends CommonObject
} }
} }

View File

@ -94,6 +94,7 @@ class RestAPIDocumentTest extends PHPUnit_Framework_TestCase
/** /**
* Init phpunit tests. * Init phpunit tests.
* @return void
*/ */
protected function setUp() protected function setUp()
{ {
@ -125,6 +126,7 @@ class RestAPIDocumentTest extends PHPUnit_Framework_TestCase
/** /**
* End phpunit tests. * End phpunit tests.
* @return void
*/ */
protected function tearDown() protected function tearDown()
{ {