From e0af2feced0795c627439a2a3e62d3d6885b1423 Mon Sep 17 00:00:00 2001 From: Maxime Kohlhaas Date: Sat, 18 Apr 2015 18:06:02 +0200 Subject: [PATCH 1/2] Fix : on impayees remain to pay did not include deposits --- htdocs/compta/facture/impayees.php | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/htdocs/compta/facture/impayees.php b/htdocs/compta/facture/impayees.php index 467d2b0636a..b0001e706a9 100644 --- a/htdocs/compta/facture/impayees.php +++ b/htdocs/compta/facture/impayees.php @@ -649,13 +649,12 @@ if ($resql) print ''.price($objp->total_ttc).''; print ''; $cn=$facturestatic->getSumCreditNotesUsed(); - if (! empty($objp->am)) print price($objp->am); - if (! empty($objp->am) && ! empty($cn)) print '+'; - if (! empty($cn)) print price($cn); + $dep=$facturestatic->getSumDepositsUsed(); + print price($objp->am + $cn + $dep); print ''; // Remain to receive - print ''.((! empty($objp->am) || ! empty($cn))?price($objp->total_ttc-$objp->am-$cn):' ').''; + print ''.price($objp->total_ttc-$objp->am-$cn-$dep).''; // Status of invoice print ''; @@ -685,7 +684,7 @@ if ($resql) $total_ht+=$objp->total_ht; $total_tva+=($objp->total_tva + $tx1 + $tx2 + $revenuestamp); $total_ttc+=$objp->total_ttc; - $total_paid+=$objp->am + $cn; + $total_paid+=$objp->am + $cn + $dep; $i++; } From 8b307aac56b3f19147c13b75b3e8f3b24356d209 Mon Sep 17 00:00:00 2001 From: Maxime Kohlhaas Date: Sat, 18 Apr 2015 18:06:27 +0200 Subject: [PATCH 2/2] Fix : customer outstanding was not calculated properly --- htdocs/societe/class/societe.class.php | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/htdocs/societe/class/societe.class.php b/htdocs/societe/class/societe.class.php index 2cb3e634841..99d76411239 100644 --- a/htdocs/societe/class/societe.class.php +++ b/htdocs/societe/class/societe.class.php @@ -3091,7 +3091,7 @@ class Societe extends CommonObject $alreadypayed=price2num($paiement + $creditnotes + $deposits,'MT'); $remaintopay=price2num($invoice->total_ttc - $paiement - $creditnotes - $deposits,'MT'); */ - $sql = "SELECT sum(total) as amount FROM ".MAIN_DB_PREFIX."facture as f"; + $sql = "SELECT rowid, total_ttc FROM ".MAIN_DB_PREFIX."facture as f"; $sql .= " WHERE fk_soc = ". $this->id; $sql .= " AND paye = 0"; $sql .= " AND fk_statut <> 0"; // Not a draft @@ -3102,8 +3102,17 @@ class Societe extends CommonObject $resql=$this->db->query($sql); if ($resql) { - $obj=$this->db->fetch_object($resql); - return ($obj->amount); + $outstandingBill = 0; + $facturestatic=new Facture($this->db); + while($obj=$this->db->fetch_object($resql)) { + $facturestatic->id=$obj->rowid; + $paiement = $facturestatic->getSommePaiement(); + $creditnotes = $facturestatic->getSumCreditNotesUsed(); + $deposits = $facturestatic->getSumDepositsUsed(); + + $outstandingBill+= $obj->total_ttc - $paiement - $creditnotes - $deposits; + } + return $outstandingBill; } else return 0;