FIX Attachment was lost when we validate an expense report

Conflicts:
	htdocs/expensereport/class/expensereport.class.php
This commit is contained in:
Laurent Destailleur 2019-07-26 16:30:16 +02:00
parent 8b81702dd7
commit 471a947e8a

View File

@ -1120,11 +1120,10 @@ class ExpenseReport extends CommonObject
$resql=$this->db->query($sql);
if ($resql)
{
if (!$notrigger)
if (! $error && ! $notrigger)
{
// Call trigger
$result=$this->call_trigger('EXPENSE_REPORT_VALIDATE',$fuser);
$result=$this->call_trigger('EXPENSE_REPORT_VALIDATE', $fuser);
if ($result < 0) {
$error++;
}
@ -1148,7 +1147,7 @@ class ExpenseReport extends CommonObject
$dirdest = $conf->expensereport->dir_output.'/'.$newref;
if (file_exists($dirsource))
{
dol_syslog(get_class($this)."::valid() rename dir ".$dirsource." into ".$dirdest);
dol_syslog(get_class($this)."::setValidate() rename dir ".$dirsource." into ".$dirdest);
if (@rename($dirsource, $dirdest))
{