lainwir3d/dolibarr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix scrutinizer issues

Browse Source
This commit is contained in:
Laurent Destailleur 2017-11-19 16:55:28 +01:00
parent 248a359ac9
commit 4ad0d5df43
8 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
htdocs/adherents/class/subscription.class.php
View File

@ -258,9 +258,10 @@ class Subscription extends CommonObject
* Return clicable name (with picto eventually) * Return clicable name (with picto eventually)
* *
* @param int $withpicto 0=No picto, 1=Include picto into link, 2=Only picto * @param int $withpicto 0=No picto, 1=Include picto into link, 2=Only picto
* @param int $notooltip 1=Disable tooltip
* @return string Chaine avec URL * @return string Chaine avec URL
*/ */
function getNomUrl($withpicto=0) function getNomUrl($withpicto=0, $notooltip=0)
{ {
global $langs; global $langs;

1
htdocs/contrat/class/api_contracts.class.php
View File

@ -450,7 +450,6 @@ class Contracts extends DolibarrApi
throw new RestException(401, 'Access not allowed for login '.DolibarrApiAccess::$user->login); throw new RestException(401, 'Access not allowed for login '.DolibarrApiAccess::$user->login);
} }
$request_data = (object) $request_data;
$updateRes = $this->contract->deleteline($lineid, DolibarrApiAccess::$user); $updateRes = $this->contract->deleteline($lineid, DolibarrApiAccess::$user);
if ($updateRes > 0) { if ($updateRes > 0) {
return $this->get($id); return $this->get($id);

2
htdocs/core/class/extrafields.class.php
View File

@ -817,6 +817,8 @@ class ExtraFields
$form=new Form($this->db); $form=new Form($this->db);
} }
$out='';
$keyprefix = $keyprefix.'options_'; // Because we work on extrafields $keyprefix = $keyprefix.'options_'; // Because we work on extrafields
$label=$this->attribute_label[$key]; $label=$this->attribute_label[$key];

2
htdocs/cron/class/cronjob.class.php
View File

@ -1061,7 +1061,7 @@ class Cronjob extends CommonObject
// Execute a CLI // Execute a CLI
include_once DOL_DOCUMENT_ROOT.'/core/class/utils.class.php'; include_once DOL_DOCUMENT_ROOT.'/core/class/utils.class.php';
$utils = new Utils($db); $utils = new Utils($this->db);
$arrayresult = $utils->executeCLI($this->command, $outputfile); $arrayresult = $utils->executeCLI($this->command, $outputfile);
$retval = $arrayresult['result']; $retval = $arrayresult['result'];

3
htdocs/don/class/don.class.php
View File

@ -842,9 +842,10 @@ class Don extends CommonObject
* Return clicable name (with picto eventually) * Return clicable name (with picto eventually)
* *
* @param int $withpicto 0=No picto, 1=Include picto into link, 2=Only picto * @param int $withpicto 0=No picto, 1=Include picto into link, 2=Only picto
* @param int $notooltip 1=Disable tooltip
* @return string Chaine avec URL * @return string Chaine avec URL
*/ */
function getNomUrl($withpicto=0) function getNomUrl($withpicto=0, $notooltip=0)
{ {
global $langs; global $langs;

1
htdocs/ecm/class/htmlecm.form.class.php
View File

@ -59,6 +59,7 @@ class FormEcm
if ($select_name=='') $select_name="catParent"; if ($select_name=='') $select_name="catParent";
$cate_arbo=null;
if ($module == 'ecm') if ($module == 'ecm')
{ {
$cat = new EcmDirectory($this->db); $cat = new EcmDirectory($this->db);

3
htdocs/resource/class/dolresource.class.php
View File

@ -927,9 +927,10 @@ class Dolresource extends CommonObject
* @param int $withpicto Add picto into link * @param int $withpicto Add picto into link
* @param string $option Where point the link ('compta', 'expedition', 'document', ...) * @param string $option Where point the link ('compta', 'expedition', 'document', ...)
* @param string $get_params Parametres added to url * @param string $get_params Parametres added to url
* @param int $notooltip 1=Disable tooltip
* @return string String with URL * @return string String with URL
*/ */
function getNomUrl($withpicto=0,$option='', $get_params='') function getNomUrl($withpicto=0,$option='', $get_params='', $notooltip=0)
{ {
global $langs; global $langs;

3
htdocs/supplier_proposal/class/api_supplier_proposals.class.php
View File

@ -38,7 +38,7 @@ class Supplierproposals extends DolibarrApi
); );
/** /**
* @var supplier_proposal $supplier_proposal {@type supplier_proposal} * @var SupplierProposal $supplier_proposal {@type SupplierProposal}
*/ */
public $supplier_proposal; public $supplier_proposal;
@ -149,6 +149,7 @@ class Supplierproposals extends DolibarrApi
{ {
$num = $db->num_rows($result); $num = $db->num_rows($result);
$min = min($num, ($limit <= 0 ? $num : $limit)); $min = min($num, ($limit <= 0 ? $num : $limit));
$i=0;
while ($i < $min) while ($i < $min)
{ {
$obj = $db->fetch_object($result); $obj = $db->fetch_object($result);