From 6484ba10c52ac634c04f54fb24bae4243a470026 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric?= <35066297+c3do@users.noreply.github.com>
Date: Sat, 23 Nov 2019 16:08:35 +0100
Subject: [PATCH] remove unecessary code

already done by ::createProductCombination
---
 htdocs/product/class/api_products.class.php | 19 +++++++------------
 1 file changed, 7 insertions(+), 12 deletions(-)

diff --git a/htdocs/product/class/api_products.class.php b/htdocs/product/class/api_products.class.php
index b0ed902ffb3..40d50357dc2 100644
--- a/htdocs/product/class/api_products.class.php
+++ b/htdocs/product/class/api_products.class.php
@@ -1372,18 +1372,13 @@ class Products extends DolibarrApi
         }
 
         $prodcomb = new ProductCombination($this->db);
-        if (! $prodcomb->fetchByProductCombination2ValuePairs($id, $features))
-        {
-            $result = $prodcomb->createProductCombination(DolibarrApiAccess::$user, $this->product, $features, array(), $price_impact_is_percent, $price_impact, $weight_impact, $reference);
-            if ($result > 0)
-            {
-                return $result;
-            } else {
-                throw new RestException(500, "Error creating new product variant");
-            }
-        } else {
-            return $prodcomb->id;
-        }
+		$result = $prodcomb->createProductCombination(DolibarrApiAccess::$user, $this->product, $features, array(), $price_impact_is_percent, $price_impact, $weight_impact, $reference);
+		if ($result > 0)
+		{
+			return $result;
+		} else {
+			throw new RestException(500, "Error creating new product variant");
+		}
     }
 
     /**