Merge pull request #13723 from simicar29/11.0-propal

Clean line extrafields when deleting proposal
This commit is contained in:
Laurent Destailleur 2020-04-23 18:11:26 +02:00 committed by GitHub
commit 67d6b6b3db
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -2992,8 +2992,11 @@ class Propal extends CommonObject
if (!$error)
{
$main = MAIN_DB_PREFIX . 'propaldet';
$ef = $main . "_extrafields";
$sqlef = "DELETE FROM $ef WHERE fk_object IN (SELECT rowid FROM $main WHERE fk_propal = " . $this->id . ")";
$sql = "DELETE FROM ".MAIN_DB_PREFIX."propaldet WHERE fk_propal = ".$this->id;
if ($this->db->query($sql))
if ($this->db->query($sqlef) && $this->db->query($sql))
{
$sql = "DELETE FROM ".MAIN_DB_PREFIX."propal WHERE rowid = ".$this->id;
if ($this->db->query($sql))