From 6936d56946cfdce9977b4c08a783cc6de01b2935 Mon Sep 17 00:00:00 2001
From: Laurent Destailleur <eldy@destailleur.fr>
Date: Fri, 16 Mar 2018 01:01:56 +0100
Subject: [PATCH] Fix scrutinizer

---
 htdocs/ticketsup/class/actions_ticketsup.class.php          | 6 +++---
 .../class/api_dictionaryticketsupcategories.class.php       | 4 +---
 .../class/api_dictionaryticketsupseverities.class.php       | 4 +---
 .../ticketsup/class/api_dictionaryticketsuptypes.class.php  | 4 +---
 4 files changed, 6 insertions(+), 12 deletions(-)

diff --git a/htdocs/ticketsup/class/actions_ticketsup.class.php b/htdocs/ticketsup/class/actions_ticketsup.class.php
index 08257d16acb..317f3f187ff 100644
--- a/htdocs/ticketsup/class/actions_ticketsup.class.php
+++ b/htdocs/ticketsup/class/actions_ticketsup.class.php
@@ -809,12 +809,12 @@ class ActionsTicketsup
 
                 return 1;
             } else {
-                return -1;
                 setEventMessages($this->dao->error, $this->dao->errors, 'errors');
+                return -1;
             }
         } else {
-            return -1;
             setEventMessages($this->error, $this->errors, 'errors');
+            return -1;
         }
     }
 
@@ -1485,7 +1485,7 @@ class ActionsTicketsup
 
         // If status is new, don't show link which allow mark ticket as read
         // Specific method exists to mark a ticket as read
-        if ($this->dao->fk_statut === '0') {
+        if ($this->dao->fk_statut == '0') {
             $exclude_status = array_merge($exclude_status, array(1));
         }
 
diff --git a/htdocs/ticketsup/class/api_dictionaryticketsupcategories.class.php b/htdocs/ticketsup/class/api_dictionaryticketsupcategories.class.php
index ce81bc67f6c..d33f96db881 100644
--- a/htdocs/ticketsup/class/api_dictionaryticketsupcategories.class.php
+++ b/htdocs/ticketsup/class/api_dictionaryticketsupcategories.class.php
@@ -28,8 +28,6 @@ require_once DOL_DOCUMENT_ROOT.'/main.inc.php';
  */
 class DictionaryTicketsupCategories extends DolibarrApi
 {
-    private $translations = null;
-
     /**
      * Constructor
      */
@@ -96,5 +94,5 @@ class DictionaryTicketsupCategories extends DolibarrApi
         return $list;
     }
 
-  
+
 }
diff --git a/htdocs/ticketsup/class/api_dictionaryticketsupseverities.class.php b/htdocs/ticketsup/class/api_dictionaryticketsupseverities.class.php
index c41f66a379e..892563ad426 100644
--- a/htdocs/ticketsup/class/api_dictionaryticketsupseverities.class.php
+++ b/htdocs/ticketsup/class/api_dictionaryticketsupseverities.class.php
@@ -28,8 +28,6 @@ require_once DOL_DOCUMENT_ROOT.'/main.inc.php';
  */
 class DictionaryTicketsupSeverities extends DolibarrApi
 {
-    private $translations = null;
-
     /**
      * Constructor
      */
@@ -96,5 +94,5 @@ class DictionaryTicketsupSeverities extends DolibarrApi
         return $list;
     }
 
-  
+
 }
diff --git a/htdocs/ticketsup/class/api_dictionaryticketsuptypes.class.php b/htdocs/ticketsup/class/api_dictionaryticketsuptypes.class.php
index 008e2be337a..90b8d4f6bbc 100644
--- a/htdocs/ticketsup/class/api_dictionaryticketsuptypes.class.php
+++ b/htdocs/ticketsup/class/api_dictionaryticketsuptypes.class.php
@@ -28,8 +28,6 @@ require_once DOL_DOCUMENT_ROOT.'/main.inc.php';
  */
 class DictionaryTicketsupTypes extends DolibarrApi
 {
-    private $translations = null;
-
     /**
      * Constructor
      */
@@ -98,5 +96,5 @@ class DictionaryTicketsupTypes extends DolibarrApi
         return $list;
     }
 
-  
+
 }