From 6a242edd8bc480c253d40b0c857eadcf60aa3539 Mon Sep 17 00:00:00 2001
From: Christophe Battarel <christophe@altairis.fr>
Date: Thu, 4 Mar 2021 15:29:47 +0100
Subject: [PATCH] check unicity of serial number

---
 htdocs/langs/en_US/productbatch.lang          |  2 +
 htdocs/langs/fr_FR/productbatch.lang          |  2 +
 .../stock/class/mouvementstock.class.php      | 47 ++++++++++++++++++-
 3 files changed, 50 insertions(+), 1 deletion(-)

diff --git a/htdocs/langs/en_US/productbatch.lang b/htdocs/langs/en_US/productbatch.lang
index 3ab83908ff5..37c34b9caed 100644
--- a/htdocs/langs/en_US/productbatch.lang
+++ b/htdocs/langs/en_US/productbatch.lang
@@ -24,3 +24,5 @@ ProductLotSetup=Setup of module lot/serial
 ShowCurrentStockOfLot=Show current stock for couple product/lot
 ShowLogOfMovementIfLot=Show log of movements for couple product/lot
 StockDetailPerBatch=Stock detail per lot
+SerialNumberAlreadyInUse=Serial number %s is already used for product %s
+
diff --git a/htdocs/langs/fr_FR/productbatch.lang b/htdocs/langs/fr_FR/productbatch.lang
index 76cba909e2c..edfd928453c 100644
--- a/htdocs/langs/fr_FR/productbatch.lang
+++ b/htdocs/langs/fr_FR/productbatch.lang
@@ -24,3 +24,5 @@ ProductLotSetup=Configuration du module lot/série
 ShowCurrentStockOfLot=Afficher le stock actuel pour le couple produit / lot
 ShowLogOfMovementIfLot=Afficher l'historique des mouvements de couple produit / lot
 StockDetailPerBatch=Stock détaillé par lot
+SerialNumberAlreadyInUse=Le numéro de série %s est déjà utilisé pour le produit %s
+
diff --git a/htdocs/product/stock/class/mouvementstock.class.php b/htdocs/product/stock/class/mouvementstock.class.php
index 17fe7193658..d7df01e882f 100644
--- a/htdocs/product/stock/class/mouvementstock.class.php
+++ b/htdocs/product/stock/class/mouvementstock.class.php
@@ -192,7 +192,7 @@ class MouvementStock extends CommonObject
 			}
                 }
                 // end hook at beginning
-		
+
 		// Clean parameters
 		$price = price2num($price, 'MU'); // Clean value for the casse we receive a float zero value, to have it a real zero value.
 		if (empty($price)) $price = 0;
@@ -568,6 +568,13 @@ class MouvementStock extends CommonObject
 			// Update detail stock for batch product
 			if (!$error && !empty($conf->productbatch->enabled) && $product->hasbatch() && !$skip_batch)
 			{
+				// check unicity for serial numbered equipments ( different for lots managed products)
+				if ( $product->status_batch == 2 && $qty > 0 && $this->getBatchCount($fk_product, $batch) > 0 )
+				{
+					$error++;
+					$this->errors[] = $langs->trans("SerialNumberAlreadyInUse", $batch, $product->ref);
+				}
+
 				if ($id_product_batch > 0)
 				{
 					$result = $this->createBatch($id_product_batch, $qty);
@@ -1208,4 +1215,42 @@ class MouvementStock extends CommonObject
 		return $this->deleteCommon($user, $notrigger);
 		//return $this->deleteCommon($user, $notrigger, 1);
 	}
+
+	/**
+	 * Retrieve number of equipments for a product batch
+	 *
+	 * @return int             <0 if KO, number of equipments if OK
+	 */
+	private function getBatchCount($fk_product, $batch)
+	{
+		global $conf;
+
+		$cpt = 0;
+
+        $sql = "SELECT sum(pb.qty) as cpt";
+        $sql .= " FROM ".MAIN_DB_PREFIX."product_batch as pb";
+        $sql .= " LEFT JOIN ".MAIN_DB_PREFIX."product_stock as ps ON ps.rowid = pb.fk_product_stock";
+        $sql .= " WHERE ps.fk_product = " . $fk_product;
+        $sql .= " AND pb.batch = '" . $batch . "'";
+
+        $result = $this->db->query($sql);
+        if ($result) {
+            if ($this->db->num_rows($result)) {
+
+                $obj = $this->db->fetch_object($result);
+
+                $cpt = $obj->cpt;
+
+             }
+
+            $this->db->free($result);
+        }
+        else
+        {
+            dol_print_error($this->db);
+            return -1;
+        }
+
+        return $cpt;
+	}
 }