From 6ab0ec4b1ba6b1b8ce27afdf0de0b59d1b55e1f8 Mon Sep 17 00:00:00 2001 From: phf Date: Fri, 7 Jul 2017 10:22:37 +0200 Subject: [PATCH] Fix travis and rename 2 fields --- htdocs/admin/dict.php | 22 +++-- htdocs/admin/expensereport_ik.php | 18 ++-- htdocs/core/class/html.form.class.php | 8 +- .../class/expensereport_ik.class.php | 24 ++--- .../install/mysql/data/llx_c_exp_tax_cat.sql | 44 ++++----- .../mysql/data/llx_c_exp_tax_range.sql | 30 +++--- htdocs/install/mysql/data/llx_c_type_fees.sql | 2 +- .../mysql/data/llx_expensereport_ik.sql | 30 +++--- .../install/mysql/migration/5.0.0-6.0.0.sql | 96 +++++++++---------- .../mysql/tables/llx_c_exp_tax_range.sql | 4 +- .../mysql/tables/llx_expensereport_ik.sql | 2 +- .../mysql/tables/llx_expensereport_rules.sql | 28 +++--- htdocs/langs/en_US/trips.lang | 7 +- 13 files changed, 160 insertions(+), 155 deletions(-) diff --git a/htdocs/admin/dict.php b/htdocs/admin/dict.php index a52c27b74c1..99b23cbd8d8 100644 --- a/htdocs/admin/dict.php +++ b/htdocs/admin/dict.php @@ -205,7 +205,7 @@ $tabsql[30]= "SELECT rowid, code, name, paper_size, orientation, metric, leftmar $tabsql[33]= "SELECT rowid, pos, code, label, active FROM ".MAIN_DB_PREFIX."c_hrm_department"; $tabsql[34]= "SELECT rowid, pos, code, label, c_level, active FROM ".MAIN_DB_PREFIX."c_hrm_function"; $tabsql[35]= "SELECT c.rowid, c.label, c.active, c.entity FROM ".MAIN_DB_PREFIX."c_exp_tax_cat c"; -$tabsql[36]= "SELECT r.rowid, r.fk_cat, r.range, r.active, r.entity FROM ".MAIN_DB_PREFIX."c_exp_tax_range r"; +$tabsql[36]= "SELECT r.rowid, r.fk_c_exp_tax_cat, r.range_ik, r.active, r.entity FROM ".MAIN_DB_PREFIX."c_exp_tax_range r"; // Criteria to sort dictionaries $tabsqlsort=array(); @@ -244,7 +244,7 @@ $tabsqlsort[30]="code ASC"; $tabsqlsort[33]="code ASC"; $tabsqlsort[34]="code ASC"; $tabsqlsort[35]="c.label ASC"; -$tabsqlsort[36]="r.fk_cat ASC, r.range ASC"; +$tabsqlsort[36]="r.fk_c_exp_tax_cat ASC, r.range_ik ASC"; // Nom des champs en resultat de select pour affichage du dictionnaire $tabfield=array(); @@ -281,7 +281,7 @@ $tabfield[30]= "code,name,paper_size,orientation,metric,leftmargin,topmargin,nx, //$tabfield[31]= "pcg_version,label"; //$tabfield[32]= "code,label,range_account,sens,category_type,formula,position,country_id,country"; $tabfield[35]= "label"; -$tabfield[36]= "range,fk_cat"; +$tabfield[36]= "range_ik,fk_c_exp_tax_cat"; // Nom des champs d'edition pour modification d'un enregistrement $tabfieldvalue=array(); @@ -320,7 +320,7 @@ $tabfieldvalue[30]= "code,name,paper_size,orientation,metric,leftmargin,topmargi $tabfieldvalue[33]= "code,label"; $tabfieldvalue[34]= "code,label"; $tabfieldvalue[35]= "label"; -$tabfieldvalue[36]= "range,fk_cat"; +$tabfieldvalue[36]= "range_ik,fk_c_exp_tax_cat"; // Nom des champs dans la table pour insertion d'un enregistrement $tabfieldinsert=array(); @@ -359,7 +359,7 @@ $tabfieldinsert[30]= "code,name,paper_size,orientation,metric,leftmargin,topmarg $tabfieldinsert[33]= "code,label"; $tabfieldinsert[34]= "code,label"; $tabfieldinsert[35]= "label"; -$tabfieldinsert[36]= "`range`,fk_cat"; +$tabfieldinsert[36]= "range_ik,fk_c_exp_tax_cat"; // Nom du rowid si le champ n'est pas de type autoincrement // Example: "" if id field is "rowid" and has autoincrement on @@ -478,7 +478,7 @@ $tabhelp[30] = array('code'=>$langs->trans("EnterAnyCode"), 'name'=>$langs->tran $tabhelp[33] = array('code'=>$langs->trans("EnterAnyCode")); $tabhelp[34] = array('code'=>$langs->trans("EnterAnyCode")); $tabhelp[35]= array(); -$tabhelp[36]= array('range'=>$langs->trans('PrevRangeToThisRange')); +$tabhelp[36]= array('range_ik'=>$langs->trans('PrevRangeToThisRange')); // List of check for fields (NOT USED YET) $tabfieldcheck=array(); @@ -1086,6 +1086,8 @@ if ($id) if ($fieldlist[$field]=='delay') { $valuetoshow=$langs->trans("NoticePeriod"); } if ($fieldlist[$field]=='newbymonth') { $valuetoshow=$langs->trans("NewByMonth"); } if ($fieldlist[$field]=='fk_tva') { $valuetoshow=$langs->trans("VAT"); } + if ($fieldlist[$field]=='range_ik') { $valuetoshow=$langs->trans("RangeIk"); } + if ($fieldlist[$field]=='fk_c_exp_tax_cat'){ $valuetoshow=$langs->trans("CarCategory"); } if ($id == 2) // Special cas for state page { @@ -1306,6 +1308,8 @@ if ($id) if ($fieldlist[$field]=='delay') { $valuetoshow=$langs->trans("NoticePeriod"); } if ($fieldlist[$field]=='newbymonth') { $valuetoshow=$langs->trans("NewByMonth"); } if ($fieldlist[$field]=='fk_tva') { $valuetoshow=$langs->trans("VAT"); } + if ($fieldlist[$field]=='range_ik') { $valuetoshow=$langs->trans("RangeIk"); } + if ($fieldlist[$field]=='fk_c_exp_tax_cat'){ $valuetoshow=$langs->trans("CarCategory"); } // Affiche nom du champ if ($showfield) @@ -1534,7 +1538,7 @@ if ($id) } } } - elseif (in_array($fieldlist[$field], array('fk_cat', 'fk_exp_tax_cat'))) + elseif ($fieldlist[$field] == 'fk_c_exp_tax_cat') { $valuetoshow = getDictvalue(MAIN_DB_PREFIX.'c_exp_tax_cat', 'label', $valuetoshow); $valuetoshow = $langs->trans($valuetoshow); @@ -1881,10 +1885,10 @@ function fieldList($fieldlist, $obj='', $tabname='', $context='') print $form->load_tva('fk_tva', $obj->taux, $mysoc, new Societe($db), 0, 0, '', false, -1); print ''; } - elseif ($fieldlist[$field] == 'fk_cat') + elseif ($fieldlist[$field] == 'fk_c_exp_tax_cat') { print ''; - print $form->selectExpenseCategories($obj->fk_cat); + print $form->selectExpenseCategories($obj->fk_c_exp_tax_cat); print ''; } elseif ($fieldlist[$field] == 'fk_range') diff --git a/htdocs/admin/expensereport_ik.php b/htdocs/admin/expensereport_ik.php index bb50bfc58f0..9e653dce906 100644 --- a/htdocs/admin/expensereport_ik.php +++ b/htdocs/admin/expensereport_ik.php @@ -47,7 +47,7 @@ $id = GETPOST('id','int'); $offset = GETPOST('offset','int'); $coef = GETPOST('coef','int'); -$fk_cat = GETPOST('fk_cat'); +$fk_c_exp_tax_cat = GETPOST('fk_c_exp_tax_cat'); $fk_range = GETPOST('fk_range'); if ($action == 'updateik') @@ -106,7 +106,7 @@ echo '
'; if ($action == 'edit') { echo ''; - echo ''; + echo ''; echo ''; echo ''; } @@ -115,7 +115,7 @@ echo ''; echo ''; -foreach ($rangesbycateg as $fk_cat => $Tab) +foreach ($rangesbycateg as $fk_c_exp_tax_cat => $Tab) { $title = ($Tab['active'] == 1) ? $langs->trans($Tab['label']) : $form->textwithpicto($langs->trans($Tab['label']), $langs->trans('expenseReportCatDisabled'), 1, 'help', '', 0, 3); echo ''; @@ -132,8 +132,8 @@ foreach ($rangesbycateg as $fk_cat => $Tab) $var = true; foreach ($Tab['ranges'] as $k => $range) { - if (isset($Tab['ranges'][$k+1])) $label = $langs->trans('expenseReportRangeFromTo', $range->range, ($Tab['ranges'][$k+1]->range-1)); - else $label = $langs->trans('expenseReportRangeMoreThan', $range->range); + if (isset($Tab['ranges'][$k+1])) $label = $langs->trans('expenseReportRangeFromTo', $range->range_ik, ($Tab['ranges'][$k+1]->range_ik-1)); + else $label = $langs->trans('expenseReportRangeMoreThan', $range->range_ik); if ($range->range_active == 0) $label = $form->textwithpicto($label, $langs->trans('expenseReportRangeDisabled'), 1, 'help', '', 0, 3); @@ -144,12 +144,12 @@ foreach ($rangesbycateg as $fk_cat => $Tab) // Offset echo ''; // Coef echo ''; @@ -160,14 +160,14 @@ foreach ($rangesbycateg as $fk_cat => $Tab) echo '
'; - if ($action == 'edit' && $range->ik->id == $id && $range->rowid == $fk_range && $range->fk_cat == $fk_cat) echo ''; + if ($action == 'edit' && $range->ik->id == $id && $range->rowid == $fk_range && $range->fk_c_exp_tax_cat == $fk_c_exp_tax_cat) echo ''; else echo $range->ik->offset; echo ''; - if ($action == 'edit' && $range->ik->id == $id && $range->rowid == $fk_range && $range->fk_cat == $fk_cat) echo ''; + if ($action == 'edit' && $range->ik->id == $id && $range->rowid == $fk_range && $range->fk_c_exp_tax_cat == $fk_c_exp_tax_cat) echo ''; else echo ($range->ik->id > 0 ? $range->ik->coef : $langs->trans('expenseReportCoefUndefined')); echo ''; if ($range->range_active == 1) { - if ($action == 'edit' && $range->ik->id == $id && $range->rowid == $fk_range && $range->fk_cat == $fk_cat) + if ($action == 'edit' && $range->ik->id == $id && $range->rowid == $fk_range && $range->fk_c_exp_tax_cat == $fk_c_exp_tax_cat) { echo ''; echo ''; } else { - echo ''.img_edit().''; + echo ''.img_edit().''; if (!empty($range->ik->id)) echo ''.img_delete().''; // TODO add delete link } diff --git a/htdocs/core/class/html.form.class.php b/htdocs/core/class/html.form.class.php index 9285bbd3035..9e93332e7a8 100644 --- a/htdocs/core/class/html.form.class.php +++ b/htdocs/core/class/html.form.class.php @@ -6307,7 +6307,7 @@ class Form * @param array $params param to give * @return string */ - function selectExpenseCategories($selected='', $htmlname='fk_cat', $useempty=0, $excludeid=array(), $target='', $default_selected=0, $params=array()) + function selectExpenseCategories($selected='', $htmlname='fk_c_exp_tax_cat', $useempty=0, $excludeid=array(), $target='', $default_selected=0, $params=array()) { global $db,$conf,$langs; @@ -6335,7 +6335,7 @@ class Form if ($resql) { if ($db->num_rows($resql) > 0) - { dol_buildpath($path); + { $obj = $db->fetch_object($resql); $out.= '