lainwir3d/dolibarr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

FIX 13.0 - error message says MAIN_DISABLE_ALL_MAILS is set when it isn't + unhandled swiftmailer error (failed recipients due to RFC 2822 non-compliance)

Browse Source
This commit is contained in:
Florian Mortgat 2021-05-18 17:57:23 +02:00
parent 0c4884bb2c
commit 6cccd77508
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
htdocs/core/actions_massactions.inc.php
View File

@ -559,8 +559,10 @@ if (!$error && $massaction == 'confirm_presend')
{ {
$resaction .= $langs->trans('ErrorFailedToSendMail', $from, $sendto); $resaction .= $langs->trans('ErrorFailedToSendMail', $from, $sendto);
$resaction .= '<br><div class="error">'.$mailfile->error.'</div>'; $resaction .= '<br><div class="error">'.$mailfile->error.'</div>';
} else { } elseif (!empty($conf->global->MAIN_DISABLE_ALL_MAILS)) {
$resaction .= '<div class="warning">No mail sent. Feature is disabled by option MAIN_DISABLE_ALL_MAILS</div>'; $resaction .= '<div class="warning">No mail sent. Feature is disabled by option MAIN_DISABLE_ALL_MAILS</div>';
} else {
$resaction .= $langs->trans('ErrorFailedToSendMail', $from, $sendto) . '<br><div class="error">(unhandled error)</div>';
} }
} }
} }

5
htdocs/core/class/CMailFile.class.php
View File

@ -894,7 +894,7 @@ class CMailFile
} }
// send mail // send mail
try { try {
$result = $this->mailer->send($this->message); $result = $this->mailer->send($this->message, $failedRecipients);
} catch (Exception $e) { } catch (Exception $e) {
$this->error = $e->getMessage(); $this->error = $e->getMessage();
} }
@ -902,6 +902,9 @@ class CMailFile
$res = true; $res = true;
if (!empty($this->error) || !$result) { if (!empty($this->error) || !$result) {
if (!empty($failedRecipients)) {
$this->error = 'Transport failed for the following addresses: "' . join('", "', $failedRecipients) . '".';
}
dol_syslog("CMailFile::sendfile: mail end error=".$this->error, LOG_ERR); dol_syslog("CMailFile::sendfile: mail end error=".$this->error, LOG_ERR);
$res = false; $res = false;
} else { } else {