From 704bae46a6672aa7a50260e6a6c0ca4df1ff745a Mon Sep 17 00:00:00 2001
From: Marc de Lima Lucio <68746600+marc-dll@users.noreply.github.com>
Date: Mon, 4 Oct 2021 08:51:31 +0200
Subject: [PATCH] FIX: expense report: show link to already existing
 overlapping expense report without adding new parameter

---
 htdocs/expensereport/class/expensereport.class.php | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/htdocs/expensereport/class/expensereport.class.php b/htdocs/expensereport/class/expensereport.class.php
index 8df8b356090..64034c10a3f 100644
--- a/htdocs/expensereport/class/expensereport.class.php
+++ b/htdocs/expensereport/class/expensereport.class.php
@@ -2195,10 +2195,9 @@ class ExpenseReport extends CommonObject
 	 * @param   User       $fuser          User
 	 * @param   integer    $date_debut     Start date
 	 * @param   integer    $date_fin       End date
-	 * @param   bool       $return_id      True to return ID of existing expense report
 	 * @return  int                        <0 if KO, >0 if OK
 	 */
-	public function periode_existe($fuser, $date_debut, $date_fin, $return_id = false)
+	public function periode_existe($fuser, $date_debut, $date_fin)
 	{
 		// phpcs:enable
 		$sql = "SELECT rowid, date_debut, date_fin";
@@ -2221,7 +2220,7 @@ class ExpenseReport extends CommonObject
 					$date_f_req = $this->db->jdate($objp->date_fin); // 4
 
 					if (!($date_f_form < $date_d_req || $date_d_form > $date_f_req)) {
-						return $return_id ? $objp->rowid : 1;
+						return $objp->rowid;
 					}
 
 					$i++;