Fix: Better error management

This commit is contained in:
Laurent Destailleur 2011-10-25 01:57:46 +02:00
parent fed9dd6361
commit 7310c2f461

View File

@ -129,10 +129,15 @@ class ActionComm extends CommonObject
# Get id from code # Get id from code
$cactioncomm=new CActionComm($this->db); $cactioncomm=new CActionComm($this->db);
$result=$cactioncomm->fetch($this->type_code); $result=$cactioncomm->fetch($this->type_code);
if ($result) if ($result > 0)
{ {
$this->type_id=$cactioncomm->id; $this->type_id=$cactioncomm->id;
} }
else if ($result == 0)
{
$this->error='Failed to get record with code AC_OTH from dictionnary "type of events"';
return -1;
}
else else
{ {
$this->error=$cactioncomm->error; $this->error=$cactioncomm->error;
@ -148,7 +153,7 @@ class ActionComm extends CommonObject
} }
$this->db->begin("ActionComm::add"); $this->db->begin();
$sql = "INSERT INTO ".MAIN_DB_PREFIX."actioncomm"; $sql = "INSERT INTO ".MAIN_DB_PREFIX."actioncomm";
$sql.= "(datec,"; $sql.= "(datec,";
@ -208,13 +213,13 @@ class ActionComm extends CommonObject
// Fin appel triggers // Fin appel triggers
} }
$this->db->commit("ActionComm::add"); $this->db->commit();
return $this->id; return $this->id;
} }
else else
{ {
$this->error=$this->db->lasterror().' sql='.$sql; $this->error=$this->db->lasterror().' sql='.$sql;
$this->db->rollback("ActionComm::add"); $this->db->rollback();
return -1; return -1;
} }