From 55757a6b82ef5578d53dbc337e47c6544d05bf62 Mon Sep 17 00:00:00 2001
From: Regis Houssin <regis.houssin@capnetworks.com>
Date: Wed, 27 Mar 2013 20:42:55 +0100
Subject: [PATCH] Fix: $i is global

---
 htdocs/core/boxes/box_activity.php  | 23 +++++++----------------
 htdocs/core/boxes/modules_boxes.php |  2 +-
 2 files changed, 8 insertions(+), 17 deletions(-)

diff --git a/htdocs/core/boxes/box_activity.php b/htdocs/core/boxes/box_activity.php
index 1977e41970a..87e555958e8 100644
--- a/htdocs/core/boxes/box_activity.php
+++ b/htdocs/core/boxes/box_activity.php
@@ -41,18 +41,9 @@ class box_activity extends ModeleBoxes
 	var $info_box_head = array();
 	var $info_box_contents = array();
 
-	/**
-	 *	Constructor
-	 */
-	function __construct($db)
-	{
-		$this->db = $db;
-
-		$this->enabled = 1;
-		// FIXME: Use a cache to save data because this slow down too much main home page. This box slow down too seriously software.
-		// FIXME: Removed number_format (not compatible with all languages)
-		// FIXME: Pb into some status
-	}
+	// FIXME: Use a cache to save data because this slow down too much main home page. This box slow down too seriously software.
+	// FIXME: Removed number_format (not compatible with all languages)
+	// FIXME: Pb into some status
 
 	/**
 	 *  Charge les donnees en memoire pour affichage ulterieur
@@ -66,6 +57,7 @@ class box_activity extends ModeleBoxes
 
 		$totalMnt = 0;
 		$totalnb = 0;
+		$i = 0;
 
 		include_once DOL_DOCUMENT_ROOT.'/core/lib/date.lib.php';
 
@@ -99,7 +91,6 @@ class box_activity extends ModeleBoxes
 			if ($result)
 			{
 				$num = $db->num_rows($result);
-				$i = 0;
 				while ($i < $num)
 				{
 					$this->info_box_contents[$i][0] = array('td' => 'align="left" width="16"', 'logo' => 'bill');
@@ -140,7 +131,7 @@ class box_activity extends ModeleBoxes
 			$result = $db->query($sql);
 			if ($result)
 			{
-				$num = $db->num_rows($result)+$i;
+				$num = $db->num_rows($result) + $i;
 				$now=dol_now();
 
 				while ($i < $num)
@@ -195,7 +186,7 @@ class box_activity extends ModeleBoxes
 
 			if ($result)
 			{
-				$num = $db->num_rows($result)+$i;
+				$num = $db->num_rows($result) + $i;
 				while ($i < $num)
 				{
 					$this->info_box_contents[$i][0] = array('td' => 'align="left" width="16"','logo' => 'object_order');
@@ -246,7 +237,7 @@ class box_activity extends ModeleBoxes
 
 			if ($result)
 			{
-				$num = $db->num_rows($result)+$i;
+				$num = $db->num_rows($result) + $i;
 				while ($i < $num)
 				{
 					$this->info_box_contents[$i][0] = array('td' => 'align="left" width="16"','logo' => 'object_propal');
diff --git a/htdocs/core/boxes/modules_boxes.php b/htdocs/core/boxes/modules_boxes.php
index ad901b42ca9..7ca1b1dd4a2 100644
--- a/htdocs/core/boxes/modules_boxes.php
+++ b/htdocs/core/boxes/modules_boxes.php
@@ -33,7 +33,7 @@ class ModeleBoxes    // Can't be abtract as it is instanciated to build "empty"
 	var $error='';
 	var $max=5;
 	var $enabled=1;
-	
+
 	var $rowid;
 	var $id;
 	var $position;