lainwir3d/dolibarr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix issues identified by CI in pull request.

Browse Source
This commit is contained in:
mc2contributor 2023-04-28 10:07:46 -06:00 committed by GitHub
parent 034f1167fd
commit 7a8fd37a4a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
htdocs/projet/class/api_tasks.class.php
View File

@ -584,7 +584,7 @@ class Tasks extends DolibarrApi
if (!DolibarrApiAccess::$user->rights->projet->creer) { if (!DolibarrApiAccess::$user->rights->projet->creer) {
throw new RestException(401); throw new RestException(401);
} }
$this->_timespentRecordChecks($id, $timespent_id); $this->timespentRecordChecks($id, $timespent_id);
if (!DolibarrApi::_checkAccessToResource('task', $this->task->id)) { if (!DolibarrApi::_checkAccessToResource('task', $this->task->id)) {
throw new RestException(401, 'Access not allowed for login '.DolibarrApiAccess::$user->login); throw new RestException(401, 'Access not allowed for login '.DolibarrApiAccess::$user->login);
@ -624,12 +624,12 @@ class Tasks extends DolibarrApi
* *
* @return array * @return array
*/ */
public function deleteTimeSpent($id, $timespent_id, $user_id) public function deleteTimeSpent($id, $timespent_id)
{ {
if (!DolibarrApiAccess::$user->rights->projet->supprimer) { if (!DolibarrApiAccess::$user->rights->projet->supprimer) {
throw new RestException(401); throw new RestException(401);
} }
$this->_timespentRecordChecks($id, $timespent_id); $this->timespentRecordChecks($id, $timespent_id);
if (!DolibarrApi::_checkAccessToResource('task', $this->task->id)) { if (!DolibarrApi::_checkAccessToResource('task', $this->task->id)) {
throw new RestException(401, 'Access not allowed for login '.DolibarrApiAccess::$user->login); throw new RestException(401, 'Access not allowed for login '.DolibarrApiAccess::$user->login);
@ -647,7 +647,14 @@ class Tasks extends DolibarrApi
); );
} }
protected function _timespentRecordChecks($id, $timespent_id) /**
* Validate task & timespent IDs for timespent API methods.
* Loads the selected task & timespent records.
*
* @param int $id Task ID
* @param int $timespent_id Time spent ID (llx_projet_task_time.rowid)
*/
protected function timespentRecordChecks($id, $timespent_id)
{ {
if ($this->task->fetch($id) <= 0) { if ($this->task->fetch($id) <= 0) {
throw new RestException(404, 'Task not found'); throw new RestException(404, 'Task not found');