lainwir3d/dolibarr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Removed SQL errors as they are logged by the database handler

Browse Source
This commit is contained in:
Marcos García de La Fuente 2014-06-12 13:49:05 +02:00
parent d1d4c6d8a5
commit 7e7958cf73
31 changed files with 22 additions and 70 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
htdocs/categories/class/categorie.class.php
View File

@ -185,7 +185,7 @@ class Categorie extends CommonObject
$sql.= $conf->entity;
$sql.= ")";
dol_syslog(get_class($this).'::create sql='.$sql);
dol_syslog(get_class($this).'::create', LOG_DEBUG);
$res = $this->db->query($sql);
if ($res)
{
@ -232,7 +232,6 @@ class Categorie extends CommonObject
else
{
$this->error=$this->db->error();
dol_syslog(get_class($this)."::create error ".$this->error." sql=".$sql, LOG_ERR);
$this->db->rollback();
return -1;
}
@ -346,7 +345,6 @@ class Categorie extends CommonObject
if (!$this->db->query($sql))
{
$this->error=$this->db->lasterror();
dol_syslog("Error sql=".$sql." ".$this->error, LOG_ERR);
$error++;
}
}
@ -357,7 +355,6 @@ class Categorie extends CommonObject
if (!$this->db->query($sql))
{
$this->error=$this->db->lasterror();
dol_syslog("Error sql=".$sql." ".$this->error, LOG_ERR);
$error++;
}
}
@ -368,7 +365,6 @@ class Categorie extends CommonObject
if (!$this->db->query($sql))
{
$this->error=$this->db->lasterror();
dol_syslog("Error sql=".$sql." ".$this->error, LOG_ERR);
$error++;
}
}
@ -379,7 +375,6 @@ class Categorie extends CommonObject
if (!$this->db->query($sql))
{
$this->error=$this->db->lasterror();
dol_syslog("Error sql=".$sql." ".$this->error, LOG_ERR);
$error++;
}
}
@ -390,7 +385,6 @@ class Categorie extends CommonObject
if (!$this->db->query($sql))
{
$this->error=$this->db->lasterror();
dol_syslog("Error sql=".$sql." ".$this->error, LOG_ERR);
$error++;
}
}
@ -401,7 +395,6 @@ class Categorie extends CommonObject
if (!$this->db->query($sql))
{
$this->error=$this->db->lasterror();
dol_syslog("Error sql=".$sql." ".$this->error, LOG_ERR);
$error++;
}
}
@ -414,7 +407,6 @@ class Categorie extends CommonObject
if (!$this->db->query($sql))
{
$this->error=$this->db->lasterror();
dol_syslog("Error sql=".$sql." ".$this->error, LOG_ERR);
$error++;
}
else
@ -1006,7 +998,6 @@ class Categorie extends CommonObject
else
{
$this->error=$this->db->error();
dol_syslog(get_class($this)."::already_exists error ".$this->error." sql=".$sql, LOG_ERR);
return -1;
}
}

2
htdocs/comm/propal/class/propal.class.php
View File

@ -2955,7 +2955,6 @@ class PropaleLigne extends CommonObject
else
{
$this->error=$this->db->error()." sql=".$sql;
dol_syslog(get_class($this).'::insert Error '.$this->error, LOG_ERR);
$this->db->rollback();
return -1;
}
@ -3006,7 +3005,6 @@ class PropaleLigne extends CommonObject
else
{
$this->error=$this->db->error()." sql=".$sql;
dol_syslog("PropaleLigne::delete Error ".$this->error, LOG_ERR);
$this->db->rollback();
return -1;
}

1
htdocs/commande/class/commande.class.php
View File

@ -233,7 +233,6 @@ class Commande extends CommonOrder
$resql=$this->db->query($sql);
if (! $resql)
{
dol_syslog(get_class($this)."::valid Echec update - 10 - sql=".$sql, LOG_ERR);
dol_print_error($this->db);
$error++;
}

2
htdocs/compta/bank/class/account.class.php
View File

@ -448,12 +448,10 @@ class Account extends CommonObject
if ($this->db->errno() == 'DB_ERROR_RECORD_ALREADY_EXISTS')
{
$this->error=$langs->trans("ErrorBankLabelAlreadyExists");
dol_syslog($this->error, LOG_ERR);
return -1;
}
else {
$this->error=$this->db->error()." sql=".$sql;
dol_syslog($this->error, LOG_ERR);
return -2;
}
}

1
htdocs/compta/facture/class/facture-rec.class.php
View File

@ -507,7 +507,6 @@ class FactureRec extends Facture
else
{
$this->error=$this->db->lasterror();
dol_syslog("FactureRec::addline sql=".$this->error, LOG_ERR);
return -1;
}
}

16
htdocs/compta/facture/class/facture.class.php
View File

@ -516,7 +516,6 @@ class Facture extends CommonInvoice
else
{
$this->error=$this->db->error();
dol_syslog(get_class($this)."::create error ".$this->error." sql=".$sql, LOG_ERR);
$this->db->rollback();
return -1;
}
@ -1315,7 +1314,6 @@ class Facture extends CommonInvoice
if (! $this->db->query($sql))
{
$this->error=$this->db->error()." sql=".$sql;
dol_syslog(get_class($this)."::delete ".$this->error, LOG_ERR);
$this->db->rollback();
return -5;
}
@ -1344,9 +1342,15 @@ class Facture extends CommonInvoice
// Delete invoice line
$sql = 'DELETE FROM '.MAIN_DB_PREFIX.'facturedet WHERE fk_facture = '.$rowid;
dol_syslog(get_class($this)."::delete", LOG_DEBUG);
if ($this->db->query($sql) && $this->delete_linked_contact())
{
$sql = 'DELETE FROM '.MAIN_DB_PREFIX.'facture WHERE rowid = '.$rowid;
dol_syslog(get_class($this)."::delete", LOG_DEBUG);
$resql=$this->db->query($sql);
if ($resql)
{
@ -1384,7 +1388,6 @@ class Facture extends CommonInvoice
else
{
$this->error=$this->db->lasterror()." sql=".$sql;
dol_syslog(get_class($this)."::delete ".$this->error, LOG_ERR);
$this->db->rollback();
return -6;
}
@ -1392,7 +1395,6 @@ class Facture extends CommonInvoice
else
{
$this->error=$this->db->lasterror()." sql=".$sql;
dol_syslog(get_class($this)."::delete ".$this->error, LOG_ERR);
$this->db->rollback();
return -4;
}
@ -1400,7 +1402,6 @@ class Facture extends CommonInvoice
else
{
$this->error=$this->db->lasterror();
dol_syslog(get_class($this)."::delete ".$this->error, LOG_ERR);
$this->db->rollback();
return -2;
}
@ -1771,7 +1772,6 @@ class Facture extends CommonInvoice
$resql=$this->db->query($sql);
if (! $resql)
{
dol_syslog(get_class($this)."::validate Echec update - 10 - sql=".$sql, LOG_ERR);
dol_print_error($this->db);
$error++;
}
@ -3255,7 +3255,7 @@ class Facture extends CommonInvoice
$sql.= ' WHERE l.fk_facture = '.$this->id;
$sql.= ' ORDER BY l.rang ASC, l.rowid';
dol_syslog(get_class($this).'::getLinesArray sql='.$sql,LOG_DEBUG);
dol_syslog(get_class($this).'::getLinesArray',LOG_DEBUG);
$resql = $this->db->query($sql);
if ($resql)
{
@ -3305,7 +3305,6 @@ class Facture extends CommonInvoice
else
{
$this->error=$this->db->error();
dol_syslog("Error sql=".$sql.", error=".$this->error,LOG_ERR);
return -1;
}
}
@ -3802,7 +3801,6 @@ class FactureLigne extends CommonInvoiceLine
else
{
$this->error=$this->db->error()." sql=".$sql;
dol_syslog(get_class($this)."::delete Error ".$this->error, LOG_ERR);
$this->db->rollback();
return -1;
}

3
htdocs/compta/prelevement/class/bonprelevement.class.php
View File

@ -314,7 +314,6 @@ class BonPrelevement extends CommonObject
}
else
{
dol_syslog(get_class($this)."::Fetch Erreur sql=".$sql, LOG_ERR);
return -2;
}
}
@ -705,6 +704,7 @@ class BonPrelevement extends CommonObject
//if ($banque) $sql.= " AND sr.code_banque = '".$conf->global->PRELEVEMENT_CODE_BANQUE."'";
//if ($agence) $sql.= " AND sr.code_guichet = '".$conf->global->PRELEVEMENT_CODE_GUICHET."'";
dol_syslog(get_class($this)."::SommeAPrelever");
$resql = $this->db->query($sql);
if ( $resql )
@ -718,7 +718,6 @@ class BonPrelevement extends CommonObject
else
{
$this->error=get_class($this)."::SommeAPrelever Erreur -1 sql=".$this->db->error();
dol_syslog($this->error, LOG_ERR);
return -1;
}
}

2
htdocs/contact/class/contact.class.php
View File

@ -729,7 +729,7 @@ class Contact extends CommonObject
$sqldel = "DELETE FROM ".MAIN_DB_PREFIX."element_contact";
$sqldel.=" WHERE rowid = ".$obj->rowid;
dol_syslog(get_class($this)."::delete sql=".$sqldel);
dol_syslog(get_class($this)."::delete", LOG_DEBUG);
$result = $this->db->query($sqldel);
if (! $result)
{

2
htdocs/contrat/class/contrat.class.php
View File

@ -319,7 +319,6 @@ class Contrat extends CommonObject
$resql = $this->db->query($sql);
if (! $resql)
{
dol_syslog(get_class($this)."::validate Echec update - 10 - sql=".$sql, LOG_ERR);
dol_print_error($this->db);
$error++;
}
@ -1089,7 +1088,6 @@ class Contrat extends CommonObject
{
$this->db->rollback();
$this->error=$this->db->error()." sql=".$sql;
dol_syslog(get_class($this)."::addline ".$this->error,LOG_ERR);
return -1;
}
}

5
htdocs/core/class/commonobject.class.php
View File

@ -2158,12 +2158,11 @@ abstract class CommonObject
$this->db->begin();
$sql_del = "DELETE FROM ".MAIN_DB_PREFIX.$this->table_element."_extrafields WHERE fk_object = ".$this->id;
dol_syslog(get_class($this)."::deleteExtraFields delete sql=".$sql_del);
dol_syslog(get_class($this)."::deleteExtraFields delete", LOG_DEBUG);
$resql=$this->db->query($sql_del);
if (! $resql)
{
$this->error=$this->db->lasterror();
dol_syslog(get_class($this)."::deleteExtraFields ".$this->error,LOG_ERR);
$this->db->rollback();
return -1;
}
@ -2229,7 +2228,7 @@ abstract class CommonObject
$this->db->begin();
$sql_del = "DELETE FROM ".MAIN_DB_PREFIX.$this->table_element."_extrafields WHERE fk_object = ".$this->id;
dol_syslog(get_class($this)."::insertExtraFields delete sql=".$sql_del);
dol_syslog(get_class($this)."::insertExtraFields delete", LOG_DEBUG);
$this->db->query($sql_del);
$sql = "INSERT INTO ".MAIN_DB_PREFIX.$this->table_element."_extrafields (fk_object";
foreach($this->array_options as $key => $value)

2
htdocs/core/class/extrafields.class.php
View File

@ -454,7 +454,7 @@ class ExtraFields
$sql_del.= " WHERE name = '".$attrname."'";
$sql_del.= " AND entity = ".$conf->entity;
$sql_del.= " AND elementtype = '".$elementtype."'";
dol_syslog(get_class($this)."::update_label sql=".$sql_del);
dol_syslog(get_class($this)."::update_label", LOG_DEBUG);
$resql1=$this->db->query($sql_del);
$sql = "INSERT INTO ".MAIN_DB_PREFIX."extrafields(";

1
htdocs/core/class/link.class.php
View File

@ -136,7 +136,6 @@ class Link extends CommonObject
else
{
$this->error=$this->db->lasterror();
dol_syslog(get_class($this)."::Create fails insert sql=".$sql, LOG_ERR);
$result=-2;
}
$this->db->rollback();

1
htdocs/core/lib/security.lib.php
View File

@ -470,7 +470,6 @@ function restrictedArea($user, $features, $objectid=0, $dbtablename='', $feature
}
else
{
dol_syslog("security.lib:restrictedArea sql=".$sql, LOG_ERR);
accessforbidden();
}
}

5
htdocs/core/modules/DolibarrModules.class.php
View File

@ -188,12 +188,11 @@ abstract class DolibarrModules
{
if (! $err)
{
dol_syslog(get_class($this)."::_remove sql=".$array_sql[$i], LOG_DEBUG);
dol_syslog(get_class($this)."::_remove", LOG_DEBUG);
$result=$this->db->query($array_sql[$i]);
if (! $result)
{
$this->error=$this->db->error();
dol_syslog(get_class($this)."::_remove Error ".$this->error, LOG_ERR);
$err++;
}
}
@ -859,7 +858,7 @@ abstract class DolibarrModules
$sql_del.= " WHERE ".$this->db->decrypt('name')." = '".$this->const_name."'";
$sql_del.= " AND entity IN (0,".$entity.")";
dol_syslog(get_class($this)."::insert_permissions sql=".$sql_del);
dol_syslog(get_class($this)."::insert_permissions", LOG_DEBUG);
$resql=$this->db->query($sql_del);
if ($resql)
{

1
htdocs/core/modules/facture/mod_facture_mars.php
View File

@ -153,7 +153,6 @@ class mod_facture_mars extends ModeleNumRefFactures
}
else
{
dol_syslog(get_class($this)."::getNextValue sql=".$sql, LOG_ERR);
return -1;
}

1
htdocs/core/modules/facture/mod_facture_terre.php
View File

@ -169,7 +169,6 @@ class mod_facture_terre extends ModeleNumRefFactures
}
else
{
dol_syslog(get_class($this)."::getNextValue sql=".$sql, LOG_ERR);
return -1;
}

1
htdocs/core/modules/livraison/mod_livraison_jade.php
View File

@ -127,7 +127,6 @@ class mod_livraison_jade extends ModeleNumRefDeliveryOrder
}
else
{
dol_syslog("mod_livraison_jade::getNextValue sql=".$sql, LOG_ERR);
return -1;
}

6
htdocs/core/modules/mailings/contacts4.modules.php
View File

@ -89,7 +89,7 @@ class mailing_contacts4 extends MailingTargets
if ($filtersarray[0] <> 'all') $sql.= " AND c.label = '".$this->db->escape($filtersarray[0])."'";
$sql.= " ORDER BY sp.lastname, sp.firstname";
dol_syslog(get_class($this).':: add_to_target sql='.$sql,LOG_DEBUG);
dol_syslog(get_class($this).':: add_to_target',LOG_DEBUG);
$resql = $this->db->query($sql);
if ($resql)
{
@ -115,7 +115,6 @@ class mailing_contacts4 extends MailingTargets
}
}else {
$this->error=$this->db->lasterrno();
dol_syslog(get_class($this)."Error sql=".$sql." ".$this->error, LOG_ERR);
return -1;
}
@ -215,7 +214,7 @@ class mailing_contacts4 extends MailingTargets
$resql = $this->db->query($sql);
dol_syslog(get_class($this).':: formFilter sql='.$sql,LOG_DEBUG);
dol_syslog(get_class($this).':: formFilter',LOG_DEBUG);
if ($resql) {
$s='';
$s.='<select name="filter" class="flat">';
@ -236,7 +235,6 @@ class mailing_contacts4 extends MailingTargets
}
else {
$this->error=$this->db->lasterrno();
dol_syslog("Error sql=".$sql." ".$this->error, LOG_ERR);
return -1;
}

3
htdocs/core/modules/societe/mod_codeclient_monkey.php
View File

@ -124,6 +124,8 @@ class mod_codeclient_monkey extends ModeleThirdPartyCode
$sql.= " WHERE ".$field." LIKE '".$prefix."____-%'";
$sql.= " AND entity IN (".getEntity('societe', 1).")";
dol_syslog(get_class($this)."::getNextValue", LOG_DEBUG);
$resql=$db->query($sql);
if ($resql)
{
@ -133,7 +135,6 @@ class mod_codeclient_monkey extends ModeleThirdPartyCode
}
else
{
dol_syslog(get_class($this)."::getNextValue sql=".$sql, LOG_ERR);
return -1;
}

1
htdocs/core/modules/societe/mod_codecompta_aquarium.php
View File

@ -178,7 +178,6 @@ class mod_codecompta_aquarium extends ModeleAccountancyCode
else
{
$this->error=$db->error()." sql=".$sql;
dol_syslog("mod_codecompta_aquarium::verif error".$this->error, LOG_ERR);
return -1; // Erreur
}
}

1
htdocs/core/modules/supplier_invoice/mod_facture_fournisseur_cactus.php
View File

@ -127,7 +127,6 @@ class mod_facture_fournisseur_cactus extends ModeleNumRefSuppliersInvoices
}
else
{
dol_syslog(get_class($this)."::getNextValue sql=".$sql, LOG_ERR);
return -1;
}

1
htdocs/expedition/class/expedition.class.php
View File

@ -549,7 +549,6 @@ class Expedition extends CommonObject
$resql=$this->db->query($sql);
if (! $resql)
{
dol_syslog(get_class($this)."::valid Echec update - 10 - sql=".$sql, LOG_ERR);
$this->error=$this->db->lasterror();
$error++;
}

1
htdocs/exports/class/export.class.php
View File

@ -592,7 +592,6 @@ class Export
else
{
$this->error=$this->db->error()." - sql=".$sql;
dol_syslog("Export::build_file Error: ".$this->error, LOG_ERR);
return -1;
}
}

4
htdocs/fichinter/class/fichinter.class.php
View File

@ -409,7 +409,6 @@ class Fichinter extends CommonObject
$resql=$this->db->query($sql);
if (! $resql)
{
dol_syslog(get_class($this)."::setValid Echec update - 10 - sql=".$sql, LOG_ERR);
dol_print_error($this->db);
$error++;
}
@ -1160,7 +1159,6 @@ class FichinterLigne
else
{
$this->error=$this->db->error()." sql=".$sql;
dol_syslog("FichinterLigne::insert Error ".$this->error, LOG_ERR);
$this->db->rollback();
return -1;
}
@ -1301,7 +1299,6 @@ class FichinterLigne
$sql = "DELETE FROM ".MAIN_DB_PREFIX."fichinterdet WHERE rowid = ".$this->rowid;
$resql = $this->db->query($sql);
dol_syslog(get_class($this)."::deleteline", LOG_DEBUG);
if ($resql)
{
@ -1333,7 +1330,6 @@ class FichinterLigne
else
{
$this->error=$this->db->error()." sql=".$sql;
dol_syslog(get_class($this)."::deleteline Error ".$this->error, LOG_ERR);
$this->db->rollback();
return -1;
}

3
htdocs/fourn/class/fournisseur.commande.class.php
View File

@ -259,14 +259,12 @@ class CommandeFournisseur extends CommonOrder
else
{
$this->error=$this->db->error()." sql=".$sql;
dol_syslog(get_class($this)."::fetch ".$this->error, LOG_ERR);
return -1;
}
}
else
{
$this->error=$this->db->error()." sql=".$sql;
dol_syslog(get_class($this)."::fetch ".$this->error, LOG_ERR);
return -1;
}
}
@ -346,7 +344,6 @@ class CommandeFournisseur extends CommonOrder
$resql=$this->db->query($sql);
if (! $resql)
{
dol_syslog(get_class($this)."::valid Echec update - 10 - sql=".$sql, LOG_ERR);
dol_print_error($this->db);
$error++;
}

2
htdocs/install/upgrade2.php
View File

@ -1148,7 +1148,7 @@ function migrate_paiementfourn_facturefourn($db,$langs,$conf)
$select_sql.= ' FROM '.MAIN_DB_PREFIX.'paiementfourn';
$select_sql.= ' WHERE fk_facture_fourn IS NOT NULL';
dolibarr_install_syslog("upgrade2::migrate_paiementfourn_facturefourn sql=".$select_sql);
dolibarr_install_syslog("upgrade2::migrate_paiementfourn_facturefourn", LOG_DEBUG);
$select_resql = $db->query($select_sql);
if ($select_resql)
{

3
htdocs/livraison/class/livraison.class.php
View File

@ -195,7 +195,6 @@ class Livraison extends CommonObject
{
$error++;
$this->error=$this->db->lasterror()." - sql=".$this->db->lastqueryerror;
dol_syslog("Livraison::create Error -3 ".$this->error, LOG_ERR);
$this->db->rollback();
return -3;
}
@ -204,7 +203,6 @@ class Livraison extends CommonObject
{
$error++;
$this->error=$this->db->lasterror()." - sql=".$this->db->lastqueryerror;
dol_syslog("Livraison::create Error -2 ".$this->error, LOG_ERR);
$this->db->rollback();
return -2;
}
@ -213,7 +211,6 @@ class Livraison extends CommonObject
{
$error++;
$this->error=$this->db->lasterror()." - sql=".$this->db->lastqueryerror;
dol_syslog("Livraison::create Error -1 ".$this->error, LOG_ERR);
$this->db->rollback();
return -1;
}

1
htdocs/societe/class/address.class.php
View File

@ -219,7 +219,6 @@ class Address
else
{
$this->error=$this->db->lasterror();
dol_syslog(get_class($this)."::Update error sql=".$sql, LOG_ERR);
$result=-2;
}
$this->db->rollback();

4
htdocs/societe/class/societe.class.php
View File

@ -472,7 +472,6 @@ class Societe extends CommonObject
else
{
$this->error=$this->db->lasterror();
dol_syslog(get_class($this)."::Create fails insert sql=".$sql, LOG_ERR);
$result=-2;
}
$this->db->rollback();
@ -884,9 +883,6 @@ class Societe extends CommonObject
}
else
{
$this->error = $langs->trans("Error", LOG_DEBUG);
dol_syslog(get_class($this)."::Update fails update sql=".$sql, LOG_ERR);
$result = -2;
}
$this->db->rollback();

3
htdocs/user/class/user.class.php
View File

@ -251,7 +251,6 @@ class User extends CommonObject
else
{
$this->error=$this->db->error();
dol_syslog(get_class($this)."::fetch Error -1, fails to get user - ".$this->error." - sql=".$sql, LOG_ERR);
return -1;
}
@ -279,7 +278,7 @@ class User extends CommonObject
else
{
$this->error=$this->db->error();
dol_syslog(get_class($this)."::fetch Error -2, fails to get setup user - ".$this->error." - sql=".$sql, LOG_ERR);
dol_syslog(get_class($this)."::fetch Error -2, fails to get setup user", LOG_ERR);
return -2;
}
}

2
scripts/emailings/mailing-send.php
View File

@ -280,7 +280,7 @@ if ($resql)
$sqlenddate="UPDATE ".MAIN_DB_PREFIX."mailing SET statut=".$statut." WHERE rowid=".$id;
dol_syslog("update global status sql=".$sqlenddate, LOG_DEBUG);
dol_syslog("update global status", LOG_DEBUG);
print "Update status of emailing id ".$id." to ".$statut."\n";
$resqlenddate=$db->query($sqlenddate);
if (! $resqlenddate)