Re-add set_date_livraison as a deprecated function.

Use correct naming convention for new method naming.
This commit is contained in:
Francis Appels 2020-10-26 16:50:52 +01:00
parent 82db2636f0
commit 7fa7f0a390
15 changed files with 93 additions and 24 deletions

View File

@ -287,7 +287,7 @@ if (empty($reshook))
dol_print_error($db, $object->error);
} elseif ($action == 'setdate_livraison' && $usercancreate)
{
$result = $object->set_delivery_date($user, dol_mktime(12, 0, 0, $_POST['date_livraisonmonth'], $_POST['date_livraisonday'], $_POST['date_livraisonyear']));
$result = $object->setDeliveryDate($user, dol_mktime(12, 0, 0, $_POST['date_livraisonmonth'], $_POST['date_livraisonday'], $_POST['date_livraisonyear']));
if ($result < 0)
dol_print_error($db, $object->error);
} // Positionne ref client

View File

@ -2060,8 +2060,22 @@ class Propal extends CommonObject
}
}
// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
/**
* Set delivery date
*
* @param User $user Object user that modify
* @param int $delivery_date Delivery date
* @param int $notrigger 1=Does not execute triggers, 0= execute triggers
* @return int <0 if ko, >0 if ok
* @deprecated Use setDeliveryDate
*/
public function set_date_livraison($user, $delivery_date, $notrigger = 0)
{
return $this->setDeliveryDate($user, $delivery_date, $notrigger);
}
/**
* Set delivery date
*
* @param User $user Object user that modify
@ -2069,7 +2083,7 @@ class Propal extends CommonObject
* @param int $notrigger 1=Does not execute triggers, 0= execute triggers
* @return int <0 if ko, >0 if ok
*/
public function set_delivery_date($user, $delivery_date, $notrigger = 0)
public function setDeliveryDate($user, $delivery_date, $notrigger = 0)
{
// phpcs:enable
if (!empty($user->rights->propal->creer))

View File

@ -541,7 +541,7 @@ if (empty($reshook))
$datedelivery = dol_mktime(GETPOST('liv_hour', 'int'), GETPOST('liv_min', 'int'), 0, GETPOST('liv_month', 'int'), GETPOST('liv_day', 'int'), GETPOST('liv_year', 'int'));
$object->fetch($id);
$result = $object->set_delivery_date($user, $datedelivery);
$result = $object->setDeliveryDate($user, $datedelivery);
if ($result < 0) {
setEventMessages($object->error, $object->errors, 'errors');
}

View File

@ -2548,6 +2548,20 @@ class Commande extends CommonOrder
}
// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
/**
* Set delivery date
*
* @param User $user Object user that modify
* @param int $delivery_date Delivery date
* @param int $notrigger 1=Does not execute triggers, 0= execute triggers
* @return int <0 if ko, >0 if ok
* @deprecated Use setDeliveryDate
*/
public function set_date_livraison($user, $delivery_date, $notrigger = 0)
{
return $this->setDeliveryDate($user, $delivery_date, $notrigger);
}
/**
* Set the planned delivery date
*
@ -2556,7 +2570,7 @@ class Commande extends CommonOrder
* @param int $notrigger 1=Does not execute triggers, 0= execute triggers
* @return int <0 si ko, >0 si ok
*/
public function set_delivery_date($user, $delivery_date, $notrigger = 0)
public function setDeliveryDate($user, $delivery_date, $notrigger = 0)
{
// phpcs:enable
if ($user->rights->commande->creer)

View File

@ -171,7 +171,7 @@ if ($action == 'confirm_delete' && $confirm == 'yes' && $user->rights->expeditio
if ($action == 'setdate_livraison' && $user->rights->expedition->delivery->creer)
{
$datedelivery = dol_mktime(GETPOST('liv_hour', 'int'), GETPOST('liv_min', 'int'), 0, GETPOST('liv_month', 'int'), GETPOST('liv_day', 'int'), GETPOST('liv_year', 'int'));
$result = $object->set_delivery_date($user, $datedelivery);
$result = $object->setDeliveryDate($user, $datedelivery);
if ($result < 0)
{
$mesg = '<div class="error">'.$object->error.'</div>';

View File

@ -1007,7 +1007,7 @@ class Delivery extends CommonObject
* @param integer $delivery_date Delivery date
* @return int <0 if KO, >0 if OK
*/
public function set_delivery_date($user, $delivery_date)
public function setDeliveryDate($user, $delivery_date)
{
// phpcs:enable
if ($user->rights->expedition->creer)
@ -1016,7 +1016,7 @@ class Delivery extends CommonObject
$sql .= " SET date_delivery = ".($delivery_date ? "'".$this->db->idate($delivery_date)."'" : 'null');
$sql .= " WHERE rowid = ".$this->id;
dol_syslog(get_class($this)."::set_delivery_date", LOG_DEBUG);
dol_syslog(get_class($this)."::setDeliveryDate", LOG_DEBUG);
$resql = $this->db->query($sql);
if ($resql)
{

View File

@ -479,7 +479,7 @@ if (empty($reshook))
$datedelivery = dol_mktime(GETPOST('liv_hour', 'int'), GETPOST('liv_min', 'int'), 0, GETPOST('liv_month', 'int'), GETPOST('liv_day', 'int'), GETPOST('liv_year', 'int'));
$object->fetch($id);
$result = $object->set_delivery_date($user, $datedelivery);
$result = $object->setDeliveryDate($user, $datedelivery);
if ($result < 0)
{
setEventMessages($object->error, $object->errors, 'errors');

View File

@ -1957,15 +1957,29 @@ class Expedition extends CommonObject
}
}
// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
/**
* Set delivery date
*
* @param User $user Object user that modify
* @param int $delivery_date Delivery date
* @param int $notrigger 1=Does not execute triggers, 0= execute triggers
* @return int <0 if ko, >0 if ok
* @deprecated Use setDeliveryDate
*/
public function set_date_livraison($user, $delivery_date, $notrigger = 0)
{
return $this->setDeliveryDate($user, $delivery_date, $notrigger);
}
/**
* Set the planned delivery date
*
* @param User $user Objet user that modify
* @param integer $delivery_date Date of delivery
* @return int <0 if KO, >0 if OK
*/
public function set_delivery_date($user, $delivery_date)
public function setDeliveryDate($user, $delivery_date)
{
// phpcs:enable
if ($user->rights->expedition->creer)
@ -1974,7 +1988,7 @@ class Expedition extends CommonObject
$sql .= " SET date_delivery = ".($delivery_date ? "'".$this->db->idate($delivery_date)."'" : 'null');
$sql .= " WHERE rowid = ".$this->id;
dol_syslog(get_class($this)."::set_delivery_date", LOG_DEBUG);
dol_syslog(get_class($this)."::setDeliveryDate", LOG_DEBUG);
$resql = $this->db->query($sql);
if ($resql)
{

View File

@ -108,7 +108,7 @@ if (empty($reshook))
$datedelivery = dol_mktime(GETPOST('liv_hour', 'int'), GETPOST('liv_min', 'int'), 0, GETPOST('liv_month', 'int'), GETPOST('liv_day', 'int'), GETPOST('liv_year', 'int'));
$object->fetch($id);
$result = $object->set_delivery_date($user, $datedelivery);
$result = $object->setDeliveryDate($user, $datedelivery);
if ($result < 0)
{
setEventMessages($object->error, $object->errors, 'errors');

View File

@ -2258,6 +2258,20 @@ class CommandeFournisseur extends CommonOrder
}
// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
/**
* Set delivery date
*
* @param User $user Object user that modify
* @param int $delivery_date Delivery date
* @param int $notrigger 1=Does not execute triggers, 0= execute triggers
* @return int <0 if ko, >0 if ok
* @deprecated Use setDeliveryDate
*/
public function set_date_livraison($user, $delivery_date, $notrigger = 0)
{
return $this->setDeliveryDate($user, $delivery_date, $notrigger);
}
/**
* Set the planned delivery date
*
@ -2266,7 +2280,7 @@ class CommandeFournisseur extends CommonOrder
* @param int $notrigger 1=Does not execute triggers, 0= execute triggers
* @return int <0 if KO, >0 if OK
*/
public function set_delivery_date($user, $delivery_date, $notrigger = 0)
public function setDeliveryDate($user, $delivery_date, $notrigger = 0)
{
// phpcs:enable
if ($user->rights->fournisseur->commande->creer)

View File

@ -203,7 +203,7 @@ if (empty($reshook))
// date of delivery
if ($action == 'setdate_livraison' && $usercancreate)
{
$result = $object->set_delivery_date($user, $datelivraison);
$result = $object->setDeliveryDate($user, $datelivraison);
if ($result < 0) setEventMessages($object->error, $object->errors, 'errors');
}
@ -1199,7 +1199,7 @@ if (empty($reshook))
$result = $srcobject->fetch($object->origin_id);
if ($result > 0)
{
$object->set_delivery_date($user, $srcobject->date_livraison);
$object->setDeliveryDate($user, $srcobject->date_livraison);
$object->set_id_projet($user, $srcobject->fk_project);
$lines = $srcobject->lines;

View File

@ -425,7 +425,7 @@ if (empty($reshook))
$datedelivery = dol_mktime(GETPOST('liv_hour', 'int'), GETPOST('liv_min', 'int'), 0, GETPOST('liv_month', 'int'), GETPOST('liv_day', 'int'), GETPOST('liv_year', 'int'));
$object->fetch($id);
$result = $object->set_delivery_date($user, $datedelivery);
$result = $object->setDeliveryDate($user, $datedelivery);
if ($result < 0)
{
setEventMessages($object->error, $object->errors, 'errors');

View File

@ -1219,15 +1219,14 @@ class Reception extends CommonObject
}
}
// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
/**
/**
* Set the planned delivery date
*
* @param User $user Objet utilisateur qui modifie
* @param integer $delivery_date Delivery date
* @return int <0 if KO, >0 if OK
*/
public function set_delivery_date($user, $delivery_date)
public function setDeliveryDate($user, $delivery_date)
{
// phpcs:enable
if ($user->rights->reception->creer)
@ -1236,7 +1235,7 @@ class Reception extends CommonObject
$sql .= " SET date_delivery = ".($delivery_date ? "'".$this->db->idate($delivery_date)."'" : 'null');
$sql .= " WHERE rowid = ".$this->id;
dol_syslog(get_class($this)."::set_delivery_date", LOG_DEBUG);
dol_syslog(get_class($this)."::setDeliveryDate", LOG_DEBUG);
$resql = $this->db->query($sql);
if ($resql)
{

View File

@ -229,7 +229,7 @@ if (empty($reshook))
else setEventMessages($langs->trans($object->error), null, 'errors');
}
} elseif ($action == 'setdate_livraison' && $usercancreate) {
$result = $object->set_delivery_date($user, dol_mktime(12, 0, 0, $_POST['liv_month'], $_POST['liv_day'], $_POST['liv_year']));
$result = $object->setDeliveryDate($user, dol_mktime(12, 0, 0, $_POST['liv_month'], $_POST['liv_day'], $_POST['liv_year']));
if ($result < 0)
dol_print_error($db, $object->error);
}

View File

@ -1507,6 +1507,20 @@ class SupplierProposal extends CommonObject
}
// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
/**
* Set delivery date
*
* @param User $user Object user that modify
* @param int $delivery_date Delivery date
* @param int $notrigger 1=Does not execute triggers, 0= execute triggers
* @return int <0 if ko, >0 if ok
* @deprecated Use setDeliveryDate
*/
public function set_date_livraison($user, $delivery_date, $notrigger = 0)
{
return $this->setDeliveryDate($user, $delivery_date, $notrigger);
}
/**
* Set delivery date
*
@ -1514,7 +1528,7 @@ class SupplierProposal extends CommonObject
* @param int $delivery_date Delivery date
* @return int <0 if ko, >0 if ok
*/
public function set_delivery_date($user, $delivery_date)
public function setDeliveryDate($user, $delivery_date)
{
// phpcs:enable
if (!empty($user->rights->supplier_proposal->creer))
@ -1529,7 +1543,7 @@ class SupplierProposal extends CommonObject
return 1;
} else {
$this->error = $this->db->error();
dol_syslog(get_class($this)."::set_delivery_date Erreur SQL");
dol_syslog(get_class($this)."::setDeliveryDate Erreur SQL");
return -1;
}
}