lainwir3d/dolibarr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid function calls in a FOR loop test part

Browse Source
This commit is contained in:
Benjamin Chantalat 2021-11-01 20:08:00 +01:00
parent 85372a7083
commit 85776f7529
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
htdocs/core/lib/fourn.lib.php
View File

@ -162,14 +162,17 @@ function ordersupplier_prepare_head($object)
//If dispach process running we add the number of item to dispatch into the head //If dispach process running we add the number of item to dispatch into the head
if ($object->statut == '3' OR $object->statut == '4' OR $object->statut == '5') { if ($object->statut == '3' OR $object->statut == '4' OR $object->statut == '5') {
$lines = $object->fetch_lines(); $object->fetch_lines();
$nbLinesOrdered = count($object->lines);
$dispachedLines = $object->getDispachedLines(1); $dispachedLines = $object->getDispachedLines(1);
$nbDispachedLines = count($dispachedLines);
$sumQtyAllreadyDispatched = 0; $sumQtyAllreadyDispatched = 0;
for ($line = 0 ; $line < count($dispachedLines); $line++) { for ($line = 0 ; $line < $nbDispachedLines; $line++) {
$sumQtyAllreadyDispatched = $sumQtyAllreadyDispatched + $dispachedLines[$line]['qty']; $sumQtyAllreadyDispatched = $sumQtyAllreadyDispatched + $dispachedLines[$line]['qty'];
} }
$sumQtyOrdered = 0; $sumQtyOrdered = 0;
for ($line = 0 ; $line < count($object->lines); $line++) { for ($line = 0 ; $line < $nbLinesOrdered; $line++) {
$sumQtyOrdered = $sumQtyOrdered + $object->lines[$line]->qty; $sumQtyOrdered = $sumQtyOrdered + $object->lines[$line]->qty;
} }
$head[$h][1] .= '<span class="badge marginleftonlyshort">'.$sumQtyAllreadyDispatched.' / '.$sumQtyOrdered.'</span>'; $head[$h][1] .= '<span class="badge marginleftonlyshort">'.$sumQtyAllreadyDispatched.' / '.$sumQtyOrdered.'</span>';