Fix phpcs

This commit is contained in:
Laurent Destailleur 2018-12-15 18:30:35 +01:00
parent 54ffba793f
commit 85cd23caaf
7 changed files with 21 additions and 12 deletions

View File

@ -2,6 +2,17 @@
English Dolibarr ChangeLog
--------------------------------------------------------------
***** ChangeLog for 10.0.0 compared to 9.0.0 *****
For Users:
For Developers:
WARNING:
Following changes may create regressions for some external modules, but were necessary to make Dolibarr better:
* GetUrlTrackingStatus were renamed into getUrlTrackingStatus
***** ChangeLog for 9.0.0 compared to 8.0.0 *****
For Users:

View File

@ -644,7 +644,7 @@ class pdf_merou extends ModelePdfExpedition
if (! empty($object->tracking_number))
{
$object->GetUrlTrackingStatus($object->tracking_number);
$object->getUrlTrackingStatus($object->tracking_number);
if (! empty($object->tracking_url))
{
if ($object->shipping_method_id > 0)

View File

@ -372,7 +372,7 @@ class pdf_rouget extends ModelePdfExpedition
// Tracking number
if (! empty($object->tracking_number))
{
$object->GetUrlTrackingStatus($object->tracking_number);
$object->getUrlTrackingStatus($object->tracking_number);
if (! empty($object->tracking_url))
{
if ($object->shipping_method_id > 0)

View File

@ -305,7 +305,7 @@ class pdf_squille extends ModelePdfReception
// Tracking number
if (! empty($object->tracking_number))
{
$object->GetUrlTrackingStatus($object->tracking_number);
$object->getUrlTrackingStatus($object->tracking_number);
if (! empty($object->tracking_url))
{
if ($object->reception_method_id > 0)

View File

@ -604,7 +604,7 @@ class Expedition extends CommonObject
if ($this->statut == 0) $this->brouillon = 1;
// Tracking url
$this->GetUrlTrackingStatus($obj->tracking_number);
$this->getUrlTrackingStatus($obj->tracking_number);
/*
* Thirparty
@ -1937,16 +1937,14 @@ class Expedition extends CommonObject
}
// phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps
/**
* Forge an set tracking url
*
* @param string $value Value
* @return void
*/
function GetUrlTrackingStatus($value='')
function getUrlTrackingStatus($value='')
{
// phpcs:enable
if (! empty($this->shipping_method_id))
{
$sql = "SELECT em.code, em.tracking";

View File

@ -1150,7 +1150,7 @@ if ($action == 'create')
if ($line->fk_product > 0)
{
print '<!-- Show warehouse selection -->';
print $formproduct->selectWarehouses($tmpentrepot_id, 'entl'.$indiceAsked, '', 0 , 0, $line->fk_product, '', 1);
print $formproduct->selectWarehouses($tmpentrepot_id, 'entl'.$indiceAsked, '', 0, 0, $line->fk_product, '', 1);
}
}
else
@ -1890,9 +1890,9 @@ else if ($id || $ref)
{
print '<td> <input name="batch'.$line_id.'" id="batch'.$line_id.'" type="text" value="'.$lines[$i]->batch.'"> </br>';
print $langs->trans('EatByDate').' : ';
print $form->select_date($lines[$i]->eatby,'dlc' .$line_id , '', '', 1, ""). '</br>';
print $form->select_date($lines[$i]->eatby,'dlc' .$line_id, '', '', 1, ""). '</br>';
print $langs->trans('SellByDate').' : ';
print $form->select_date($lines[$i]->sellby,'dluo' .$line_id , '', '', 1, "");
print $form->select_date($lines[$i]->sellby,'dluo' .$line_id, '', '', 1, "");
print '</td>';
}
print '</tr>';

View File

@ -440,7 +440,7 @@ class Reception extends CommonObject
$this->pdf_filename = $file;
// Tracking url
$this->GetUrlTrackingStatus($obj->tracking_number);
$this->getUrlTrackingStatus($obj->tracking_number);
/*
* Thirparty
@ -1423,7 +1423,7 @@ class Reception extends CommonObject
* @param string $value Value
* @return void
*/
function GetUrlTrackingStatus($value='')
function getUrlTrackingStatus($value='')
{
if (! empty($this->shipping_method_id))
{