From 51f02d9eafe6256991dc69625d62262759a06dd1 Mon Sep 17 00:00:00 2001 From: FLIO Date: Tue, 29 Nov 2022 22:32:51 +0100 Subject: [PATCH 1/3] Fix(scrutinizer) https://scrutinizer-ci.com/g/Dolibarr/dolibarr/issues/develop/files/htdocs/resource/contact.php?selectedLabels%5B0%5D=9&selectedSeverities%5B0%5D=10&orderField=lastFound&order=desc&honorSelectedPaths=0 --- htdocs/resource/class/dolresource.class.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/htdocs/resource/class/dolresource.class.php b/htdocs/resource/class/dolresource.class.php index 3e1a2615cd9..bcd97493ac7 100644 --- a/htdocs/resource/class/dolresource.class.php +++ b/htdocs/resource/class/dolresource.class.php @@ -51,6 +51,11 @@ class Dolresource extends CommonObject public $busy; public $mandatory; + /** + * @var integer + */ + public $socid; + /** * @var int ID */ From d9862ea0071c046954e62e0ea4999beeb95c3ed2 Mon Sep 17 00:00:00 2001 From: FLIO Date: Wed, 30 Nov 2022 14:16:58 +0100 Subject: [PATCH 2/3] Fix(scrutinizer) --- htdocs/resource/class/dolresource.class.php | 5 ----- htdocs/resource/contact.php | 5 +---- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/htdocs/resource/class/dolresource.class.php b/htdocs/resource/class/dolresource.class.php index bcd97493ac7..3e1a2615cd9 100644 --- a/htdocs/resource/class/dolresource.class.php +++ b/htdocs/resource/class/dolresource.class.php @@ -51,11 +51,6 @@ class Dolresource extends CommonObject public $busy; public $mandatory; - /** - * @var integer - */ - public $socid; - /** * @var int ID */ diff --git a/htdocs/resource/contact.php b/htdocs/resource/contact.php index 45e4ce4b329..00bafdfee11 100644 --- a/htdocs/resource/contact.php +++ b/htdocs/resource/contact.php @@ -114,10 +114,7 @@ llxHeader('', $langs->trans("Resource")); // View and edit mode if ($id > 0 || !empty($ref)) { - $soc = new Societe($db); - $soc->fetch($object->socid); - - + $head = resource_prepare_head($object); print dol_get_fiche_head($head, 'contact', $langs->trans("ResourceSingular"), -1, 'resource'); From c6e32c940169c20db2b1725b8c6f08f7d7333b2e Mon Sep 17 00:00:00 2001 From: stickler-ci Date: Wed, 30 Nov 2022 13:17:35 +0000 Subject: [PATCH 3/3] Fixing style errors. --- htdocs/resource/contact.php | 1 - 1 file changed, 1 deletion(-) diff --git a/htdocs/resource/contact.php b/htdocs/resource/contact.php index 00bafdfee11..3b032fffb94 100644 --- a/htdocs/resource/contact.php +++ b/htdocs/resource/contact.php @@ -114,7 +114,6 @@ llxHeader('', $langs->trans("Resource")); // View and edit mode if ($id > 0 || !empty($ref)) { - $head = resource_prepare_head($object); print dol_get_fiche_head($head, 'contact', $langs->trans("ResourceSingular"), -1, 'resource');