From 8adf1852b1cf968db61fbf140f15be50dccf8fb1 Mon Sep 17 00:00:00 2001
From: Laurent Destailleur <eldy@destailleur.fr>
Date: Sun, 30 Aug 2020 03:00:35 +0200
Subject: [PATCH] Clean code

---
 htdocs/comm/action/card.php           |  4 ++--
 htdocs/core/class/html.form.class.php | 24 +++++++-----------------
 htdocs/security.txt                   |  5 +++++
 3 files changed, 14 insertions(+), 19 deletions(-)
 create mode 100644 htdocs/security.txt

diff --git a/htdocs/comm/action/card.php b/htdocs/comm/action/card.php
index 037ac8bed89..dcb72cd2a18 100644
--- a/htdocs/comm/action/card.php
+++ b/htdocs/comm/action/card.php
@@ -1190,7 +1190,7 @@ if ($action == 'create')
 
         //Time Type
         print '<tr><td class="titlefieldcreate nowrap">'.$langs->trans("TimeType").'</td><td colspan="3">';
-        print $form->select_type_duration('offsetunit');
+        print $form->selectTypeDuration('offsetunit');
         print '</td></tr>';
 
         //Reminder Type
@@ -1203,7 +1203,7 @@ if ($action == 'create')
 
         //Mail Model
         print '<tr><td class="titlefieldcreate nowrap">'.$langs->trans("EMailTemplates").'</td><td colspan="3">';
-        print $form->select_model_mail('actioncommsend', 'actioncomm_send');
+        print $form->selectModelMail('actioncommsend', 'actioncomm_send');
         print '</td></tr>';
 
 
diff --git a/htdocs/core/class/html.form.class.php b/htdocs/core/class/html.form.class.php
index d3b1589410e..153f1cdbae2 100644
--- a/htdocs/core/class/html.form.class.php
+++ b/htdocs/core/class/html.form.class.php
@@ -5673,35 +5673,27 @@ class Form
 		return $retstring;
 	}
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
 	/**
-	 * select_type_duration
+	 * selectTypeDuration
 	 *
 	 * @param   string   $prefix     Prefix
 	 * @param   string   $selected   Selected type
 	 * @return  string               HTML select string
 	 */
-	public function select_type_duration($prefix, $selected = 'minute')
+	public function selectTypeDuration($prefix, $selected = 'minute')
 	{
-		// phpcs:enable
 		global $langs;
 
-        $retstring = '';
-
         $TDurationTypes = array('year'=>$langs->trans('Years'), 'month'=>$langs->trans('Month'), 'week'=>$langs->trans('Weeks'), 'day'=>$langs->trans('Days'), 'hour'=>$langs->trans('Hours'), 'minute'=>$langs->trans('Minutes'));
 
-        $retstring .= '<select class="flat" id="select_'.$prefix.'type_duration" name="'.$prefix.'type_duration">';
-
-        foreach ($TDurationTypes as $key=>$typeduration){
-
+        $retstring = '<select class="flat" id="select_'.$prefix.'type_duration" name="'.$prefix.'type_duration">';
+        foreach ($TDurationTypes as $key=>$typeduration) {
             $retstring .= '<option value="'.$key.'"';
-            if($key == $selected)
-            {
+            if ($key == $selected) {
                 $retstring .= " selected";
             }
             $retstring .= ">".$typeduration."</option>";
         }
-
         $retstring .= "</select>";
 
         return $retstring;
@@ -7980,17 +7972,15 @@ class Form
 		return $ret;
 	}
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
 	/**
-	 * select_model_mail
+	 * selectModelMail
 	 *
 	 * @param   string   $prefix     Prefix
 	 * @param   string   $modelType  Model type
 	 * @return  string               HTML select string
 	 */
-    public function select_model_mail($prefix, $modelType = '')
+    public function selectModelMail($prefix, $modelType = '')
     {
-    	// phpcs:enable
         global $langs, $db, $user;
 
         $retstring = '';
diff --git a/htdocs/security.txt b/htdocs/security.txt
new file mode 100644
index 00000000000..8ddfd1fab43
--- /dev/null
+++ b/htdocs/security.txt
@@ -0,0 +1,5 @@
+# Security policies of Dolibarr ERP CRM project
+Contact: mailto:security@dolibarr.org
+Preferred-Languages: en
+Policy: https://github.com/Dolibarr/dolibarr/security/policy
+Expires: Sat, 31 Dec 2050 00:00:00 GMT