lainwir3d/dolibarr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #22662 from atm-maxime/fix_scrut2

Browse Source 
Fix scrutinizer api_thirdparties.class.php 5 issues
This commit is contained in:
Laurent Destailleur 2022-10-24 16:55:04 +02:00 committed by GitHub
commit 8b52d108f2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
htdocs/societe/class/api_thirdparties.class.php
View File

@ -1082,7 +1082,7 @@ class Thirdparties extends DolibarrApi
$invoice = new Facture($this->db); $invoice = new Facture($this->db);
$result = $invoice->list_replacable_invoices($id); $result = $invoice->list_replacable_invoices($id);
if ($result < 0) { if ($result < 0) {
throw new RestException(405, $this->thirdparty->error); throw new RestException(405, $invoice->error);
} }
return $result; return $result;
@ -1125,7 +1125,7 @@ class Thirdparties extends DolibarrApi
$invoice = new Facture($this->db); $invoice = new Facture($this->db);
$result = $invoice->list_qualified_avoir_invoices($id); $result = $invoice->list_qualified_avoir_invoices($id);
if ($result < 0) { if ($result < 0) {
throw new RestException(405, $this->thirdparty->error); throw new RestException(405, $invoice->error);
} }
return $result; return $result;
@ -1164,10 +1164,9 @@ class Thirdparties extends DolibarrApi
$sql .= " WHERE fk_soc = ".((int) $id); $sql .= " WHERE fk_soc = ".((int) $id);
} }
$result = $this->db->query($sql); $result = $this->db->query($sql);
if ($result->num_rows == 0) { if ($this->db->num_rows($result) == 0) {
throw new RestException(404, 'Account not found'); throw new RestException(404, 'Account not found');
} }
@ -1409,7 +1408,7 @@ class Thirdparties extends DolibarrApi
if ($result > 0) { if ($result > 0) {
return array("success" => $result); return array("success" => $result);
} else { } else {
throw new RestException(500, 'Error generating the document '.$this->error); throw new RestException(500, 'Error generating the document '.$this->company->error);
} }
} }