lainwir3d/dolibarr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix warnings

Browse Source
This commit is contained in:
Laurent Destailleur 2019-04-23 10:38:20 +02:00
parent 7c7c4f0d93
commit 8d0825910a
2 changed files with 99 additions and 132 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
htdocs/core/lib/pdf.lib.php
View File

@ -343,8 +343,8 @@ function pdfBuildThirdpartyName($thirdparty, Translate $outputlangs, $includeali
* *
* @param Translate $outputlangs Output langs object * @param Translate $outputlangs Output langs object
* @param Societe $sourcecompany Source company object * @param Societe $sourcecompany Source company object
* @param Societe|string $targetcompany Target company object * @param Societe|string|null $targetcompany Target company object
* @param Contact|string $targetcontact Target contact object * @param Contact|string|null $targetcontact Target contact object
* @param int $usecontact Use contact instead of company * @param int $usecontact Use contact instead of company
* @param string $mode Address type ('source', 'target', 'targetwithdetails', 'targetwithdetails_xxx': target but include also phone/fax/email/url) * @param string $mode Address type ('source', 'target', 'targetwithdetails', 'targetwithdetails_xxx': target but include also phone/fax/email/url)
* @param Object $object Object we want to build document for * @param Object $object Object we want to build document for
@ -364,7 +364,7 @@ function pdf_build_address($outputlangs, $sourcecompany, $targetcompany = '', $t
$stringaddress = ''; $stringaddress = '';
if (is_object($hookmanager)) if (is_object($hookmanager))
{ {
$parameters = array('sourcecompany'=>&$sourcecompany,'targetcompany'=>&$targetcompany,'targetcontact'=>$targetcontact,'outputlangs'=>$outputlangs,'mode'=>$mode,'usecontact'=>$usecontact); $parameters = array('sourcecompany'=>&$sourcecompany, 'targetcompany'=>&$targetcompany, 'targetcontact'=>&$targetcontact, 'outputlangs'=>$outputlangs, 'mode'=>$mode, 'usecontact'=>$usecontact);
$action=''; $action='';
$reshook = $hookmanager->executeHooks('pdf_build_address', $parameters, $object, $action); // Note that $action and $object may have been modified by some hooks $reshook = $hookmanager->executeHooks('pdf_build_address', $parameters, $object, $action); // Note that $action and $object may have been modified by some hooks
$stringaddress.=$hookmanager->resPrint; $stringaddress.=$hookmanager->resPrint;

189
htdocs/core/menus/standard/eldy.lib.php
View File

@ -87,20 +87,17 @@ function print_eldy_menu($db, $atarget, $type_user, &$tabMenu, &$menu, $noout =
); );
// Members // Members
$tmpentry = array(
'enabled' => (! empty($conf->adherent->enabled) ) ,
'perms' => (! empty($user->rights->adherent->lire) ),
'module' => 'adherent'
);
$menu_arr[] = array( $menu_arr[] = array(
'name' => 'Members', 'name' => 'Members',
'link' => '/adherents/index.php?mainmenu=members&leftmenu=', 'link' => '/adherents/index.php?mainmenu=members&leftmenu=',
'title' => "MenuMembers", 'title' => "MenuMembers",
'level' => 0, 'level' => 0,
'enabled' => $showmode = isVisibleToUserType( 'enabled' => $showmode = isVisibleToUserType($type_user, $tmpentry, $listofmodulesforexternal),
$type_user,
$tmpentry = array(
'enabled' => (! empty($conf->adherent->enabled) ) ,
'perms' => (! empty($user->rights->adherent->lire) ),
'module' => 'adherent',
),
$listofmodulesforexternal
),
'target' => $atarget, 'target' => $atarget,
'mainmenu' => "members", 'mainmenu' => "members",
'leftmenu' => '', 'leftmenu' => '',
@ -115,13 +112,6 @@ function print_eldy_menu($db, $atarget, $type_user, &$tabMenu, &$menu, $noout =
); );
// Third parties // Third parties
$menu_arr[] = array(
'name' => 'Companies',
'link' => '/societe/index.php?mainmenu=companies&leftmenu=',
'title' => "ThirdParties",
'level' => 0,
'enabled' => $showmode = isVisibleToUserType(
$type_user,
$tmpentry = array( $tmpentry = array(
'enabled'=> ( ( ! empty($conf->societe->enabled) && 'enabled'=> ( ( ! empty($conf->societe->enabled) &&
( empty($conf->global->SOCIETE_DISABLE_PROSPECTS) || empty($conf->global->SOCIETE_DISABLE_CUSTOMERS) ) ( empty($conf->global->SOCIETE_DISABLE_PROSPECTS) || empty($conf->global->SOCIETE_DISABLE_CUSTOMERS) )
@ -129,10 +119,14 @@ function print_eldy_menu($db, $atarget, $type_user, &$tabMenu, &$menu, $noout =
|| ! empty($conf->fournisseur->enabled) || ! empty($conf->fournisseur->enabled)
), ),
'perms'=> (! empty($user->rights->societe->lire) || ! empty($user->rights->fournisseur->lire)), 'perms'=> (! empty($user->rights->societe->lire) || ! empty($user->rights->fournisseur->lire)),
'module'=>'societe|fournisseur', 'module'=>'societe|fournisseur'
), );
$listofmodulesforexternal $menu_arr[] = array(
), 'name' => 'Companies',
'link' => '/societe/index.php?mainmenu=companies&leftmenu=',
'title' => "ThirdParties",
'level' => 0,
'enabled' => $showmode = isVisibleToUserType($type_user, $tmpentry, $listofmodulesforexternal),
'target' => $atarget, 'target' => $atarget,
'mainmenu' => "companies", 'mainmenu' => "companies",
'leftmenu' => '', 'leftmenu' => '',
@ -147,15 +141,6 @@ function print_eldy_menu($db, $atarget, $type_user, &$tabMenu, &$menu, $noout =
); );
// Products-Services // Products-Services
$menu_arr[] = array(
'name' => 'Products',
'link' => '/product/index.php?mainmenu=products&leftmenu=',
'title' => (! empty($conf->product->enabled) && ! empty($conf->service->enabled))
? ( array("TMenuProducts" , " | " ,"TMenuServices") )
: (! empty($conf->product->enabled)? "TMenuProducts" : "TMenuServices" ),
'level' => 0,
'enabled' => $showmode = isVisibleToUserType(
$type_user,
$tmpentry = array( $tmpentry = array(
'enabled'=> (( ! empty($conf->societe->enabled) && 'enabled'=> (( ! empty($conf->societe->enabled) &&
( empty($conf->global->SOCIETE_DISABLE_PROSPECTS) || empty($conf->global->SOCIETE_DISABLE_CUSTOMERS) ) ( empty($conf->global->SOCIETE_DISABLE_PROSPECTS) || empty($conf->global->SOCIETE_DISABLE_CUSTOMERS) )
@ -163,10 +148,16 @@ function print_eldy_menu($db, $atarget, $type_user, &$tabMenu, &$menu, $noout =
|| ! empty($conf->fournisseur->enabled) || ! empty($conf->fournisseur->enabled)
), ),
'perms'=> (! empty($user->rights->societe->lire) || ! empty($user->rights->fournisseur->lire)), 'perms'=> (! empty($user->rights->societe->lire) || ! empty($user->rights->fournisseur->lire)),
'module'=>'product|service', 'module'=>'product|service'
), );
$listofmodulesforexternal $menu_arr[] = array(
), 'name' => 'Products',
'link' => '/product/index.php?mainmenu=products&leftmenu=',
'title' => (! empty($conf->product->enabled) && ! empty($conf->service->enabled))
? ( array("TMenuProducts" , " | " ,"TMenuServices") )
: (! empty($conf->product->enabled)? "TMenuProducts" : "TMenuServices" ),
'level' => 0,
'enabled' => $showmode = isVisibleToUserType($type_user, $tmpentry, $listofmodulesforexternal),
'target' => $atarget, 'target' => $atarget,
'mainmenu' => "products", 'mainmenu' => "products",
'leftmenu' => '', 'leftmenu' => '',
@ -181,20 +172,17 @@ function print_eldy_menu($db, $atarget, $type_user, &$tabMenu, &$menu, $noout =
); );
// MRP // MRP
$tmpentry = array(
'enabled'=>(! empty($conf->bom->enabled) || ! empty($conf->mrp->enabled)),
'perms'=>(! empty($user->rights->bom->read) || ! empty($user->rights->mrp->read)),
'module'=>'bom|mrp'
);
$menu_arr[] = array( $menu_arr[] = array(
'name' => 'TMenuMRP', 'name' => 'TMenuMRP',
'link' => '/mrp/index.php?mainmenu=mrp&leftmenu=', 'link' => '/mrp/index.php?mainmenu=mrp&leftmenu=',
'title' => $langs->trans("TMenuMRP"), 'title' => $langs->trans("TMenuMRP"),
'level' => 0, 'level' => 0,
'enabled' => $showmode = isVisibleToUserType( 'enabled' => $showmode = isVisibleToUserType($type_user, $tmpentry, $listofmodulesforexternal),
$type_user,
$tmpentry = array(
'enabled'=>(! empty($conf->bom->enabled) || ! empty($conf->mrp->enabled)),
'perms'=>(! empty($user->rights->bom->read) || ! empty($user->rights->mrp->read)),
'module'=>'bom|mrp',
),
$listofmodulesforexternal
),
'target' => $atarget, 'target' => $atarget,
'mainmenu' => "mrp", 'mainmenu' => "mrp",
'leftmenu' => '', 'leftmenu' => '',
@ -209,6 +197,11 @@ function print_eldy_menu($db, $atarget, $type_user, &$tabMenu, &$menu, $noout =
); );
// Projects // Projects
$tmpentry = array(
'enabled'=> ( ! empty($conf->projet->enabled) ? 1 : 0),
'perms'=> (! empty($user->rights->projet->lire) ? 1 : 0),
'module'=>'projet'
);
$menu_arr[] = array( $menu_arr[] = array(
'name' => 'Projet', 'name' => 'Projet',
'link' => '/projet/index.php?mainmenu=project&leftmenu=', 'link' => '/projet/index.php?mainmenu=project&leftmenu=',
@ -216,15 +209,7 @@ function print_eldy_menu($db, $atarget, $type_user, &$tabMenu, &$menu, $noout =
? (($conf->global->PROJECT_USE_OPPORTUNITIES == 2)?"Leads":"Projects") ? (($conf->global->PROJECT_USE_OPPORTUNITIES == 2)?"Leads":"Projects")
: "LeadsOrProjects", : "LeadsOrProjects",
'level' => 0, 'level' => 0,
'enabled' => $showmode = isVisibleToUserType( 'enabled' => $showmode = isVisibleToUserType($type_user, $tmpentry, $listofmodulesforexternal),
$type_user,
$tmpentry = array(
'enabled'=> ( ! empty($conf->projet->enabled) ? 1 : 0),
'perms'=> (! empty($user->rights->projet->lire) ? 1 : 0),
'module'=>'projet',
),
$listofmodulesforexternal
),
'target' => $atarget, 'target' => $atarget,
'mainmenu' => "project", 'mainmenu' => "project",
'leftmenu' => '', 'leftmenu' => '',
@ -239,13 +224,6 @@ function print_eldy_menu($db, $atarget, $type_user, &$tabMenu, &$menu, $noout =
); );
// Commercial // Commercial
$menu_arr[] = array(
'name' => 'Commercial',
'link' => '/comm/index.php?mainmenu=commercial&leftmenu=',
'title' => "Commercial",
'level' => 0,
'enabled' => $showmode = isVisibleToUserType(
$type_user,
$tmpentry = array( $tmpentry = array(
'enabled'=>(! empty($conf->propal->enabled) || 'enabled'=>(! empty($conf->propal->enabled) ||
! empty($conf->commande->enabled) || ! empty($conf->commande->enabled) ||
@ -255,10 +233,14 @@ function print_eldy_menu($db, $atarget, $type_user, &$tabMenu, &$menu, $noout =
! empty($conf->ficheinter->enabled) ! empty($conf->ficheinter->enabled)
)?1:0, )?1:0,
'perms'=>(! empty($user->rights->societe->lire) || ! empty($user->rights->societe->contact->lire)), 'perms'=>(! empty($user->rights->societe->lire) || ! empty($user->rights->societe->contact->lire)),
'module'=>'propal|commande|supplier_order|contrat|ficheinter', 'module'=>'propal|commande|supplier_order|contrat|ficheinter'
), );
$listofmodulesforexternal $menu_arr[] = array(
), 'name' => 'Commercial',
'link' => '/comm/index.php?mainmenu=commercial&leftmenu=',
'title' => "Commercial",
'level' => 0,
'enabled' => $showmode = isVisibleToUserType($type_user, $tmpentry, $listofmodulesforexternal),
'target' => $atarget, 'target' => $atarget,
'mainmenu' => "commercial", 'mainmenu' => "commercial",
'leftmenu' => '', 'leftmenu' => '',
@ -273,13 +255,6 @@ function print_eldy_menu($db, $atarget, $type_user, &$tabMenu, &$menu, $noout =
); );
// Billing - Financial // Billing - Financial
$menu_arr[] = array(
'name' => 'Compta',
'link' => '/compta/index.php?mainmenu=billing&leftmenu=',
'title' => "MenuFinancial",
'level' => 0,
'enabled' => $showmode = isVisibleToUserType(
$type_user,
$tmpentry = array( $tmpentry = array(
'enabled'=>(! empty($conf->facture->enabled) || 'enabled'=>(! empty($conf->facture->enabled) ||
! empty($conf->don->enabled) || ! empty($conf->don->enabled) ||
@ -291,10 +266,14 @@ function print_eldy_menu($db, $atarget, $type_user, &$tabMenu, &$menu, $noout =
'perms'=>(! empty($user->rights->facture->lire) || ! empty($user->rights->don->contact->lire) 'perms'=>(! empty($user->rights->facture->lire) || ! empty($user->rights->don->contact->lire)
|| ! empty($user->rights->tax->charges->lire) || ! empty($user->rights->salaries->read) || ! empty($user->rights->tax->charges->lire) || ! empty($user->rights->salaries->read)
|| ! empty($user->rights->fournisseur->facture->lire) || ! empty($user->rights->loan->read)), || ! empty($user->rights->fournisseur->facture->lire) || ! empty($user->rights->loan->read)),
'module'=>'facture|supplier_invoice|don|tax|salaries|loan', 'module'=>'facture|supplier_invoice|don|tax|salaries|loan'
), );
$listofmodulesforexternal $menu_arr[] = array(
), 'name' => 'Compta',
'link' => '/compta/index.php?mainmenu=billing&leftmenu=',
'title' => "MenuFinancial",
'level' => 0,
'enabled' => $showmode = isVisibleToUserType($type_user, $tmpentry, $listofmodulesforexternal),
'target' => $atarget, 'target' => $atarget,
'mainmenu' => "billing", 'mainmenu' => "billing",
'leftmenu' => '', 'leftmenu' => '',
@ -309,20 +288,17 @@ function print_eldy_menu($db, $atarget, $type_user, &$tabMenu, &$menu, $noout =
); );
// Bank // Bank
$tmpentry = array(
'enabled'=>(! empty($conf->banque->enabled) || ! empty($conf->prelevement->enabled)),
'perms'=>(! empty($user->rights->banque->lire) || ! empty($user->rights->prelevement->lire)),
'module'=>'banque|prelevement'
);
$menu_arr[] = array( $menu_arr[] = array(
'name' => 'Bank', 'name' => 'Bank',
'link' => '/compta/bank/list.php?mainmenu=bank&leftmenu=', 'link' => '/compta/bank/list.php?mainmenu=bank&leftmenu=',
'title' => "MenuBankCash", 'title' => "MenuBankCash",
'level' => 0, 'level' => 0,
'enabled' => $showmode = isVisibleToUserType( 'enabled' => $showmode = isVisibleToUserType($type_user, $tmpentry, $listofmodulesforexternal),
$type_user,
$tmpentry = array(
'enabled'=>(! empty($conf->banque->enabled) || ! empty($conf->prelevement->enabled)),
'perms'=>(! empty($user->rights->banque->lire) || ! empty($user->rights->prelevement->lire)),
'module'=>'banque|prelevement',
),
$listofmodulesforexternal
),
'target' => $atarget, 'target' => $atarget,
'mainmenu' => "bank", 'mainmenu' => "bank",
'leftmenu' => '', 'leftmenu' => '',
@ -339,20 +315,17 @@ function print_eldy_menu($db, $atarget, $type_user, &$tabMenu, &$menu, $noout =
); );
// Accounting // Accounting
$tmpentry = array(
'enabled'=>(! empty($conf->comptabilite->enabled) || ! empty($conf->accounting->enabled) || ! empty($conf->asset->enabled)),
'perms'=>(! empty($user->rights->compta->resultat->lire) || ! empty($user->rights->accounting->mouvements->lire) || ! empty($user->rights->asset->read)),
'comptabilite|accounting|asset'
);
$menu_arr[] = array( $menu_arr[] = array(
'name' => 'Accounting', 'name' => 'Accounting',
'link' => '/accountancy/index.php?mainmenu=accountancy&leftmenu=', 'link' => '/accountancy/index.php?mainmenu=accountancy&leftmenu=',
'title' => "MenuAccountancy", 'title' => "MenuAccountancy",
'level' => 0, 'level' => 0,
'enabled' => $showmode = isVisibleToUserType( 'enabled' => $showmode = isVisibleToUserType($type_user, $tmpentry, $listofmodulesforexternal),
$type_user,
$tmpentry = array(
'enabled'=>(! empty($conf->comptabilite->enabled) || ! empty($conf->accounting->enabled) || ! empty($conf->asset->enabled)),
'perms'=>(! empty($user->rights->compta->resultat->lire) || ! empty($user->rights->accounting->mouvements->lire) || ! empty($user->rights->asset->read)),
'comptabilite|accounting|asset',
),
$listofmodulesforexternal
),
'target' => $atarget, 'target' => $atarget,
'mainmenu' => "accountancy", 'mainmenu' => "accountancy",
'leftmenu' => '', 'leftmenu' => '',
@ -369,20 +342,17 @@ function print_eldy_menu($db, $atarget, $type_user, &$tabMenu, &$menu, $noout =
); );
// HRM // HRM
$tmpentry = array(
'enabled'=>(! empty($conf->hrm->enabled) || ! empty($conf->holiday->enabled) || ! empty($conf->deplacement->enabled) || ! empty($conf->expensereport->enabled)),
'perms'=>(! empty($user->rights->hrm->employee->read) || ! empty($user->rights->holiday->write) || ! empty($user->rights->deplacement->lire) || ! empty($user->rights->expensereport->lire)),
'module'=>'hrm|holiday|deplacement|expensereport'
);
$menu_arr[] = array( $menu_arr[] = array(
'name' => 'HRM', 'name' => 'HRM',
'link' => '/hrm/index.php?mainmenu=hrm&leftmenu=', 'link' => '/hrm/index.php?mainmenu=hrm&leftmenu=',
'title' => "HRM", 'title' => "HRM",
'level' => 0, 'level' => 0,
'enabled' => $showmode = isVisibleToUserType( 'enabled' => $showmode = isVisibleToUserType($type_user, $tmpentry, $listofmodulesforexternal),
$type_user,
$tmpentry = array(
'enabled'=>(! empty($conf->hrm->enabled) || ! empty($conf->holiday->enabled) || ! empty($conf->deplacement->enabled) || ! empty($conf->expensereport->enabled)),
'perms'=>(! empty($user->rights->hrm->employee->read) || ! empty($user->rights->holiday->write) || ! empty($user->rights->deplacement->lire) || ! empty($user->rights->expensereport->lire)),
'module'=>'hrm|holiday|deplacement|expensereport',
),
$listofmodulesforexternal
),
'target' => $atarget, 'target' => $atarget,
'mainmenu' => "hrm", 'mainmenu' => "hrm",
'leftmenu' => '', 'leftmenu' => '',
@ -399,20 +369,17 @@ function print_eldy_menu($db, $atarget, $type_user, &$tabMenu, &$menu, $noout =
); );
// Tools // Tools
$tmpentry = array(
'enabled'=>1,
'perms'=>1,
'module'=>''
);
$menu_arr[] = array( $menu_arr[] = array(
'name' => 'Tools', 'name' => 'Tools',
'link' => '/core/tools.php?mainmenu=tools&leftmenu=', 'link' => '/core/tools.php?mainmenu=tools&leftmenu=',
'title' => "Tools", 'title' => "Tools",
'level' => 0, 'level' => 0,
'enabled' => $showmode = isVisibleToUserType( 'enabled' => $showmode = isVisibleToUserType($type_user, $tmpentry, $listofmodulesforexternal),
$type_user,
$tmpentry = array(
'enabled'=>1,
'perms'=>1,
'module'=>'',
),
$listofmodulesforexternal
),
'target' => $atarget, 'target' => $atarget,
'mainmenu' => "tools", 'mainmenu' => "tools",
'leftmenu' => '', 'leftmenu' => '',
@ -641,7 +608,7 @@ function print_end_menu_array()
*/ */
function print_left_eldy_menu($db, $menu_array_before, $menu_array_after, &$tabMenu, &$menu, $noout = 0, $forcemainmenu = '', $forceleftmenu = '', $moredata = null) function print_left_eldy_menu($db, $menu_array_before, $menu_array_after, &$tabMenu, &$menu, $noout = 0, $forcemainmenu = '', $forceleftmenu = '', $moredata = null)
{ {
global $user,$conf,$langs,$dolibarr_main_db_name,$mysoc; global $user, $conf, $langs, $dolibarr_main_db_name, $mysoc;
//var_dump($tabMenu); //var_dump($tabMenu);
@ -1638,7 +1605,7 @@ function print_left_eldy_menu($db, $menu_array_before, $menu_array_after, &$tabM
$tmpentry = array( $tmpentry = array(
'enabled'=>(! empty($conf->projet->enabled)), 'enabled'=>(! empty($conf->projet->enabled)),
'perms'=>(! empty($user->rights->projet->lire)), 'perms'=>(! empty($user->rights->projet->lire)),
'module'=>'projet', 'module'=>'projet'
); );
$showmode=isVisibleToUserType($type_user, $tmpentry, $listofmodulesforexternal); $showmode=isVisibleToUserType($type_user, $tmpentry, $listofmodulesforexternal);