From a1ba425765e2cccce4eb9086d9779ce762c8c43b Mon Sep 17 00:00:00 2001
From: Laurent Destailleur <eldy@destailleur.fr>
Date: Mon, 1 May 2023 18:12:59 +0200
Subject: [PATCH] Fix warnings

---
 htdocs/compta/bank/class/account.class.php    |  1 +
 .../class/conferenceorbooth.class.php         | 22 -------------------
 htdocs/hrm/class/skillrank.class.php          |  2 ++
 htdocs/mrp/class/mo.class.php                 |  5 +++--
 htdocs/projet/class/project.class.php         |  1 +
 5 files changed, 7 insertions(+), 24 deletions(-)

diff --git a/htdocs/compta/bank/class/account.class.php b/htdocs/compta/bank/class/account.class.php
index c036a0b3414..da4cb2fbfe7 100644
--- a/htdocs/compta/bank/class/account.class.php
+++ b/htdocs/compta/bank/class/account.class.php
@@ -1336,6 +1336,7 @@ class Account extends CommonObject
 	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
 	/**
 	 *      Charge indicateurs this->nb de tableau de bord
+	 *
 	 *		@param		int			$filteraccountid	To get info for a particular account id
 	 *      @return     int         <0 if ko, >0 if ok
 	 */
diff --git a/htdocs/eventorganization/class/conferenceorbooth.class.php b/htdocs/eventorganization/class/conferenceorbooth.class.php
index 8bbf0fdd1b9..150c2b50c90 100644
--- a/htdocs/eventorganization/class/conferenceorbooth.class.php
+++ b/htdocs/eventorganization/class/conferenceorbooth.class.php
@@ -702,28 +702,6 @@ class ConferenceOrBooth extends ActionComm
 		$this->initAsSpecimenCommon();
 	}
 
-	/**
-	 * 	Create an array of lines
-	 *
-	 * 	@return array|int		array of lines if OK, <0 if KO
-	 */
-	/*public function getLinesArray()
-	{
-		$this->lines = array();
-
-		$objectline = new ConferenceOrBoothLine($this->db);
-		$result = $objectline->fetchAll('ASC', 'position', 0, 0, array('customsql'=>'fk_conferenceorbooth = '.((int) $this->id)));
-
-		if (is_numeric($result)) {
-			$this->error = $objectline->error;
-			$this->errors = $objectline->errors;
-			return $result;
-		} else {
-			$this->lines = $result;
-			return $this->lines;
-		}
-	}*/
-
 	/**
 	 *  Create a document onto disk according to template module.
 	 *
diff --git a/htdocs/hrm/class/skillrank.class.php b/htdocs/hrm/class/skillrank.class.php
index a08a647ca03..0462055f63e 100644
--- a/htdocs/hrm/class/skillrank.class.php
+++ b/htdocs/hrm/class/skillrank.class.php
@@ -927,6 +927,8 @@ class SkillRank extends CommonObject
 			return $this->lines;
 		}
 		*/
+
+		return $this->lines;
 	}
 
 	/**
diff --git a/htdocs/mrp/class/mo.class.php b/htdocs/mrp/class/mo.class.php
index cf4cbdb2edb..1b04dab08b7 100644
--- a/htdocs/mrp/class/mo.class.php
+++ b/htdocs/mrp/class/mo.class.php
@@ -1383,8 +1383,9 @@ class Mo extends CommonObject
 
 	/**
 	 * 	Create an array of lines
-	 * 	@param string $rolefilter string lines role filter
-	 * 	@return array|int		array of lines if OK, <0 if KO
+	 *
+	 * 	@param string 		$rolefilter 	string lines role filter
+	 * 	@return array|int					array of lines if OK, <0 if KO
 	 */
 	public function getLinesArray($rolefilter = '')
 	{
diff --git a/htdocs/projet/class/project.class.php b/htdocs/projet/class/project.class.php
index 6f36b03f5b4..05be2d4d6e6 100644
--- a/htdocs/projet/class/project.class.php
+++ b/htdocs/projet/class/project.class.php
@@ -2356,6 +2356,7 @@ class Project extends CommonObject
 		$taskstatic = new Task($this->db);
 
 		$this->lines = $taskstatic->getTasksArray(0, $user, $this->id, 0, 0, '',  '-1', '', 0, 0, array(),  0,  array(),  0,  $loadRoleMode);
+		return 1;
 	}
 
 	/**