lainwir3d/dolibarr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

commande.class.php - move db->begin() into cloture

Browse Source 
A DB begin request was sent before executing the status guard. If the guard fails, we exited the method without closing it. And it will occur a bug to any further database operation.
This commit is contained in:
LAURIER Alexis 2021-02-09 14:25:45 +01:00 committed by GitHub
parent a48c03923f
commit abf2875eba
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
htdocs/commande/class/commande.class.php
View File

@ -742,11 +742,11 @@ class Commande extends CommonOrder
if ($usercanclose) if ($usercanclose)
{ {
$this->db->begin();
if ($this->statut == self::STATUS_CLOSED) if ($this->statut == self::STATUS_CLOSED)
{ {
return 0; return 0;
} }
$this->db->begin();
$now = dol_now(); $now = dol_now();