lainwir3d/dolibarr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix: Bugs reported by scrutinizer

Browse Source
This commit is contained in:
Laurent Destailleur 2014-11-15 16:20:03 +01:00
parent d98bfb1d8d
commit ad661256c0
10 changed files with 21 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
htdocs/accountancy/admin/fiscalyear.php
View File

@ -59,10 +59,10 @@ $max=100;
$form = new Form($db); $form = new Form($db);
llxHeader('',$title);
$title = $langs->trans('FiscalYears'); $title = $langs->trans('FiscalYears');
llxHeader('',$title,LOG_ERR);
print_fiche_titre($langs->trans('FiscalYears')); print_fiche_titre($langs->trans('FiscalYears'));
$sql = "SELECT f.rowid, f.label, f.date_start, f.date_end, f.statut, f.entity"; $sql = "SELECT f.rowid, f.label, f.date_start, f.date_end, f.statut, f.entity";

2
htdocs/adherents/card.php
View File

@ -70,7 +70,7 @@ $extralabels=$extrafields->fetch_name_optionals_label($object->table_element);
// Get object canvas (By default, this is not defined, so standard usage of dolibarr) // Get object canvas (By default, this is not defined, so standard usage of dolibarr)
$object->getCanvas($rowid); $object->getCanvas($rowid);
$canvas = $object->canvas?$object->canvas:GETPOST("canvas"); $canvas = $object->canvas?$object->canvas:GETPOST("canvas");
$objcanvas=''; $objcanvas=null;
if (! empty($canvas)) if (! empty($canvas))
{ {
require_once DOL_DOCUMENT_ROOT.'/core/class/canvas.class.php'; require_once DOL_DOCUMENT_ROOT.'/core/class/canvas.class.php';

2
htdocs/admin/dons.php
View File

@ -37,6 +37,8 @@ $typeconst=array('yesno','texte','chaine');
$action = GETPOST('action','alpha'); $action = GETPOST('action','alpha');
$type='donation';
/* /*
* Action * Action

2
htdocs/core/class/commonobject.class.php
View File

@ -34,7 +34,7 @@
*/ */
abstract class CommonObject abstract class CommonObject
{ {
protected $db; public $db;
public $error; public $error;
public $errors; public $errors;
public $canvas; // Contains canvas name if it is public $canvas; // Contains canvas name if it is

2
htdocs/core/class/extrafields.class.php
View File

@ -56,7 +56,7 @@ class ExtraFields
var $error; var $error;
var $errno; var $errno;
static $type2label=array( public static $type2label=array(
'varchar'=>'String', 'varchar'=>'String',
'text'=>'TextLong', 'text'=>'TextLong',
'int'=>'Int', 'int'=>'Int',

1
htdocs/core/lib/accounting.lib.php
View File

@ -26,6 +26,7 @@
/** /**
* Prepare array with list of admin tabs * Prepare array with list of admin tabs
* *
* @param $object Object instance we show card
* @return array Array of tabs to show * @return array Array of tabs to show
*/ */
function admin_accounting_prepare_head($object=null) function admin_accounting_prepare_head($object=null)

2
htdocs/product/card.php
View File

@ -74,7 +74,7 @@ if ($id > 0 || ! empty($ref))
// Get object canvas (By default, this is not defined, so standard usage of dolibarr) // Get object canvas (By default, this is not defined, so standard usage of dolibarr)
$canvas = !empty($object->canvas)?$object->canvas:GETPOST("canvas"); $canvas = !empty($object->canvas)?$object->canvas:GETPOST("canvas");
$objcanvas=''; $objcanvas=null;
if (! empty($canvas)) if (! empty($canvas))
{ {
require_once DOL_DOCUMENT_ROOT.'/core/class/canvas.class.php'; require_once DOL_DOCUMENT_ROOT.'/core/class/canvas.class.php';

2
htdocs/product/list.php
View File

@ -69,7 +69,7 @@ $limit = $conf->liste_limit;
// Get object canvas (By default, this is not defined, so standard usage of dolibarr) // Get object canvas (By default, this is not defined, so standard usage of dolibarr)
$canvas=GETPOST("canvas"); $canvas=GETPOST("canvas");
$objcanvas=''; $objcanvas=null;
if (! empty($canvas)) if (! empty($canvas))
{ {
require_once DOL_DOCUMENT_ROOT.'/core/class/canvas.class.php'; require_once DOL_DOCUMENT_ROOT.'/core/class/canvas.class.php';

2
htdocs/product/reassort.php
View File

@ -63,7 +63,7 @@ $search_categ = GETPOST("search_categ");
// Get object canvas (By default, this is not defined, so standard usage of dolibarr) // Get object canvas (By default, this is not defined, so standard usage of dolibarr)
$canvas=GETPOST("canvas"); $canvas=GETPOST("canvas");
$objcanvas=''; $objcanvas=null;
if (! empty($canvas)) if (! empty($canvas))
{ {
require_once DOL_DOCUMENT_ROOT.'/core/class/canvas.class.php'; require_once DOL_DOCUMENT_ROOT.'/core/class/canvas.class.php';

2
htdocs/societe/soc.php
View File

@ -65,7 +65,7 @@ $extralabels=$extrafields->fetch_name_optionals_label($object->table_element);
// Get object canvas (By default, this is not defined, so standard usage of dolibarr) // Get object canvas (By default, this is not defined, so standard usage of dolibarr)
$object->getCanvas($socid); $object->getCanvas($socid);
$canvas = $object->canvas?$object->canvas:GETPOST("canvas"); $canvas = $object->canvas?$object->canvas:GETPOST("canvas");
$objcanvas=''; $objcanvas=null;
if (! empty($canvas)) if (! empty($canvas))
{ {
require_once DOL_DOCUMENT_ROOT.'/core/class/canvas.class.php'; require_once DOL_DOCUMENT_ROOT.'/core/class/canvas.class.php';