Fix error management

This commit is contained in:
Laurent Destailleur 2022-11-23 18:49:59 +01:00
parent fb2b4ea388
commit b42b0ef841
2 changed files with 10 additions and 6 deletions

View File

@ -2957,7 +2957,7 @@ class Adherent extends CommonObject
dol_syslog(__METHOD__.' - Process delta = '.$daysbeforeend, LOG_DEBUG); dol_syslog(__METHOD__.' - Process delta = '.$daysbeforeend, LOG_DEBUG);
if (!is_numeric($daysbeforeend)) { if (!is_numeric($daysbeforeend)) {
$blockingerrormsg = "Value for delta is not a positive or negative numeric"; $blockingerrormsg = "Value for delta is not a numeric value";
$nbko++; $nbko++;
break; break;
} }
@ -2968,6 +2968,7 @@ class Adherent extends CommonObject
$sql = 'SELECT rowid FROM '.MAIN_DB_PREFIX.'adherent'; $sql = 'SELECT rowid FROM '.MAIN_DB_PREFIX.'adherent';
$sql .= " WHERE entity = ".((int) $conf->entity); // Do not use getEntity('adherent').")" here, we want the batch to be on its entity only; $sql .= " WHERE entity = ".((int) $conf->entity); // Do not use getEntity('adherent').")" here, we want the batch to be on its entity only;
$sql .= " AND datefin = '".$this->db->idate($datetosearchfor)."'"; $sql .= " AND datefin = '".$this->db->idate($datetosearchfor)."'";
//$sql .= " LIMIT 10000";
$resql = $this->db->query($sql); $resql = $this->db->query($sql);
if ($resql) { if ($resql) {
@ -3000,7 +3001,7 @@ class Adherent extends CommonObject
dol_syslog("sendReminderForExpiredSubscription Language for member id ".$adherent->id." set to ".$outputlangs->defaultlang." mysoc->default_lang=".$mysoc->default_lang); dol_syslog("sendReminderForExpiredSubscription Language for member id ".$adherent->id." set to ".$outputlangs->defaultlang." mysoc->default_lang=".$mysoc->default_lang);
$arraydefaultmessage = null; $arraydefaultmessage = null;
$labeltouse = $conf->global->ADHERENT_EMAIL_TEMPLATE_REMIND_EXPIRATION; $labeltouse = getDolGlobalString('ADHERENT_EMAIL_TEMPLATE_REMIND_EXPIRATION');
if (!empty($labeltouse)) { if (!empty($labeltouse)) {
$arraydefaultmessage = $formmail->getEMailTemplate($this->db, 'member', $user, $outputlangs, 0, 1, $labeltouse); $arraydefaultmessage = $formmail->getEMailTemplate($this->db, 'member', $user, $outputlangs, 0, 1, $labeltouse);
@ -3024,7 +3025,7 @@ class Adherent extends CommonObject
$result = $cmail->sendfile(); $result = $cmail->sendfile();
if (!$result) { if (!$result) {
$error++; $error++;
$this->error = $cmail->error; $this->error .= $cmail->error.' ';
if (!is_null($cmail->errors)) { if (!is_null($cmail->errors)) {
$this->errors += $cmail->errors; $this->errors += $cmail->errors;
} }
@ -3089,7 +3090,10 @@ class Adherent extends CommonObject
$actioncomm->create($user); $actioncomm->create($user);
} }
} else { } else {
$blockingerrormsg = "Can't find email template, defined into member module setup, to use for reminding"; //$blockingerrormsg = "Can't find email template with label=".$labeltouse.", to use for the reminding email";
$error++;
$this->error .= "Can't find email template with label=".$labeltouse.", to use for the reminding email ";
$nbko++; $nbko++;
$listofmembersko[$adherent->id] = $adherent->id; $listofmembersko[$adherent->id] = $adherent->id;
@ -3159,6 +3163,6 @@ class Adherent extends CommonObject
} }
} }
return 0; return $nbko;
} }
} }

View File

@ -1279,7 +1279,7 @@ class FormMail extends Form
* *
* @param DoliDB $dbs Database handler * @param DoliDB $dbs Database handler
* @param string $type_template Get message for model/type=$type_template, type='all' also included. * @param string $type_template Get message for model/type=$type_template, type='all' also included.
* @param User $user Get template public or limited to this user * @param User $user Get templates public + limited to this user
* @param Translate $outputlangs Output lang object * @param Translate $outputlangs Output lang object
* @param int $id Id of template to get, or -1 for first found with position 0, or 0 for first found whatever is position (priority order depends on lang provided or not) or -2 for exact match with label (no answer if not found) * @param int $id Id of template to get, or -1 for first found with position 0, or 0 for first found whatever is position (priority order depends on lang provided or not) or -2 for exact match with label (no answer if not found)
* @param int $active 1=Only active template, 0=Only disabled, -1=All * @param int $active 1=Only active template, 0=Only disabled, -1=All