First test of qodana

.scrutinizer.yml

@@ -22,7 +22,9 @@ filter:
         - documents/
         - node_modules/
         - test/
+        - htdocs/custom/
         - htdocs/includes/
+        - htdocs/install/doctemplates/
     #dependency_paths:
     #    - htdocs/includes/
     paths: 
@@ -43,7 +45,9 @@ tools:
                 - dev/
                 - doc/
                 - documents/
+                - htdocs/custom/
                 - htdocs/includes/
+                - htdocs/install/doctemplates/
                 - htdocs/core/class/lessc.class.php
                 - node_modules/
                 - test/

dev/setup/qodana/README.md

@@ -0,0 +1,14 @@
+QODANA TUTO
+-----------
+This README explains how to use qodana to generate static analytics reports on the code
+ 
+Install docker
+ 
+ 
+Install qodana
+ 
+ 
+To run inspection on CLI
+ cd ~/git/dirtoscan
+ sudo qodana scan --show-report
+ 

htdocs/accountancy/bookkeeping/list.php

@@ -999,7 +999,7 @@ if ($massactionbutton && $contextpage != 'poslist') {
 $moreforfilter = '';
 
 $parameters = array();
-$reshook = $hookmanager->executeHooks('printFieldPreListTitle', $parameters, getDolGlobalString('MAIN_CHECKBOX_LEFT_COLUMN')); // Note that $action and $object may have been modified by hook
+$reshook = $hookmanager->executeHooks('printFieldPreListTitle', $parameters, $object, $action); // Note that $action and $object may have been modified by hook
 if (empty($reshook)) {
 	$moreforfilter .= $hookmanager->resPrint;
 } else {

qodana.yaml

@@ -0,0 +1,18 @@
+version: "1.0"
+linter: jetbrains/qodana-php:2022.3-eap
+failThreshold: 0
+profile:
+  name: qodana.recommended
+exclude:
+  - name: All
+    paths:
+      - dev
+      - build
+      - doc
+      - documents
+      - node_modules
+      - test
+      - htdocs/custom
+      - htdocs/includes
+      - htdocs/install/doctemplates
+