lainwir3d/dolibarr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Qual: Remove errors reported by PHP Code Sniffer

Browse Source
This commit is contained in:
Laurent Destailleur 2011-08-28 17:45:06 +00:00
parent 76a6d6a6fe
commit bb41478886
3 changed files with 25 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
htdocs/bookmarks/bookmarks.lib.php
View File

@ -24,8 +24,8 @@
/** /**
* Add area with bookmarks in menu * Add area with bookmarks in menu
* *
* @param $aDb * @param DoliDb $aDb Database handler
* @param $aLangs * @param Translate $aLangs Object lang
* @return string * @return string
*/ */
function printBookmarksList ($aDb, $aLangs) function printBookmarksList ($aDb, $aLangs)

38
htdocs/bookmarks/class/bookmark.class.php
View File

@ -41,9 +41,10 @@ class Bookmark
/** /**
* \brief Manufacturer * Constructor
* \param db Handler for Database Access *
* \param id Bookmark Id * @param DoliDB $db Handler for Database Access
* @param int $id Bookmark Id
*/ */
function Bookmark($db, $id=-1) function Bookmark($db, $id=-1)
{ {
@ -52,8 +53,10 @@ class Bookmark
} }
/** /**
* \brief Directs the bookmark * Directs the bookmark
* \param id Bookmark Id Loader *
* @param int $id Bookmark Id Loader
* @return int <0 if KO, >0 if OK
*/ */
function fetch($id) function fetch($id)
{ {
@ -63,7 +66,7 @@ class Bookmark
$sql.= " WHERE rowid = ".$id; $sql.= " WHERE rowid = ".$id;
dol_syslog("Bookmark::fetch sql=".$sql, LOG_DEBUG); dol_syslog("Bookmark::fetch sql=".$sql, LOG_DEBUG);
$resql = $this->db->query ($sql); $resql = $this->db->query($sql);
if ($resql) if ($resql)
{ {
$obj = $this->db->fetch_object($resql); $obj = $this->db->fetch_object($resql);
@ -90,8 +93,9 @@ class Bookmark
} }
/** /**
* \brief Insere bookmark en base * Insert bookmark into database
* \return int <0 si ko, rowid du bookmark cree si ok *
* @return int <0 si ko, rowid du bookmark cree si ok
*/ */
function create() function create()
{ {
@ -114,7 +118,7 @@ class Bookmark
$sql.= ")"; $sql.= ")";
dol_syslog("Bookmark::update sql=".$sql, LOG_DEBUG); dol_syslog("Bookmark::update sql=".$sql, LOG_DEBUG);
$resql = $this->db->query ($sql); $resql = $this->db->query($sql);
if ($resql) if ($resql)
{ {
$id = $this->db->last_insert_id(MAIN_DB_PREFIX."bookmark"); $id = $this->db->last_insert_id(MAIN_DB_PREFIX."bookmark");
@ -142,8 +146,9 @@ class Bookmark
} }
/** /**
* \brief Update bookmark record * Update bookmark record
* \return int <0 si ko, >0 si ok *
* @return int <0 if KO, > if OK
*/ */
function update() function update()
{ {
@ -163,7 +168,7 @@ class Bookmark
$sql.= " WHERE rowid = ".$this->id; $sql.= " WHERE rowid = ".$this->id;
dol_syslog("Bookmark::update sql=".$sql, LOG_DEBUG); dol_syslog("Bookmark::update sql=".$sql, LOG_DEBUG);
if ($this->db->query ($sql)) if ($this->db->query($sql))
{ {
return 1; return 1;
} }
@ -175,9 +180,10 @@ class Bookmark
} }
/** /**
* \brief Removes the bookmark * Removes the bookmark
* \param id Id removed bookmark *
* \return int <0 si ko, >0 si ok * @param int $id Id removed bookmark
* @return int <0 si ko, >0 si ok
*/ */
function remove($id) function remove($id)
{ {
@ -185,7 +191,7 @@ class Bookmark
$sql .= " WHERE rowid = ".$id; $sql .= " WHERE rowid = ".$id;
dol_syslog("Bookmark::remove sql=".$sql, LOG_DEBUG); dol_syslog("Bookmark::remove sql=".$sql, LOG_DEBUG);
$resql=$this->db->query ($sql); $resql=$this->db->query($sql);
if ($resql) if ($resql)
{ {
return 1; return 1;

2
htdocs/bookmarks/liste.php
View File

@ -75,7 +75,7 @@ $sql.= " FROM ".MAIN_DB_PREFIX."bookmark as b LEFT JOIN ".MAIN_DB_PREFIX."user a
$sql.= " WHERE 1=1"; $sql.= " WHERE 1=1";
if (! $user->admin) $sql.= " AND (b.fk_user = ".$user->id." OR b.fk_user is NULL OR b.fk_user = 0)"; if (! $user->admin) $sql.= " AND (b.fk_user = ".$user->id." OR b.fk_user is NULL OR b.fk_user = 0)";
$sql.= $db->order($sortfield.", position",$sortorder); $sql.= $db->order($sortfield.", position",$sortorder);
$sql.= $db->plimit( $limit, $offset); $sql.= $db->plimit($limit, $offset);
$resql=$db->query($sql); $resql=$db->query($sql);
if ($resql) if ($resql)