From 2f759e0c1867c5c5d2c648083d698b774676b33d Mon Sep 17 00:00:00 2001 From: Abbes Bahfir Date: Tue, 12 Jun 2018 00:34:36 +0100 Subject: [PATCH 1/2] Fix: Do not activate module if errors on module SQL queries execution --- .../modulebuilder/template/core/modules/modMyModule.class.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/htdocs/modulebuilder/template/core/modules/modMyModule.class.php b/htdocs/modulebuilder/template/core/modules/modMyModule.class.php index c278eea3f09..01ab77bb06b 100644 --- a/htdocs/modulebuilder/template/core/modules/modMyModule.class.php +++ b/htdocs/modulebuilder/template/core/modules/modMyModule.class.php @@ -314,7 +314,8 @@ class modMyModule extends DolibarrModules */ public function init($options='') { - $this->_load_tables('/mymodule/sql/'); + $result=$this->_load_tables('/mymodule/sql/'); + if(!$result) return -1;// Fix: Do not activate module if errors on module SQL queries execution // Create extrafields include_once DOL_DOCUMENT_ROOT.'/core/class/extrafields.class.php'; From 98ae8e18df35257321025cc2365e33d652234e3d Mon Sep 17 00:00:00 2001 From: Laurent Destailleur Date: Wed, 13 Jun 2018 21:27:57 +0200 Subject: [PATCH 2/2] Update modMyModule.class.php --- .../modulebuilder/template/core/modules/modMyModule.class.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/htdocs/modulebuilder/template/core/modules/modMyModule.class.php b/htdocs/modulebuilder/template/core/modules/modMyModule.class.php index 01ab77bb06b..d30e944260a 100644 --- a/htdocs/modulebuilder/template/core/modules/modMyModule.class.php +++ b/htdocs/modulebuilder/template/core/modules/modMyModule.class.php @@ -315,7 +315,7 @@ class modMyModule extends DolibarrModules public function init($options='') { $result=$this->_load_tables('/mymodule/sql/'); - if(!$result) return -1;// Fix: Do not activate module if errors on module SQL queries execution + if ($result < 0) return -1; // Do not activate module if not allowed errors found on module SQL queries (the _load_table run sql with run_sql with error allowed parameter to 'default') // Create extrafields include_once DOL_DOCUMENT_ROOT.'/core/class/extrafields.class.php';