lainwir3d/dolibarr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #22615 from marc-dll/14.0_FIX_hidden_extrafields_update

Browse Source 
FIX: only modify hidden checkbox/multislected extrafields on update if they are provided in request
This commit is contained in:
Laurent Destailleur 2022-10-25 19:43:41 +02:00 committed by GitHub
commit bf794cacc0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
htdocs/core/class/extrafields.class.php
View File

@ -2084,13 +2084,21 @@ class ExtraFields
$enabled = 1; $enabled = 1;
if (isset($this->attributes[$object->table_element]['list'][$key])) { if (isset($this->attributes[$object->table_element]['list'][$key])) {
$enabled = dol_eval($this->attributes[$object->table_element]['list'][$key], 1); $enabled = intval(dol_eval($this->attributes[$object->table_element]['list'][$key], 1));
} }
$perms = 1; $perms = 1;
if (isset($this->attributes[$object->table_element]['perms'][$key])) { if (isset($this->attributes[$object->table_element]['perms'][$key])) {
$perms = dol_eval($this->attributes[$object->table_element]['perms'][$key], 1); $perms = dol_eval($this->attributes[$object->table_element]['perms'][$key], 1);
} }
if (empty($enabled)) { if (
empty($enabled)
|| (
$onlykey === '@GETPOSTISSET'
&& in_array($this->attributes[$object->table_element]['type'][$key], array('boolean', 'chkbxlst'))
&& in_array(abs($enabled), array(2, 5))
&& ! GETPOSTISSET('options_' . $key) // Update hidden checkboxes and multiselect only if they are provided
)
) {
continue; continue;
} }
if (empty($perms)) { if (empty($perms)) {