From c207080527eed2c094f812047b82d52e312c928b Mon Sep 17 00:00:00 2001
From: Laurent Destailleur <eldy@destailleur.fr>
Date: Thu, 24 May 2012 00:26:39 +0200
Subject: [PATCH] Error management

---
 htdocs/viewimage.php | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/htdocs/viewimage.php b/htdocs/viewimage.php
index 6fac7405ebb..83c0b3852e9 100644
--- a/htdocs/viewimage.php
+++ b/htdocs/viewimage.php
@@ -331,10 +331,16 @@ if (preg_match('/\.\./',$original_file) || preg_match('/[<>|]/',$original_file))
 
 if ($modulepart == 'barcode')
 {
-    $generator=$_GET["generator"];
-    $code=$_GET["code"];
-    $encoding=$_GET["encoding"];
-    $readable=$_GET["readable"]?$_GET["readable"]:"Y";
+    $generator=GETPOST("generator","alpha");
+    $code=GETPOST("code");
+    $encoding=GETPOST("encoding","alpha");
+    $readable=GETPOST("readable")?GETPOST("readable","alpha"):"Y";
+
+    if (empty($generator) || empty($encoding))
+    {
+        dol_print_error(0,'Error, parameter "generator" or "encoding" not defined');
+        exit;
+    }
 
     $dirbarcode=array_merge(array("/core/modules/barcode/"),$conf->modules_parts['barcode']);