From c739b9566609afdf1cd71a64cdf6730dad8e43e9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jean=20Traull=C3=A9?= <jtraulle@opencomp.fr>
Date: Wed, 14 Aug 2019 23:33:06 +0200
Subject: [PATCH] Fix codestyle lessc.class.php should be excluded from ruleset
 as it is an external lib

---
 dev/setup/codesniffer/ruleset.xml                  | 1 +
 htdocs/core/lib/files.lib.php                      | 2 +-
 htdocs/fourn/class/api_supplier_invoices.class.php | 6 +++---
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/dev/setup/codesniffer/ruleset.xml b/dev/setup/codesniffer/ruleset.xml
index daf73e5b2a7..89ea98a051b 100644
--- a/dev/setup/codesniffer/ruleset.xml
+++ b/dev/setup/codesniffer/ruleset.xml
@@ -6,6 +6,7 @@
 	<exclude-pattern type="relative">build/html</exclude-pattern>
 	<exclude-pattern type="relative">build/aps</exclude-pattern>
 	<exclude-pattern type="relative">documents</exclude-pattern>
+	<exclude-pattern type="relative">htdocs/core/class/lessc.class.php</exclude-pattern>
 	<exclude-pattern type="relative">htdocs/custom</exclude-pattern>
 	<exclude-pattern type="relative">htdocs/includes</exclude-pattern>
 	<exclude-pattern type="relative">htdocs/install/doctemplates/websites</exclude-pattern>
diff --git a/htdocs/core/lib/files.lib.php b/htdocs/core/lib/files.lib.php
index 79b0badf0ff..a5bbd68a736 100644
--- a/htdocs/core/lib/files.lib.php
+++ b/htdocs/core/lib/files.lib.php
@@ -1911,7 +1911,7 @@ function dol_compress_file($inputfile, $outputfile, $mode = "gz")
 				dol_syslog("Class ZipArchive is set so we zip using ZipArchive to zip into ".$outputfile.' rootPath='.$rootPath);
 				$zip = new ZipArchive;
 
-				if ($zip->open($outputfile, ZipArchive::CREATE)!==TRUE) {
+				if ($zip->open($outputfile, ZipArchive::CREATE)!==true) {
 					$errormsg="Failed to open file ".$outputfile."\n";
 					dol_syslog("dol_compress_file failure - ".$errormsg, LOG_ERR);
 					return -6;
diff --git a/htdocs/fourn/class/api_supplier_invoices.class.php b/htdocs/fourn/class/api_supplier_invoices.class.php
index a4cdadc8265..a2da7a77494 100644
--- a/htdocs/fourn/class/api_supplier_invoices.class.php
+++ b/htdocs/fourn/class/api_supplier_invoices.class.php
@@ -362,9 +362,9 @@ class SupplierInvoices extends DolibarrApi
             throw new RestException(400, 'Invoice ID is mandatory');
         }
 
-    if( ! DolibarrApi::_checkAccessToResource('fournisseur', $this->invoice->id, 'facture_fourn', 'facture')) {
-            throw new RestException(401, 'Access not allowed for login '.DolibarrApiAccess::$user->login);
-        }
+		if( ! DolibarrApi::_checkAccessToResource('fournisseur', $this->invoice->id, 'facture_fourn', 'facture')) {
+			throw new RestException(401, 'Access not allowed for login '.DolibarrApiAccess::$user->login);
+		}
 
         $result = $this->invoice->fetch($id);
         if( ! $result ) {