From cbd8fa357295477854f244bc4760d59d1ddd64e2 Mon Sep 17 00:00:00 2001
From: altairis-noe <noe.cendrier@altairis.fr>
Date: Thu, 8 Jul 2021 16:42:54 +0200
Subject: [PATCH] better element id

---
 htdocs/product/card.php | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/htdocs/product/card.php b/htdocs/product/card.php
index 5b8c431d65d..be278127220 100644
--- a/htdocs/product/card.php
+++ b/htdocs/product/card.php
@@ -1650,21 +1650,20 @@ if (is_object($objcanvas) && $objcanvas->displayCanvasExists($action)) {
 						print '<script type="text/javascript">
 						$(document).ready(function() {
 							$("#field_mask").parent().addClass("hideobject");
-							var preselect = $("#status_batch option:selected");';
+							var preselect = document.getElementById("status_batch");';
 						if ($conf->global->PRODUCTBATCH_SN_USE_PRODUCT_MASKS)
 						{
-						print 'if (preselect == "2") {
-								$("#field_mask").parent().toggleClass("hideobject");
+						print 'if (preselect.value == "2") {
+								$("#field_mask").parent().removeClass("hideobject");
 							}';
 						}
 						if ($conf->global->PRODUCTBATCH_LOT_USE_PRODUCT_MASKS)
 						{
-						print 'if (preselect == "1") {
-								$("#field_mask").parent().toggleClass("hideobject");
+						print 'if (preselect.value == "1") {
+								$("#field_mask").parent().removeClass("hideobject");
 							}';
 						}
 						print '$("#status_batch").on("change", function () {
-								console.log("We change batch status");
 								var optionSelected = $("option:selected", this);
 								var valueSelected = this.value;
 								$("#field_mask").parent().addClass("hideobject");
@@ -1672,7 +1671,7 @@ if (is_object($objcanvas) && $objcanvas->displayCanvasExists($action)) {
 						if ($conf->global->PRODUCTBATCH_LOT_USE_PRODUCT_MASKS && $conf->global->PRODUCTBATCH_LOT_ADDON == 'mod_lot_advanced') {
 							print '
 								if (this.value == 1) {
-									$("#field_mask").parent().toggleClass("hideobject");
+									$("#field_mask").parent().removeClass("hideobject");
 									$("#batch_mask_input").val("'.$inherited_mask_lot.'");
 								}
 							';
@@ -1680,7 +1679,7 @@ if (is_object($objcanvas) && $objcanvas->displayCanvasExists($action)) {
 						if ($conf->global->PRODUCTBATCH_SN_USE_PRODUCT_MASKS && $conf->global->PRODUCTBATCH_SN_ADDON == 'mod_sn_advanced') {
 							print '
 								if (this.value == 2) {
-									$("#field_mask").parent().toggleClass("hideobject");
+									$("#field_mask").parent().removeClass("hideobject");
 									$("#batch_mask_input").val("'.$inherited_mask_sn.'");
 								}
 							';